From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Jiang Jian <jiangjian@cdjrlc.com>
Cc: tsbogend@alpha.franken.de, srinivas.kandagatla@linaro.org,
rafael@kernel.org, sudeep.holla@arm.com,
alexandre.belloni@bootlin.com, xkernel.wang@foxmail.com,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mips: sgi-ip22: Remove duplicate 'of' in two places.
Date: Tue, 21 Jun 2022 21:47:57 +0200 [thread overview]
Message-ID: <20220621194757.ay4z6bbwev7ibggs@pengutronix.de> (raw)
In-Reply-To: <20220621162114.23723-1-jiangjian@cdjrlc.com>
[-- Attachment #1: Type: text/plain, Size: 975 bytes --]
The Subject speaks about two places, there is only one change here
however?
On Wed, Jun 22, 2022 at 12:21:14AM +0800, Jiang Jian wrote:
> file: ./arch/mips/sgi-ip22/ip22-gio.c
> line: 44
> * @ids: array of of device match structures to search in
> changed to
> * @ids: array of device match structures to search in
I know writing a sensible commit log is hard, but this is really very
useless. This is a plain repetition of the diff below.
Additionally I'm not sure the patch is right. The comment speaks about
of (= open firmware) devices. So if you want to improve here, maybe make
it read
+ * @match: array gio_device_id structures to search in
But please double check this is indeed sensible; I didn't.
(But yes, @ids is wrong, the parameter is named match.)
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2022-06-21 19:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-21 16:21 [PATCH] mips: sgi-ip22: Remove duplicate 'of' in two places Jiang Jian
2022-06-21 19:47 ` Uwe Kleine-König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220621194757.ay4z6bbwev7ibggs@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=alexandre.belloni@bootlin.com \
--cc=jiangjian@cdjrlc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=sudeep.holla@arm.com \
--cc=tsbogend@alpha.franken.de \
--cc=xkernel.wang@foxmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).