From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1CCDC43334 for ; Tue, 28 Jun 2022 02:29:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244084AbiF1C3O (ORCPT ); Mon, 27 Jun 2022 22:29:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39916 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244590AbiF1C1a (ORCPT ); Mon, 27 Jun 2022 22:27:30 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6A7E825C5E; Mon, 27 Jun 2022 19:24:55 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0721C6172F; Tue, 28 Jun 2022 02:24:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CE7E7C341CA; Tue, 28 Jun 2022 02:24:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1656383094; bh=gBf2FASKH5N/2icjNawQqMpLTWAtw42YwowtPP9Y2uE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hzDwbbFJKgOmpvqR7bqgfJ/UeiOyw4JLoStHQtD3Kf246+hDRiLv9XKxH8vWCOu6f v+Wd1qwJOUiP02Gg4Xfz9VwAxxd76APe9r2iaBQNilBhz91yCS22uYVKTDHBkR9byE nBRRx/iMAd8wOvO8saY4MDDDX0hM5pwl/LHMcvWOkFfx/hT+XswhBSSPyMRRrquWny OebuZpYOe1DcDnpJTGpmGNklw2uy43P5VMCtk7H+CFAier8ak9UHIGXVY/ITeN5huP l+JbS7M7nl9bS5lK0EMBBQTKnwmrLUenLLDoAaW3Q3ZuPS/W+S2sPmXwNnpdHF55J1 UE8yDH3gVU+KQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Liang He , Thomas Bogendoerfer , Sasha Levin , linux-mips@vger.kernel.org Subject: [PATCH AUTOSEL 5.4 17/27] mips: mti-malta: Fix refcount leak in malta-time.c Date: Mon, 27 Jun 2022 22:24:03 -0400 Message-Id: <20220628022413.596341-17-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220628022413.596341-1-sashal@kernel.org> References: <20220628022413.596341-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org From: Liang He [ Upstream commit 608d94cb84c42585058d692f2fe5d327f8868cdb ] In update_gic_frequency_dt(), of_find_compatible_node() will return a node pointer with refcount incremented. We should use of_node_put() when it is not used anymore. Signed-off-by: Liang He Signed-off-by: Thomas Bogendoerfer Signed-off-by: Sasha Levin --- arch/mips/mti-malta/malta-time.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/mips/mti-malta/malta-time.c b/arch/mips/mti-malta/malta-time.c index 7efcfe0c9cd4..7ac06bc8a86e 100644 --- a/arch/mips/mti-malta/malta-time.c +++ b/arch/mips/mti-malta/malta-time.c @@ -219,6 +219,8 @@ static void update_gic_frequency_dt(void) if (of_update_property(node, &gic_frequency_prop) < 0) pr_err("error updating gic frequency property\n"); + + of_node_put(node); } #endif -- 2.35.1