From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 321CFCCA483 for ; Tue, 28 Jun 2022 02:29:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244219AbiF1C3R (ORCPT ); Mon, 27 Jun 2022 22:29:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40416 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244620AbiF1C1c (ORCPT ); Mon, 27 Jun 2022 22:27:32 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AB65C25C74; Mon, 27 Jun 2022 19:25:03 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 5EEB2B81C0B; Tue, 28 Jun 2022 02:25:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3BDE1C36AE2; Tue, 28 Jun 2022 02:25:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1656383101; bh=vqAIaDWW3iv2j339ceMXd+UQ8Tm0iyh9/X6XHm3k25s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nFDfTI9E8vsS4XETH0t0448pT13XvrimGHzNsDifMtTabTKa6okMt+ERClO69/g0F 6eQKtlfiOZTLMq862rJBUjbAC0X5UaKEGN9XmcMmXSfu85JatffYBNp+HJL8hulVPy s1+m4Uvo8ttXuks6jvabRvkjYupQBnB/g7Q10LartBRkvmiSBckCnCiAKChk6W1Gi5 zzAcsJoSx6V0KX06tlTnoSlUl64+9071ZTia2UNQP6P5Ky347Fj67arLi2TvwDJ67Y lZSr8sPLKoLVyBryQRb8hMT8f9+WSq+DDa+UOSUj030YFQ/JKa+Nr+/IegXo9iJfN1 41tgBWFSWlGiA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Liang He , Thomas Bogendoerfer , Sasha Levin , john@phrozen.org, xkernel.wang@foxmail.com, linux-mips@vger.kernel.org Subject: [PATCH AUTOSEL 5.4 20/27] mips: lantiq: xway: Fix refcount leak bug in sysctrl Date: Mon, 27 Jun 2022 22:24:06 -0400 Message-Id: <20220628022413.596341-20-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220628022413.596341-1-sashal@kernel.org> References: <20220628022413.596341-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org From: Liang He [ Upstream commit 76695592711ef1e215cc24ed3e1cd857d7fc3098 ] In ltq_soc_init(), of_find_compatible_node() will return a node pointer with refcount incremented. We should use of_node_put() when it is not used anymore. Signed-off-by: Liang He Signed-off-by: Thomas Bogendoerfer Signed-off-by: Sasha Levin --- arch/mips/lantiq/xway/sysctrl.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/arch/mips/lantiq/xway/sysctrl.c b/arch/mips/lantiq/xway/sysctrl.c index 6c2d9779ac72..c5eb7830bab1 100644 --- a/arch/mips/lantiq/xway/sysctrl.c +++ b/arch/mips/lantiq/xway/sysctrl.c @@ -437,6 +437,10 @@ void __init ltq_soc_init(void) of_address_to_resource(np_ebu, 0, &res_ebu)) panic("Failed to get core resources"); + of_node_put(np_pmu); + of_node_put(np_cgu); + of_node_put(np_ebu); + if (!request_mem_region(res_pmu.start, resource_size(&res_pmu), res_pmu.name) || !request_mem_region(res_cgu.start, resource_size(&res_cgu), -- 2.35.1