From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBCE5CCA483 for ; Tue, 28 Jun 2022 02:29:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244602AbiF1C3g (ORCPT ); Mon, 27 Jun 2022 22:29:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39860 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244836AbiF1C2K (ORCPT ); Mon, 27 Jun 2022 22:28:10 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8202B24F3D; Mon, 27 Jun 2022 19:26:44 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0D7DB618F4; Tue, 28 Jun 2022 02:26:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B9E04C34115; Tue, 28 Jun 2022 02:26:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1656383203; bh=Jbj3KyWfrVnGUc7SFB+0dOvbp461Vbc7uw0NCV65NlI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hIA5Mmw5fcwBASZaLlKM0/sDYrsDg6P748WxKwfknynhWEOqzbkXymMQBe5yRJCHP zMkFBlahqfJ7Ose+Y8h8/smpMG/moPcIaKhBKqaN3fyJqSb/Uvg3W+0raPPibBkMPL rAd0tCRSv+U1Q/I67YZKQh3QrOARzbRCpmxpb6GqAzzdKpJEo65cG7IzwImo10nWc0 Ezh1q47erh/eMRr9v5w9KL6GM3Ms23RnqbKZ7AxbU3Z2wJfjlWQkCwEDMsha6Uhg6F 5nn6Z9Tu2mciUVhzSnOBc7BKTdQXTFNucE99MVLyueszLyhjmwG6mR3sxsUsZTzo0S ehuqF/LtfWygA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Liang He , Thomas Bogendoerfer , Sasha Levin , linux-mips@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 11/17] mips: mti-malta: Fix refcount leak in malta-time.c Date: Mon, 27 Jun 2022 22:26:09 -0400 Message-Id: <20220628022615.596977-11-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220628022615.596977-1-sashal@kernel.org> References: <20220628022615.596977-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org From: Liang He [ Upstream commit 608d94cb84c42585058d692f2fe5d327f8868cdb ] In update_gic_frequency_dt(), of_find_compatible_node() will return a node pointer with refcount incremented. We should use of_node_put() when it is not used anymore. Signed-off-by: Liang He Signed-off-by: Thomas Bogendoerfer Signed-off-by: Sasha Levin --- arch/mips/mti-malta/malta-time.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/mips/mti-malta/malta-time.c b/arch/mips/mti-malta/malta-time.c index 66c866740ff2..eef336192d7f 100644 --- a/arch/mips/mti-malta/malta-time.c +++ b/arch/mips/mti-malta/malta-time.c @@ -231,6 +231,8 @@ static void update_gic_frequency_dt(void) if (of_update_property(node, &gic_frequency_prop) < 0) pr_err("error updating gic frequency property\n"); + + of_node_put(node); } #endif -- 2.35.1