From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97D3BCCA485 for ; Tue, 28 Jun 2022 02:29:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244593AbiF1C3f (ORCPT ); Mon, 27 Jun 2022 22:29:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41150 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244839AbiF1C2K (ORCPT ); Mon, 27 Jun 2022 22:28:10 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9E9C825281; Mon, 27 Jun 2022 19:26:45 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3397961934; Tue, 28 Jun 2022 02:26:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E2708C341CB; Tue, 28 Jun 2022 02:26:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1656383204; bh=+eDDetAjqwPG2Dy9hM1ugBJGaLmcBNLv0fJw2xkcJng=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RkSKbNOuyFar/PoVFQCGd3slO9VxA2ctg10aEZhE3CbD3ufqerYoUHVcsQFbn3R2d qrcSQFWoBlk9nM2PjORswVTFuj++K1qhpeil+9kEzlC1n7ISlrfQ92hxs/10NV6AOE O71KeWpIhM4ONhxOeLklxVuo7wFHt4JlI/mHaJZlnP8a6BQ/W25qYZ/NTcrGN4QM6Y kEFYwaYauKQ3DvxMW8pKlaO33/bJjkmrSK+8O/fNo98MIDo3+evr4JD+kt38hZzQro fpNnnO7UKPCghzk9UGAXXQtkg/as9ZJ542f7hw2oWhWI7FM4QFOPUtdF2hzyBMqqPp ARZoaR8UIjY7A== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Liang He , Thomas Bogendoerfer , Sasha Levin , john@phrozen.org, linux-mips@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 12/17] mips: ralink: Fix refcount leak in of.c Date: Mon, 27 Jun 2022 22:26:10 -0400 Message-Id: <20220628022615.596977-12-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220628022615.596977-1-sashal@kernel.org> References: <20220628022615.596977-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org From: Liang He [ Upstream commit 48ca54e39173d1ed4c4dc8cf045484014bb26eaf ] In plat_of_remap_node(), plat_of_remap_node() will return a node pointer with refcount incremented. We should use of_node_put() when it is not used anymore. Signed-off-by: Liang He Signed-off-by: Thomas Bogendoerfer Signed-off-by: Sasha Levin --- arch/mips/ralink/of.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/mips/ralink/of.c b/arch/mips/ralink/of.c index 1f7c686f7218..3cfd5809243e 100644 --- a/arch/mips/ralink/of.c +++ b/arch/mips/ralink/of.c @@ -42,6 +42,8 @@ __iomem void *plat_of_remap_node(const char *node) if (of_address_to_resource(np, 0, &res)) panic("Failed to get resource for %s", node); + of_node_put(np); + if (!request_mem_region(res.start, resource_size(&res), res.name)) -- 2.35.1