From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35D05C43334 for ; Tue, 28 Jun 2022 02:29:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244674AbiF1C3m (ORCPT ); Mon, 27 Jun 2022 22:29:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40554 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244894AbiF1C2R (ORCPT ); Mon, 27 Jun 2022 22:28:17 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 38EEA26540; Mon, 27 Jun 2022 19:27:21 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C27FE6192A; Tue, 28 Jun 2022 02:27:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 39712C341CB; Tue, 28 Jun 2022 02:27:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1656383240; bh=s9Ol33kpSrjmzFWdc4sW7eWoQqLfe0AJTiY9sp9s7jY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Dht7uEJOKMro1I7tuPargXAUrtcvWFlLCcd1LLQCWyfM1KUPrELrYKfVlyGZ5riHg j+fN/g+0MJnOKaNjsyb4sg8Ervrh++tKLNtOxdzu17We82cGlSnBqiUZ+rcK5ZC7lO 1CU7eJ9LCF316FPknMfWiLpPuN/aj97Xyooj5+FIaBTR1wH8Tq7d8DbuIeNd049O5b CsceiQ5uU3CnavutkZj6Xe6JDUOkBfTS3wIA0zxglgAGrbijsO3iugv1hOWougzAfg 7J4oV9JO32T0mnsNjRDrM5GKZveZgGNGEOvXsGaXsgFuRTF2dYo7zU3S+rdkO/Qgon YzW91RkuHcvDw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Liang He , Thomas Bogendoerfer , Sasha Levin , john@phrozen.org, xkernel.wang@foxmail.com, wangborong@cdjrlc.com, linux-mips@vger.kernel.org Subject: [PATCH AUTOSEL 4.9 09/13] mips: lantiq: falcon: Fix refcount leak bug in sysctrl Date: Mon, 27 Jun 2022 22:26:53 -0400 Message-Id: <20220628022657.597208-9-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220628022657.597208-1-sashal@kernel.org> References: <20220628022657.597208-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org From: Liang He [ Upstream commit 72a2af539fff975caadd9a4db3f99963569bd9c9 ] In ltq_soc_init(), of_find_compatible_node() will return a node pointer with refcount incremented. We should use of_node_put() when it is not used anymore. Signed-off-by: Liang He Signed-off-by: Thomas Bogendoerfer Signed-off-by: Sasha Levin --- arch/mips/lantiq/falcon/sysctrl.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/arch/mips/lantiq/falcon/sysctrl.c b/arch/mips/lantiq/falcon/sysctrl.c index 714d92659489..665739bd4190 100644 --- a/arch/mips/lantiq/falcon/sysctrl.c +++ b/arch/mips/lantiq/falcon/sysctrl.c @@ -210,6 +210,12 @@ void __init ltq_soc_init(void) of_address_to_resource(np_sysgpe, 0, &res_sys[2])) panic("Failed to get core resources"); + of_node_put(np_status); + of_node_put(np_ebu); + of_node_put(np_sys1); + of_node_put(np_syseth); + of_node_put(np_sysgpe); + if ((request_mem_region(res_status.start, resource_size(&res_status), res_status.name) < 0) || (request_mem_region(res_ebu.start, resource_size(&res_ebu), -- 2.35.1