linux-mips.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Ning Qiang <sohu0106@126.com>
Cc: greg@kroah.com, security@kernel.org, linux-mips@vger.kernel.org,
	tsbogend@alpha.franken.de
Subject: Re: [PATCH] MIPS: vpe: fix integer overflow in vpe_write()
Date: Thu, 14 Jul 2022 17:21:45 +0300	[thread overview]
Message-ID: <20220714142145.GT2316@kadam> (raw)
In-Reply-To: <20220714141705.2375-1-sohu0106@126.com>

On Thu, Jul 14, 2022 at 10:17:05PM +0800, Ning Qiang wrote:
> In the vpe_write function of arch/mips/kernel/vpe.c,parameter "size_t
> count" is pass by userland, if "count" is very large, it will bypass
> the check of "if ((count + v->len) > v->plen)".(such as
> count=0xffffffffffffffff). Then it will lead to buffer overflow in
> "copy_from_user(v->pbuffer + v->len, buffer, count)".
> 
> Signed-off-by: Ning Qiang <sohu0106@126.com>
> ---

Thanks!

Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>

regards,
dan carpenter


  reply	other threads:[~2022-07-14 14:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-14 14:17 [PATCH] MIPS: vpe: fix integer overflow in vpe_write() Ning Qiang
2022-07-14 14:21 ` Dan Carpenter [this message]
2022-07-14 17:34 ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220714142145.GT2316@kadam \
    --to=dan.carpenter@oracle.com \
    --cc=greg@kroah.com \
    --cc=linux-mips@vger.kernel.org \
    --cc=security@kernel.org \
    --cc=sohu0106@126.com \
    --cc=tsbogend@alpha.franken.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).