From: Christoph Hellwig <hch@lst.de>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Christoph Hellwig <hch@lst.de>,
Nathan Chancellor <nathan@kernel.org>,
Naresh Kamboju <naresh.kamboju@linaro.org>,
"open list:BROADCOM NVRAM DRIVER" <linux-mips@vger.kernel.org>,
linux-arch <linux-arch@vger.kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
Palmer Dabbelt <palmer@rivosinc.com>, Guo Ren <guoren@kernel.org>
Subject: Re: [PATCH] tools: Fixed MIPS builds due to struct flock re-definition
Date: Tue, 19 Jul 2022 17:16:26 +0200 [thread overview]
Message-ID: <20220719151626.GA22030@lst.de> (raw)
In-Reply-To: <CAK8P3a3cuTknZaLZCFGwZtMfbd1qAFWEtXMcvVHsXoJn8EUCOg@mail.gmail.com>
On Tue, Jul 19, 2022 at 09:42:23AM +0200, Arnd Bergmann wrote:
> I think the correct fix to address the problem in both versions and
> get them back into sync would be something like the patch below.
> I have done zero testing on it though.
>
> Christoph and Florian, any other suggestions?
Fine with me. I still think these whole tools/ copy of headers are just
broken. Userspace code must use system headers and not try to include
two slightly out of sync versions of the same header in obsfucated ways.
next prev parent reply other threads:[~2022-07-19 15:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-15 18:55 [PATCH] tools: Fixed MIPS builds due to struct flock re-definition Florian Fainelli
2022-07-16 23:21 ` Florian Fainelli
2022-07-19 0:17 ` Florian Fainelli
2022-07-19 4:30 ` Christoph Hellwig
2022-07-19 7:42 ` Arnd Bergmann
2022-07-19 15:16 ` Christoph Hellwig [this message]
2022-07-19 19:05 ` Florian Fainelli
2022-07-19 21:15 ` Arnd Bergmann
2022-07-19 21:17 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220719151626.GA22030@lst.de \
--to=hch@lst.de \
--cc=arnd@arndb.de \
--cc=f.fainelli@gmail.com \
--cc=guoren@kernel.org \
--cc=heiko@sntech.de \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=naresh.kamboju@linaro.org \
--cc=nathan@kernel.org \
--cc=palmer@rivosinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).