From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Alexander A Sverdlin <alexander.sverdlin@nokia.com>
Cc: Yu Zhao <yuzhao@google.com>, Joe Perches <joe@perches.com>,
linux-mips@vger.kernel.org, Corey Minyard <cminyard@mvista.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] MIPS: octeon: Get rid of preprocessor directives around RESERVE32
Date: Wed, 7 Sep 2022 15:02:20 +0200 [thread overview]
Message-ID: <20220907130220.GA17817@alpha.franken.de> (raw)
In-Reply-To: <20220906083239.10163-1-alexander.sverdlin@nokia.com>
On Tue, Sep 06, 2022 at 10:32:39AM +0200, Alexander A Sverdlin wrote:
> From: Alexander Sverdlin <alexander.sverdlin@nokia.com>
>
> Some of them were pointless because CONFIG_CAVIUM_RESERVE32 is now always
> defined, some were not enough (Yu Zhao reported
> "Failed to allocate CAVIUM_RESERVE32 memory area" error).
>
> Removing the directives allows for compiler coverage of RESERVE32 code and
> replacing one of [always-true] "ifdef" with a compiler conditional fixes
> the [cosmetic] error message.
>
> Signed-off-by: Alexander Sverdlin <alexander.sverdlin@nokia.com>
> ---
>
> Changelog:
> v2:
> * Reduced the scope of addr variable
>
> arch/mips/cavium-octeon/executive/cvmx-cmd-queue.c | 4 ----
> arch/mips/cavium-octeon/setup.c | 27 +++++++++-------------
applied to mips-fixes with
Fixes: 3e3114ac460e ("MIPS: Introduce CAVIUM_RESERVE32 Kconfig option")
added.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
prev parent reply other threads:[~2022-09-07 13:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-06 8:32 [PATCH v2] MIPS: octeon: Get rid of preprocessor directives around RESERVE32 Alexander A Sverdlin
2022-09-07 13:02 ` Thomas Bogendoerfer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220907130220.GA17817@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=alexander.sverdlin@nokia.com \
--cc=cminyard@mvista.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).