From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47D03C6FA89 for ; Wed, 14 Sep 2022 09:15:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231334AbiINJPT (ORCPT ); Wed, 14 Sep 2022 05:15:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53200 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231749AbiINJOV (ORCPT ); Wed, 14 Sep 2022 05:14:21 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D1317CA8E; Wed, 14 Sep 2022 02:06:35 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 430E0B8171A; Wed, 14 Sep 2022 09:06:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E19D2C433C1; Wed, 14 Sep 2022 09:06:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663146384; bh=6lYdFxirT4HYnAa0vv4bxB7fWPhU3a5xMrQetIu6l9g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=P3VJ4fytdkoAr79g9z1U8t0VGer96oH2tzo9ugamvHY+GwiaFQ0/uxOkLDm+uqq5e /74KmW6UD8U+CT26C8TW/DgOXi0gMnTrfcDspsE8Ph6512MTCXpMW0YsAmc8zGVnFu ffPK7BHDwndW/duTpQkP5gZBHn9+XbBE+psXTZKI6BhRZhyTnJw+6OXq68HDcN6C0C YQ4lob+BJ7sTQKQaOxOWNKrqeQUbhKIEXfD3F6LcoVGNO2THzWSv5ypD3NbaH7mrVY fV7SZh5Fznw4LRVzUSXqh0heH6jkBL2pO2nZ+wX8qM2Cy0p9bb/SzDyMXN/cZ7cqjC X90yutqPqU93Q== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Liang He , Thomas Bogendoerfer , Sasha Levin , john@phrozen.org, xkernel.wang@foxmail.com, linux-mips@vger.kernel.org Subject: [PATCH AUTOSEL 4.9 10/13] mips: lantiq: xway: Fix refcount leak bug in sysctrl Date: Wed, 14 Sep 2022 05:05:37 -0400 Message-Id: <20220914090540.471725-10-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220914090540.471725-1-sashal@kernel.org> References: <20220914090540.471725-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org From: Liang He [ Upstream commit 76695592711ef1e215cc24ed3e1cd857d7fc3098 ] In ltq_soc_init(), of_find_compatible_node() will return a node pointer with refcount incremented. We should use of_node_put() when it is not used anymore. Signed-off-by: Liang He Signed-off-by: Thomas Bogendoerfer Signed-off-by: Sasha Levin --- arch/mips/lantiq/xway/sysctrl.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/arch/mips/lantiq/xway/sysctrl.c b/arch/mips/lantiq/xway/sysctrl.c index dd7c36a193e30..6891456a7603f 100644 --- a/arch/mips/lantiq/xway/sysctrl.c +++ b/arch/mips/lantiq/xway/sysctrl.c @@ -457,6 +457,10 @@ void __init ltq_soc_init(void) of_address_to_resource(np_ebu, 0, &res_ebu)) panic("Failed to get core resources"); + of_node_put(np_pmu); + of_node_put(np_cgu); + of_node_put(np_ebu); + if (!request_mem_region(res_pmu.start, resource_size(&res_pmu), res_pmu.name) || !request_mem_region(res_cgu.start, resource_size(&res_cgu), -- 2.35.1