From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72E44C433FE for ; Fri, 30 Sep 2022 21:25:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230450AbiI3VZ5 (ORCPT ); Fri, 30 Sep 2022 17:25:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58344 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232077AbiI3VZe (ORCPT ); Fri, 30 Sep 2022 17:25:34 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3B5369C2CA; Fri, 30 Sep 2022 14:25:33 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E77C8B82A3E; Fri, 30 Sep 2022 21:25:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7BA97C433C1; Fri, 30 Sep 2022 21:25:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664573130; bh=yYjZt83OjgtVPX4nAX1qCF2YXkuwqFpSV4m8Otl7M+I=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=rhvSwwe2L8xH2jxatogL3rHq+RJDvbREPwZiQ5Jo+Wdpbm8mhRXqjIAZXOF41EsZP 87Tft2xl8Q1g/kVmh/ttjUnkODguN4eVPbbpbbJVsX/GNXMjwP9m0fJ5P9VfT0gkhp kV2LdUR2OFGBDgnXT4hUxWIZLFYvIJXcawh5JYqD/NK05i2j7w2bRhGPav2fneUwRb askrwqcZZOUcdenJ1kwXFODuifoI7XwS67bJjoIOn4f2AjH7WD3W1eGh25ZXGyYE5J fJeh0C360lMkwCf8+x9XfLyc5tmWLkZ8ra6x4aWwPpse3yz3p+ptFrCONEVUu8BVm1 JjFyZ3+hAhfbA== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20220929225402.9696-4-Sergey.Semin@baikalelectronics.ru> References: <20220929225402.9696-1-Sergey.Semin@baikalelectronics.ru> <20220929225402.9696-4-Sergey.Semin@baikalelectronics.ru> Subject: Re: [PATCH RESEND v12 3/8] clk: baikal-t1: Add shared xGMAC ref/ptp clocks internal parent From: Stephen Boyd Cc: Serge Semin , Serge Semin , Alexey Malahov , Pavel Parkhomenko , Philipp Zabel , Krzysztof Kozlowski , Krzysztof Kozlowski , Thomas Bogendoerfer , linux-clk@vger.kernel.org, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org To: Michael Turquette , Serge Semin Date: Fri, 30 Sep 2022 14:25:27 -0700 User-Agent: alot/0.10 Message-Id: <20220930212530.7BA97C433C1@smtp.kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org Quoting Serge Semin (2022-09-29 15:53:57) > Baikal-T1 CCU reference manual says that both xGMAC reference and xGMAC > PTP clocks are generated by two different wrappers with the same constant > divider thus each producing a 156.25 MHz signal. But for some reason both > of these clock sources are gated by a single switch-flag in the CCU > registers space - CCU_SYS_XGMAC_BASE.BIT(0). In order to make the clocks > handled independently we need to define a shared parental gate so the base > clock signal would be switched off only if both of the child-clocks are > disabled. >=20 > Note the ID is intentionally set to -2 since we are going to add a one > more internal clock identifier in the next commit. >=20 > Fixes: 353afa3a8d2e ("clk: Add Baikal-T1 CCU Dividers driver") > Signed-off-by: Serge Semin >=20 > --- Applied to clk-next