* [PATCH v2] mips: alchemy: gpio: Include the right header
@ 2022-11-03 10:15 Linus Walleij
2022-11-11 15:04 ` Thomas Bogendoerfer
0 siblings, 1 reply; 2+ messages in thread
From: Linus Walleij @ 2022-11-03 10:15 UTC (permalink / raw)
To: Thomas Bogendoerfer
Cc: linux-mips, Linus Walleij, Bartosz Golaszewski, linux-gpio,
Philippe Mathieu-Daudé
The local GPIO driver in the MIPS Alchemy is including the legacy
<linux/gpio.h> header but what it wants is to implement a GPIO
driver so include <linux/gpio/driver.h> instead.
Cc: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: linux-gpio@vger.kernel.org
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
ChangeLog v1->v2:
- Collect Philippe's review tag
- Resend to the right MIPS maintainer
---
arch/mips/alchemy/common/gpiolib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips/alchemy/common/gpiolib.c b/arch/mips/alchemy/common/gpiolib.c
index a17d7a8909c4..1b16daaa86ae 100644
--- a/arch/mips/alchemy/common/gpiolib.c
+++ b/arch/mips/alchemy/common/gpiolib.c
@@ -31,7 +31,7 @@
#include <linux/init.h>
#include <linux/kernel.h>
#include <linux/types.h>
-#include <linux/gpio.h>
+#include <linux/gpio/driver.h>
#include <asm/mach-au1x00/gpio-au1000.h>
#include <asm/mach-au1x00/gpio-au1300.h>
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] mips: alchemy: gpio: Include the right header
2022-11-03 10:15 [PATCH v2] mips: alchemy: gpio: Include the right header Linus Walleij
@ 2022-11-11 15:04 ` Thomas Bogendoerfer
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Bogendoerfer @ 2022-11-11 15:04 UTC (permalink / raw)
To: Linus Walleij
Cc: linux-mips, Bartosz Golaszewski, linux-gpio,
Philippe Mathieu-Daudé
On Thu, Nov 03, 2022 at 11:15:35AM +0100, Linus Walleij wrote:
> The local GPIO driver in the MIPS Alchemy is including the legacy
> <linux/gpio.h> header but what it wants is to implement a GPIO
> driver so include <linux/gpio/driver.h> instead.
>
> Cc: Bartosz Golaszewski <brgl@bgdev.pl>
> Cc: linux-gpio@vger.kernel.org
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> ChangeLog v1->v2:
> - Collect Philippe's review tag
> - Resend to the right MIPS maintainer
> ---
> arch/mips/alchemy/common/gpiolib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/alchemy/common/gpiolib.c b/arch/mips/alchemy/common/gpiolib.c
> index a17d7a8909c4..1b16daaa86ae 100644
> --- a/arch/mips/alchemy/common/gpiolib.c
> +++ b/arch/mips/alchemy/common/gpiolib.c
> @@ -31,7 +31,7 @@
> #include <linux/init.h>
> #include <linux/kernel.h>
> #include <linux/types.h>
> -#include <linux/gpio.h>
> +#include <linux/gpio/driver.h>
> #include <asm/mach-au1x00/gpio-au1000.h>
> #include <asm/mach-au1x00/gpio-au1300.h>
>
> --
> 2.34.1
applied to mips-fixes.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-11 15:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-03 10:15 [PATCH v2] mips: alchemy: gpio: Include the right header Linus Walleij
2022-11-11 15:04 ` Thomas Bogendoerfer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).