linux-mips.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Zimmermann <tzimmermann@suse.de>
To: daniel@ffwll.ch, airlied@gmail.com, sam@ravnborg.org,
	javierm@redhat.com, mripard@kernel.org,
	maarten.lankhorst@linux.intel.com
Cc: "linux-hyperv@vger.kernel.orglinux-hyperv"@vger.kernel.org,
	linux-aspeed@lists.ozlabs.org, nouveau@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org,
	virtualization@lists.linux-foundation.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-samsung-soc@vger.kernel.org, amd-gfx@lists.freedesktop.org,
	linux-rockchip@lists.infradead.org,
	xen-devel@lists.xenproject.org, linux-sunxi@lists.linux.dev,
	linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org,
	etnaviv@lists.freedesktop.org,
	linux-mediatek@lists.infradead.org,
	spice-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org,
	linux-amlogic@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org,
	linux-renesas-soc@vger.kernel.org,
	freedreno@lists.freedesktop.org,
	Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH v3 16/23] drm/fb-helper: Call fb_sync in I/O functions
Date: Thu,  3 Nov 2022 16:14:39 +0100	[thread overview]
Message-ID: <20221103151446.2638-17-tzimmermann@suse.de> (raw)
In-Reply-To: <20221103151446.2638-1-tzimmermann@suse.de>

Call struct fb_ops.fb_sync in drm_fbdev_{read,write}() to mimic the
behavior of fbdev. Fbdev implementations of fb_read and fb_write in
struct fb_ops invoke fb_sync to synchronize with outstanding operations
before I/O. Doing the same in DRM implementations will allow us to use
them throughout DRM drivers.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
---
 drivers/gpu/drm/drm_fb_helper.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
index f6d22cc4cd876..379e0d2f67198 100644
--- a/drivers/gpu/drm/drm_fb_helper.c
+++ b/drivers/gpu/drm/drm_fb_helper.c
@@ -2246,6 +2246,9 @@ static ssize_t drm_fbdev_fb_read(struct fb_info *info, char __user *buf,
 	if (total_size - count < pos)
 		count = total_size - pos;
 
+	if (info->fbops->fb_sync)
+		info->fbops->fb_sync(info);
+
 	if (drm_fbdev_use_iomem(info))
 		ret = fb_read_screen_base(info, buf, count, pos);
 	else
@@ -2327,6 +2330,9 @@ static ssize_t drm_fbdev_fb_write(struct fb_info *info, const char __user *buf,
 		count = total_size - pos;
 	}
 
+	if (info->fbops->fb_sync)
+		info->fbops->fb_sync(info);
+
 	/*
 	 * Copy to framebuffer even if we already logged an error. Emulates
 	 * the behavior of the original fbdev implementation.
-- 
2.38.0


  parent reply	other threads:[~2022-11-03 15:15 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-03 15:14 [PATCH v3 00/23] drm/fb-helper: Untangle fbdev emulation and helpers Thomas Zimmermann
2022-11-03 15:14 ` [PATCH v3 01/23] drm/komeda: Don't set struct drm_driver.lastclose Thomas Zimmermann
2022-11-03 15:14 ` [PATCH v3 02/23] drm/mcde: " Thomas Zimmermann
2022-11-03 15:14 ` [PATCH v3 03/23] drm/vboxvideo: " Thomas Zimmermann
2022-11-03 15:14 ` [PATCH v3 04/23] drm/amdgpu: Don't set struct drm_driver.output_poll_changed Thomas Zimmermann
2022-11-03 15:14 ` [PATCH v3 05/23] drm/imx/dcss: " Thomas Zimmermann
2022-11-03 15:14 ` [PATCH v3 06/23] drm/ingenic: " Thomas Zimmermann
2022-11-03 15:14 ` [PATCH v3 07/23] drm/logicvc: " Thomas Zimmermann
2022-11-03 15:14 ` [PATCH v3 08/23] drm/rockchip: " Thomas Zimmermann
2022-11-03 15:14 ` [PATCH v3 09/23] drm/panel-ili9341: Include <linux/backlight.h> Thomas Zimmermann
2022-11-03 15:14 ` [PATCH v3 10/23] drm/tve200: Include <linux/of.h> Thomas Zimmermann
2022-11-03 15:14 ` [PATCH v3 11/23] drm/fb-helper: Cleanup include statements in header file Thomas Zimmermann
2022-11-03 15:14 ` [PATCH v3 12/23] drm/fb_helper: Rename field fbdev to info in struct drm_fb_helper Thomas Zimmermann
2022-11-03 15:14 ` [PATCH v3 13/23] drm/fb-helper: Rename drm_fb_helper_alloc_fbi() to use _info postfix Thomas Zimmermann
2022-11-03 15:14 ` [PATCH v3 14/23] drm/fb-helper: Rename drm_fb_helper_unregister_fbi() " Thomas Zimmermann
2022-11-03 15:14 ` [PATCH v3 15/23] drm/fb-helper: Disconnect damage worker from update logic Thomas Zimmermann
2022-11-03 15:14 ` Thomas Zimmermann [this message]
2022-11-03 15:14 ` [PATCH v3 17/23] drm/fb-helper: Perform all fbdev I/O with the same implementation Thomas Zimmermann
2022-11-03 15:14 ` [PATCH v3 18/23] drm/fb_helper: Minimize damage-helper overhead Thomas Zimmermann
2022-11-03 15:14 ` [PATCH v3 19/23] drm/fb-helper: Always initialize generic fbdev emulation Thomas Zimmermann
2022-11-03 15:14 ` [PATCH v3 20/23] drm/fb-helper: Set flag in struct drm_fb_helper for leaking physical addresses Thomas Zimmermann
2022-11-04 10:37   ` Javier Martinez Canillas
2022-11-03 15:14 ` [PATCH v3 21/23] drm/fb-helper: Move generic fbdev emulation into separate source file Thomas Zimmermann
2022-11-03 15:14 ` [PATCH v3 22/23] drm/fb-helper: Remove unnecessary include statements Thomas Zimmermann
2022-11-03 15:14 ` [PATCH v3 23/23] drm/fb-helper: Clarify use of last_close and output_poll_changed Thomas Zimmermann
2022-11-04 10:38   ` Javier Martinez Canillas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221103151446.2638-17-tzimmermann@suse.de \
    --to=tzimmermann@suse.de \
    --cc="linux-hyperv@vger.kernel.orglinux-hyperv"@vger.kernel.org \
    --cc=airlied@gmail.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=etnaviv@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=javierm@redhat.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=linux-tegra@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=nouveau@lists.freedesktop.org \
    --cc=sam@ravnborg.org \
    --cc=spice-devel@lists.freedesktop.org \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).