Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Cc: linux-mips@vger.kernel.org, john@phrozen.org,
	p.zabel@pengutronix.de, gregkh@linuxfoundation.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MIPS: ralink: mt7621: avoid to init common ralink reset controller
Date: Wed, 21 Dec 2022 14:06:39 +0100	[thread overview]
Message-ID: <20221221130639.GB6643@alpha.franken.de> (raw)
In-Reply-To: <20221217074806.3225150-1-sergio.paracuellos@gmail.com>

On Sat, Dec 17, 2022 at 08:48:06AM +0100, Sergio Paracuellos wrote:
> Commit 38a8553b0a22 ("clk: ralink: make system controller node a reset provider")
> make system controller a reset provider for mt7621 ralink SoCs. Ralink init code
> also tries to start previous common reset controller which at the end tries to
> find device tree node 'ralink,rt2880-reset'. mt7621 device tree file is not
> using at all this node anymore. Hence avoid to init this common reset controller
> for mt7621 ralink SoCs to avoid 'Failed to find reset controller node' boot
> error trace error.
> 
> Fixes: 64b2d6ffff86 ("staging: mt7621-dts: align resets with binding documentation")
> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
> ---
>  arch/mips/ralink/of.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/mips/ralink/of.c b/arch/mips/ralink/of.c
> index ea8072acf8d9..01c132bc33d5 100644
> --- a/arch/mips/ralink/of.c
> +++ b/arch/mips/ralink/of.c
> @@ -21,6 +21,7 @@
>  #include <asm/bootinfo.h>
>  #include <asm/addrspace.h>
>  #include <asm/prom.h>
> +#include <asm/mach-ralink/ralink_regs.h>
>  
>  #include "common.h"
>  
> @@ -81,7 +82,8 @@ static int __init plat_of_setup(void)
>  	__dt_register_buses(soc_info.compatible, "palmbus");
>  
>  	/* make sure that the reset controller is setup early */
> -	ralink_rst_init();
> +	if (ralink_soc != MT762X_SOC_MT7621AT)
> +		ralink_rst_init();
>  
>  	return 0;
>  }
> -- 
> 2.25.1

applied.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]

      reply	other threads:[~2022-12-21 13:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-17  7:48 [PATCH] MIPS: ralink: mt7621: avoid to init common ralink reset controller Sergio Paracuellos
2022-12-21 13:06 ` Thomas Bogendoerfer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221221130639.GB6643@alpha.franken.de \
    --to=tsbogend@alpha.franken.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=john@phrozen.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=sergio.paracuellos@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox