From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: xurui <xurui@kylinos.cn>
Cc: ralf@linux-mips.org, linux-mips@vger.kernel.org,
linux-kernel@vger.kernel.org, rdunlap@infradead.org
Subject: Re: [RFC] MIPS: Fix a compilation issue
Date: Fri, 27 Jan 2023 17:28:11 +0100 [thread overview]
Message-ID: <20230127162811.GC6090@alpha.franken.de> (raw)
In-Reply-To: <20230118085912.608758-1-xurui@kylinos.cn>
On Wed, Jan 18, 2023 at 04:59:12PM +0800, xurui wrote:
> arch/mips/include/asm/mach-rc32434/pci.h:377:
> cc1: error: result of ‘-117440512 << 16’ requires 44 bits to represent, but ‘int’ only has 32 bits [-Werror=shift-overflow=]
>
> I guss we don`t need a left shift here?
>
> Signed-off-by: xurui <xurui@kylinos.cn>
> ---
> arch/mips/include/asm/mach-rc32434/pci.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/include/asm/mach-rc32434/pci.h b/arch/mips/include/asm/mach-rc32434/pci.h
> index 9a6eefd12757..3eb767c8a4ee 100644
> --- a/arch/mips/include/asm/mach-rc32434/pci.h
> +++ b/arch/mips/include/asm/mach-rc32434/pci.h
> @@ -374,7 +374,7 @@ struct pci_msu {
> PCI_CFG04_STAT_SSE | \
> PCI_CFG04_STAT_PE)
>
> -#define KORINA_CNFG1 ((KORINA_STAT<<16)|KORINA_CMD)
> +#define KORINA_CNFG1 (KORINA_STAT | KORINA_CMD)
>
> #define KORINA_REVID 0
> #define KORINA_CLASS_CODE 0
> --
> 2.25.1
applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
next prev parent reply other threads:[~2023-01-27 16:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-18 8:59 [RFC] MIPS: Fix a compilation issue xurui
2023-01-27 16:28 ` Thomas Bogendoerfer [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-01-06 3:09 xurui
2023-01-06 23:37 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230127162811.GC6090@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=ralf@linux-mips.org \
--cc=rdunlap@infradead.org \
--cc=xurui@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).