Re: [PATCH v2.1 09/24] mips/cpu: Expose play_dead()'s prototype definition

Philippe Mathieu-Daudé
2023-03-02T10:55:15Z

On 1/3/23 19:16, Josh Poimboeuf wrote:

> The latest version of this patch triggered a new kbuild warning which is
> fixed by the below patch. If there are no objections I'll bundle it in
> with the rest of the set for merging.
>
> ---8<---
>
> Subject: [PATCH] mips/smp: Add CONFIG_SMP guard for raw_smp_processor_id()
> Content-type: text/plain
>
> Without CONFIG_SMP, raw_smp_processor_id() is not expected to be defined
> by the arch.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Link: https://lore.kernel.org/oe-kbuild-all/202302220755.HM8J8GOR-lkp@intel.com/
> Signed-off-by: Josh Poimboeuf <jpoimboe@kernel.org>
> ---
> arch/mips/include/asm/smp.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/mips/include/asm/smp.h b/arch/mips/include/asm/smp.h
> index 4eee29b7845c..cf992b8b1e46 100644
> --- a/arch/mips/include/asm/smp.h
> +++ b/arch/mips/include/asm/smp.h
> @@ -25,6 +25,7 @@ extern cpumask_t cpu_sibling_map[];
> extern cpumask_t cpu_core_map[];
> extern cpumask_t cpu_foreign_map[];
>
> +#ifdef CONFIG_SMP
> static inline int raw_smp_processor_id(void)
> {
> #if defined(__VDSO__)
> @@ -36,6 +37,7 @@ static inline int raw_smp_processor_id(void)
> #endif
> }
> #define raw_smp_processor_id raw_smp_processor_id
> +#endif
>
> /* Map from cpu id to sequential logical cpu number. This will only
> not be idempotent when cpus failed to come on-line. */

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>