From: <ye.xingchen@zte.com.cn>
To: <ulf.hansson@linaro.org>
Cc: <paul@crapouillou.net>, <linux-mips@vger.kernel.org>,
<linux-mmc@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: [PATCH] mmc: jz4740: Use dev_err_probe()
Date: Wed, 22 Mar 2023 17:07:01 +0800 (CST) [thread overview]
Message-ID: <202303221707010277273@zte.com.cn> (raw)
From: Ye Xingchen <ye.xingchen@zte.com.cn>
Replace the open-code with dev_err_probe() to simplify the code.
Signed-off-by: Ye Xingchen <ye.xingchen@zte.com.cn>
---
drivers/mmc/host/jz4740_mmc.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/mmc/host/jz4740_mmc.c b/drivers/mmc/host/jz4740_mmc.c
index 698450afa7bb..a6ad03b24add 100644
--- a/drivers/mmc/host/jz4740_mmc.c
+++ b/drivers/mmc/host/jz4740_mmc.c
@@ -232,10 +232,7 @@ static int jz4740_mmc_acquire_dma_channels(struct jz4740_mmc_host *host)
if (!IS_ERR(host->dma_tx))
return 0;
- if (PTR_ERR(host->dma_tx) != -ENODEV) {
- dev_err(dev, "Failed to get dma tx-rx channel\n");
- return PTR_ERR(host->dma_tx);
- }
+ return dev_err_probe(dev, PTR_ERR(host->dma_tx), "Failed to get dma tx-rx channel\n");
host->dma_tx = dma_request_chan(mmc_dev(host->mmc), "tx");
if (IS_ERR(host->dma_tx)) {
--
2.25.1
next reply other threads:[~2023-03-22 9:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-22 9:07 ye.xingchen [this message]
2023-03-22 9:18 ` [PATCH] mmc: jz4740: Use dev_err_probe() Sergei Shtylyov
2023-03-22 9:25 ` Paul Cercueil
2023-03-22 16:54 ` Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202303221707010277273@zte.com.cn \
--to=ye.xingchen@zte.com.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=paul@crapouillou.net \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox