Re: [PATCH v2 01/12] MIPS: Move declaration of bcache ops to cache.c

[Thomas Bogendoerfer <tsbogend@alpha.franken.de>]

On Tue, Mar 21, 2023 at 10:48:41AM +0000, Jiaxun Yang wrote:
> bcache is not tied to CPU's cache interface. Just move those
> declaration to cache.c so it can be avaialble to CPU with all
> cache types.
> 
> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
> ---
>  arch/mips/mm/c-r4k.c | 14 --------------
>  arch/mips/mm/cache.c | 17 +++++++++++++++++
>  2 files changed, 17 insertions(+), 14 deletions(-)
> 
> diff --git a/arch/mips/mm/c-r4k.c b/arch/mips/mm/c-r4k.c
> index a549fa98c2f4..fd660d5c5328 100644
> --- a/arch/mips/mm/c-r4k.c
> +++ b/arch/mips/mm/c-r4k.c
> @@ -110,20 +110,6 @@ static unsigned long dcache_size __read_mostly;
>  static unsigned long vcache_size __read_mostly;
>  static unsigned long scache_size __read_mostly;
>  
> -/*
> - * Dummy cache handling routines for machines without boardcaches
> - */
> -static void cache_noop(void) {}

/local/tbogendoerfer/korg/linux/arch/mips/mm/c-r4k.c: In function ‘r4k_blast_dcache_page_setup’:
/local/tbogendoerfer/korg/linux/arch/mips/mm/c-r4k.c:149:35: error: ‘cache_noop’ undeclared (first use in this function)
   r4k_blast_dcache_page = (void *)cache_noop;
                                   ^~~~~~~~~~

looks like you haven't compiled this for other board configs.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]