From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Dengcheng Zhu <dzhu@wavecomp.com>,
John Crispin <blogic@openwrt.org>,
Qais Yousef <Qais.Yousef@imgtec.com>,
"Steven J . Hill" <Steven.Hill@imgtec.com>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Yang Yingliang <yangyingliang@huawei.com>,
kernel test robot <lkp@intel.com>
Subject: [PATCH] MIPS: vpe-cmp: remove module owner pointer from struct class usage.
Date: Sun, 2 Apr 2023 11:05:45 +0200 [thread overview]
Message-ID: <2023040242-pursuable-frown-48d8@gregkh> (raw)
In commit 6e30a66433af ("driver core: class: remove struct module owner
out of struct class"), the module owner pointer was removed from struct
class, but this was missed for the mips vpe-cmp code due to lack of
build testing (and it being burried under a very unused config
settings.) Fix this up by removing the module pointer to resolve the
build error.
Note, there are other problems with the driver model usage in this file
(static struct device usage, empty device release function, etc.), so it
probably could use some good cleaning up, but odds are this driver
really isn't used so hopefully it will just be removed entirely someday
soon as part of the general "remove unused arches" cleanup that is
slowly happening.
Cc: Dengcheng Zhu <dzhu@wavecomp.com>
Cc: John Crispin <blogic@openwrt.org>
Cc: Qais Yousef <Qais.Yousef@imgtec.com>
Cc: Steven J. Hill <Steven.Hill@imgtec.com>
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: Yang Yingliang <yangyingliang@huawei.com>
Cc: linux-mips@vger.kernel.org
Reported-by: kernel test robot <lkp@intel.com>
Link: https://lore.kernel.org/oe-kbuild-all/202304020802.xbRTJKjW-lkp@intel.com/
Fixes: 6e30a66433af ("driver core: class: remove struct module owner out of struct class")
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
arch/mips/kernel/vpe-cmp.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/mips/kernel/vpe-cmp.c b/arch/mips/kernel/vpe-cmp.c
index 92140edb3ce3..4ef7f49a4c6d 100644
--- a/arch/mips/kernel/vpe-cmp.c
+++ b/arch/mips/kernel/vpe-cmp.c
@@ -79,7 +79,6 @@ static void vpe_device_release(struct device *cd)
static struct class vpe_class = {
.name = "vpe",
- .owner = THIS_MODULE,
.dev_release = vpe_device_release,
.dev_groups = vpe_groups,
};
--
2.40.0
next reply other threads:[~2023-04-02 9:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-02 9:05 Greg Kroah-Hartman [this message]
2023-04-03 15:58 ` [PATCH] MIPS: vpe-cmp: remove module owner pointer from struct class usage Thomas Bogendoerfer
2023-04-03 16:20 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023040242-pursuable-frown-48d8@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=Qais.Yousef@imgtec.com \
--cc=Steven.Hill@imgtec.com \
--cc=blogic@openwrt.org \
--cc=dzhu@wavecomp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=lkp@intel.com \
--cc=tsbogend@alpha.franken.de \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox