From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4777CC6FD1D for ; Fri, 7 Apr 2023 08:11:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239782AbjDGIL2 (ORCPT ); Fri, 7 Apr 2023 04:11:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51356 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239610AbjDGILM (ORCPT ); Fri, 7 Apr 2023 04:11:12 -0400 Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::223]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 69DEBA5DC; Fri, 7 Apr 2023 01:11:01 -0700 (PDT) Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id D70776000C; Fri, 7 Apr 2023 08:10:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1680855059; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=k62lE0Z84brwUbN0RTewMQPHSeeiOVUlnJEgkCzQsvo=; b=R9CLiy5G5LdE9BO36N204fuspyAxiiF7TmcabLrbwrQPeoEl5Pn0pcw2pa9LFURAj+yhqS Ku6ulo+yoPDqo0ywa6hZxIhfMa2hfrKY6oIoCe+v26HM6BlIqcgn8p8u0WJDFU+gYVyAOT iWOVTokLobBTMlDhc5L2oqSRq3pJIdqQ+s5IqSFwu1iEWL1rH1J0xX63ZpwsrUgxYtF5VC JMA7zniKULdwaW97f/g6p4Ec2AzETlg0EBYuF+OIU67+xs5aqnBUa8bo0FWsfGskdfArda sO7wxwa4nSLUU/oHmfv/0zUTbea+upPaTGkKYKQ1Sq0BSBr1Ah5yUIuIzPRbHA== Date: Fri, 7 Apr 2023 10:10:43 +0200 From: Miquel Raynal To: Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= Cc: Vignesh Raghavendra , Kyungmin Park , Naga Sureshkumar Relli , Tudor Ambarus , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Yang Yingliang , ye xingchen , Valentin Korenblit , Wang Weiyang , Pali =?UTF-8?B?Um9ow6Fy?= , Marek =?UTF-8?B?QmVow7pu?= , Han Xu , Harvey Hunt , Paul Cercueil , Martin Blumenstingl , Vladimir Zapolskiy , Geert Uytterhoeven , Dmitry Torokhov , Liang Yang , Neil Armstrong , Kevin Hilman , Christophe Leroy , Phil Edworthy , Matthias Brugger , Chuanhong Guo , Roger Quadros , Christophe JAILLET , Manivannan Sadhasivam , Heiko Stuebner , Krzysztof Kozlowski , Arnd Bergmann , Linus Walleij , Stephen Boyd , Miaoqian Lin , Maxime Coquelin , Alexandre Torgue , Christophe Kerello , Jack Wang , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Stefan Agner , Lucas Stach , Thierry Reding , Jonathan Hunter , Richard Weinberger , linux-mtd@lists.infradead.org, kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, Jerome Brunet , linux-amlogic@lists.infradead.org, AngeloGioacchino Del Regno , linux-mediatek@lists.infradead.org, linux-oxnas@groups.io, linux-arm-msm@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org Subject: Re: [PATCH 00/49] mtd: nand: Convert to platform remove callback returning void Message-ID: <20230407101043.299f5e22@xps-13> In-Reply-To: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> References: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org Hi Uwe, u.kleine-koenig@pengutronix.de wrote on Sat, 1 Apr 2023 18:18:49 +0200: > Hello, >=20 > this series adapts the platform drivers below drivers/mtd/nand to use the > .remove_new() callback. Compared to the traditional .remove() callback > .remove_new() returns no value. This is a good thing because the driver c= ore > doesn't (and cannot) cope for errors during remove. The only effect of a > non-zero return value in .remove() is that the driver core emits a warnin= g. The > device is removed anyhow and an early return from .remove() usually yield= s a > resource leak. >=20 > By changing the remove callback to return void driver authors cannot > reasonably assume any more that there is some kind of cleanup later. >=20 > As all drivers already return 0 in their .remove callback, they can be > converted trivially. I've looked at the different patches, they look good to me but as they are all trivial and exactly identical, would you mind sending this again all squashed in a single patch? A subsystem-wide conversion seems appropriate. In all cases I plan to take this for the next merge window. I've collected the tags received so far if you want: Acked-by: Nicolas Ferre # atmel Reviewed-by: Paul Cercueil # ingenic Reviewed-by: Philippe Mathieu-Daud=C3=A9 # ingenic Acked-by: Martin Blumenstingl # intel Reviewed-by: Martin Blumenstingl # mes= on Acked-by: Roger Quadros # omap Reviewed-by: Geert Uytterhoeven # renesas Reviewed-by: Heiko Stuebner # rockchip Acked-by: Jernej Skrabec # sunxi Acked-by: Thierry Reding # tegra BTW, thanks to all of you who reviewed and answered to this thread! This is highly appreciated.=20 Thanks, Miqu=C3=A8l