From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93D03C77B6F for ; Tue, 11 Apr 2023 08:22:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230378AbjDKIWt (ORCPT ); Tue, 11 Apr 2023 04:22:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57370 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230244AbjDKIWZ (ORCPT ); Tue, 11 Apr 2023 04:22:25 -0400 Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 41C004ECB; Tue, 11 Apr 2023 01:21:04 -0700 (PDT) Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 86501C000B; Tue, 11 Apr 2023 08:20:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1681201245; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5dxn4NJiE3B4l0ky6etbuCAHmNrCsdSn8aiPhVJqzK0=; b=ZsU8dYwTOc46TPHSbq5p16/9AQmMS/uUngPw/Ep3ffxRbxNAvDSBCBvcAy2pJthLsUo170 Rj2p9Mc9u19gW1370eOx7JvIAabcDATJDumAn+o4DLCQe7iYje0L16LYJobe4Ma8iY4S2M hVT2XlKE7FDCpaVqWTtgFMG9mm77zh0cU7Io21vdLB2MKPq3F4zr/E7ECZswWoUCh/54s9 LxOZOxezaGsD/cMwwjzDu8L5qQzOGwesAiCNFf9eRpldZFKNpdmxXMmy52npYKIeX+l3mz 4g3Xo/1Q9fGa3R74wYDYHo17n1DEYEktLz9cH0XxSNGHCrcLqbBdY32P+qBBmQ== Date: Tue, 11 Apr 2023 10:20:25 +0200 From: Miquel Raynal To: Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= Cc: Alexandre Belloni , Dmitry Torokhov , Lucas Stach , Vignesh Raghavendra , Linus Walleij , Miaoqian Lin , Stefan Agner , linux-mips@vger.kernel.org, Paul Cercueil , linux-tegra@vger.kernel.org, Liang Yang , Naga Sureshkumar Relli , Jernej Skrabec , linux-amlogic@lists.infradead.org, Chuanhong Guo , linux-stm32@st-md-mailman.stormreply.com, Heiko Stuebner , Marek =?UTF-8?B?QmVow7pu?= , Samuel Holland , Alexandre Torgue , Kevin Hilman , linux-mediatek@lists.infradead.org, Krzysztof Kozlowski , Christophe Leroy , Jonathan Hunter , linux-rockchip@lists.infradead.org, Tudor Ambarus , Geert Uytterhoeven , Yang Yingliang , Jack Wang , Jerome Brunet , linux-sunxi@lists.linux.dev, linux-arm-msm@vger.kernel.org, kernel@pengutronix.de, Arnd Bergmann , Manivannan Sadhasivam , Martin Blumenstingl , ye xingchen , Vladimir Zapolskiy , Roger Quadros , Wang Weiyang , Harvey Hunt , Christophe JAILLET , Matthias Brugger , Han Xu , Chen-Yu Tsai , linux-arm-kernel@lists.infradead.org, AngeloGioacchino Del Regno , Neil Armstrong , Christophe Kerello , Stephen Boyd , Valentin Korenblit , Nicolas Ferre , linux-renesas-soc@vger.kernel.org, Kyungmin Park , Thierry Reding , Maxime Coquelin , Richard Weinberger , linux-mtd@lists.infradead.org, linux-oxnas@groups.io, Pali =?UTF-8?B?Um9ow6Fy?= , Claudiu Beznea Subject: Re: [PATCH] mtd: nand: Convert to platform remove callback returning void Message-ID: <20230411102025.6b2fdc9e@xps-13> In-Reply-To: <20230408185332.d2g2ao4tdp6ltm4i@pengutronix.de> References: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> <20230407101043.299f5e22@xps-13> <20230408185332.d2g2ao4tdp6ltm4i@pengutronix.de> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org Hi Uwe, u.kleine-koenig@pengutronix.de wrote on Sat, 8 Apr 2023 20:53:32 +0200: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is (mostly) ignored > and this typically results in resource leaks. To improve here there is a > quest to make the remove callback return void. In the first step of this > quest all drivers are converted to .remove_new() which already returns > void. >=20 > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. >=20 > Acked-by: Nicolas Ferre > Reviewed-by: Paul Cercueil > Reviewed-by: Philippe Mathieu-Daud=C3=A9 > Acked-by: Martin Blumenstingl > Reviewed-by: Martin Blumenstingl > Acked-by: Roger Quadros > Reviewed-by: Geert Uytterhoeven > Reviewed-by: Heiko Stuebner > Acked-by: Jernej Skrabec > Acked-by: Thierry Reding > Signed-off-by: Uwe Kleine-K=C3=B6nig > --- >=20 > Hey Miquel, >=20 > On Fri, Apr 07, 2023 at 10:10:43AM +0200, Miquel Raynal wrote: > > I've looked at the different patches, they look good to me but as they > > are all trivial and exactly identical, would you mind sending this > > again all squashed in a single patch? A subsystem-wide conversion seems > > appropriate. In all cases I plan to take this for the next merge > > window. =20 >=20 > I slightly prefer them separately, because I like small patches and > because the Acks and Reviews only apply to the individual drivers. > But I don't mind seriously, so here comes the series squashed into one. For any non trivial change, I would definitely do that as well. The thing is, by collecting the tags with b4, you lost all the Acks and Reviews targets, while we could prevent this, see below. > While going through the changed, probably the s3c24xx driver (which > isn't exactly identical to the other changes) could benefit from an > additional change throwing out the early exit (which---I guess---cannot > be hit). Yes, I believe the 'info =3D=3D NULL' condition is useless, feel free to drop it in a second patch if you wish. > BTW, I constructed the lists of acks/reviews myself and found the same > set. However b4 wailed about each patch claiming: >=20 > =E2=9C=97 BADSIG: DKIM/infradead.org No idea what this means, any pointer? > And it didn't like you producing the tags, saying: >=20 > NOTE: some trailers ignored due to from/email mismatches: > ! Trailer: Acked-by: Roger Quadros > Msg From: Miquel Raynal > [...] Well, yes, I don't expect b4 to read plain english when I say "I collected them for you" ^^ But at least my list had a '# ' suffix for each of the Acked and Reviewed changes, which is now missing. I don't know how useful they actually are, but it seems to me that the information was lost between v1 and v2? Thanks, Miqu=C3=A8l