From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A53EC7EE24 for ; Tue, 9 May 2023 11:04:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235071AbjEILEY (ORCPT ); Tue, 9 May 2023 07:04:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53936 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235452AbjEILEA (ORCPT ); Tue, 9 May 2023 07:04:00 -0400 Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 18D99469D; Tue, 9 May 2023 04:03:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=JF1V+c3UL+N9ld1zX5rd8Mu0N4lob7gKoBwZz1mVIMw=; b=aql03NPFGAMO5Kl80coujejdq3 VXWbx83fXzAKkdlxYwSALK8eVIvquLc6Ikp1W0vcqSV2KZFsK0+H7qSrgqzM5hHqyQaI6c6dtK5Bo uua/mR63aSWOGyFaB0ob+GKwxTQPCDfzgAhA8c/Y3JJbxMLyT0F0HwllrurWg1mR1JDZsedVWxS9j FAK3tthBDoVdkkdMJDLY3MllM6CGIfUH146sLI/18R1vwH5QDSoPiTiUXSiyb2KYPpHMa/vs9cEhb BfS09qrwDutlOjjfAgyNrNhgddilyXlvHpPbGL7Qr4vOvio7lk2WWrZ7JrQu/SxY7BUXwYFCQ9zlK wcsdOk9g==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1pwL6v-0066iJ-0M; Tue, 09 May 2023 11:02:25 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 2422B300451; Tue, 9 May 2023 13:02:24 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 057BF201DB6CD; Tue, 9 May 2023 13:02:24 +0200 (CEST) Date: Tue, 9 May 2023 13:02:23 +0200 From: Peter Zijlstra To: Thomas Gleixner Cc: LKML , x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan , "Michael Kelley (LINUX)" Subject: Re: [patch v3 14/36] [patch V2 14/38] cpu/hotplug: Rework sparse_irq locking in bringup_cpu() Message-ID: <20230509110223.GY83892@hirez.programming.kicks-ass.net> References: <20230508181633.089804905@linutronix.de> <20230508185218.013044883@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230508185218.013044883@linutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Mon, May 08, 2023 at 09:43:49PM +0200, Thomas Gleixner wrote: > From: Thomas Gleixner > > There is no harm to hold sparse_irq lock until the upcoming CPU completes > in cpuhp_online_idle(). This allows to remove cpu_online() synchronization > from architecture code. Uuuuuhh.. damn. Can you at the very least ammend the comment near irq_lock_sparse() to mention these extra duties?