From: Conor Dooley <conor.dooley@microchip.com>
To: Jiaxun Yang <jiaxun.yang@flygoat.com>
Cc: Binbin Zhou <zhoubb.aaron@gmail.com>,
Conor Dooley <conor@kernel.org>,
Binbin Zhou <zhoubinbin@loongson.cn>,
Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
<linux-rtc@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>, <devicetree@vger.kernel.org>,
Huacai Chen <chenhuacai@loongson.cn>,
Huacai Chen <chenhuacai@kernel.org>,
Xuerui Wang <kernel@xen0n.name>, <loongarch@lists.linux.dev>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
"linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
Kelvin Cheung <keguang.zhang@gmail.com>,
zhao zhang <zhzhl555@gmail.com>, Yang Ling <gnaygnil@gmail.com>,
<loongson-kernel@lists.loongnix.cn>
Subject: Re: [PATCH V4 1/5] dt-bindings: rtc: Remove the LS2X from the trivial RTCs
Date: Fri, 26 May 2023 13:38:29 +0100 [thread overview]
Message-ID: <20230526-hardwired-flashbulb-de3ef456f9a0@wendy> (raw)
In-Reply-To: <1EAC8FA8-4125-4436-9EE1-13B61B5687AF@flygoat.com>
[-- Attachment #1: Type: text/plain, Size: 1110 bytes --]
On Fri, May 26, 2023 at 01:22:15PM +0100, Jiaxun Yang wrote:
>
>
> > 2023年5月26日 13:06，Conor Dooley <conor.dooley@microchip.com> 写道：
> Hi all,
>
> [...]
> My two cents here as Loongson64 maintainer.
>
> >
> >>> To maintain compatibility with the existing devicetrees, should the old
> >>> "loongson,ls2x-rtc" be kept in the driver?
> >>
> >> No, It seems that wildcards in compatible are not allowed."
> >> loongson,ls2x-rtc" itself was part of this patch series at one time,
> >> but apparently it is not the right way to describe these chips.
> >
> > Right, but it has been merged - you are deleting the driver that supports
> > it after all - which means that any dtb with the old compatible will
> > stop working.
> It is perfectly fine to break DTB compatibility for Loongson64 systems
> As they *only* use builtin dtb. Bootloader will only pass machine type information
> and kernel will choose one dtb from it’s dtbs pool.
Ah, that is good to know thanks! I think that should be mentioned in the
commit messages for the next revision.
Cheers,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-05-26 12:39 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-25 12:55 [PATCH V4 0/5] rtc: Add rtc driver for the Loongson family chips Binbin Zhou
2023-05-25 12:55 ` [PATCH V4 1/5] dt-bindings: rtc: Remove the LS2X from the trivial RTCs Binbin Zhou
2023-05-25 17:05 ` Conor Dooley
2023-05-26 1:37 ` Binbin Zhou
2023-05-26 12:06 ` Conor Dooley
2023-05-26 12:22 ` Jiaxun Yang
2023-05-26 12:38 ` Conor Dooley [this message]
2023-05-27 9:22 ` Binbin Zhou
2023-05-27 16:13 ` Jiaxun Yang
2023-05-27 16:23 ` Conor Dooley
2023-05-27 21:59 ` Jiaxun Yang
2023-05-27 22:22 ` Conor Dooley
2023-05-29 2:59 ` Keguang Zhang
2023-05-29 6:24 ` Conor Dooley
2023-05-29 8:31 ` Binbin Zhou
2023-05-29 22:20 ` Alexandre Belloni
2023-05-30 6:41 ` Binbin Zhou
2023-05-30 8:17 ` Krzysztof Kozlowski
2023-05-30 8:40 ` Alexandre Belloni
2023-05-30 9:13 ` Keguang Zhang
2023-05-30 9:22 ` Alexandre Belloni
2023-05-30 9:49 ` Keguang Zhang
2023-05-30 11:39 ` Binbin Zhou
2023-05-30 12:02 ` Alexandre Belloni
2023-05-25 12:55 ` [PATCH V4 2/5] rtc: Remove the Loongson-1 RTC driver Binbin Zhou
2023-05-30 8:08 ` Krzysztof Kozlowski
2023-05-30 8:39 ` Alexandre Belloni
2023-05-25 12:55 ` [PATCH V4 3/5] rtc: Add rtc driver for the Loongson family chips Binbin Zhou
2023-05-25 12:55 ` [PATCH V4 4/5] MIPS: Loongson64: DTS: Add RTC support to LS7A PCH Binbin Zhou
2023-05-25 12:55 ` [PATCH V4 5/5] MIPS: Loongson64: DTS: Add RTC support to Loongson-2K1000 Binbin Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230526-hardwired-flashbulb-de3ef456f9a0@wendy \
--to=conor.dooley@microchip.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=chenhuacai@kernel.org \
--cc=chenhuacai@loongson.cn \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gnaygnil@gmail.com \
--cc=jiaxun.yang@flygoat.com \
--cc=keguang.zhang@gmail.com \
--cc=kernel@xen0n.name \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=loongson-kernel@lists.loongnix.cn \
--cc=robh+dt@kernel.org \
--cc=tsbogend@alpha.franken.de \
--cc=zhoubb.aaron@gmail.com \
--cc=zhoubinbin@loongson.cn \
--cc=zhzhl555@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).