From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 683AEC87FF2 for ; Wed, 31 May 2023 13:51:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237191AbjEaNvP (ORCPT ); Wed, 31 May 2023 09:51:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60602 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237561AbjEaNuy (ORCPT ); Wed, 31 May 2023 09:50:54 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 27DB73A89; Wed, 31 May 2023 06:46:26 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 078B563B35; Wed, 31 May 2023 13:46:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 91826C433D2; Wed, 31 May 2023 13:46:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685540785; bh=Nf0sgHpLiHFr81n72nHj6LFAvUY7W1n5UsPyv7F0P9s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=p3iIMn5Qy2q7OVELGFiL7yeM9z+RNzKe2+vOg4R0bDoZkvA9izzEzhhkIuPQ6DiL4 a0A2DbJIF+YwE1IqPnqCLo3FPhSLD670Mj/ET0W/dmoOQNTsYhYqwNXpp8Eb8/8y4k kDKA9W6xcrYbELybw6UFVI7wR4zYbHXNAN2Xnc3gpWm/H7yQI+h2KPDODqg8ifCIx7 kVf6V6R34/5v55h8hwSP3Di2coGnTWJZ/t/SBX+6mWI9cAWogzMfIsfIvLNmzaci8a UPdudar1+kOeIeS0XuRYUpaz8PZoDngInT254bwn2RxigBnxR2Z3UcY5HYbpKcBI8Y dxAPbazGeA8oQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Liviu Dudau , Thomas Bogendoerfer , Sasha Levin , nathan@kernel.org, yury.norov@gmail.com, Jason@zx2c4.com, linux-mips@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 09/10] mips: Move initrd_start check after initrd address sanitisation. Date: Wed, 31 May 2023 09:46:05 -0400 Message-Id: <20230531134606.3385210-9-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230531134606.3385210-1-sashal@kernel.org> References: <20230531134606.3385210-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org From: Liviu Dudau [ Upstream commit 4897a898a216058dec55e5e5902534e6e224fcdf ] PAGE_OFFSET is technically a virtual address so when checking the value of initrd_start against it we should make sure that it has been sanitised from the values passed by the bootloader. Without this change, even with a bootloader that passes correct addresses for an initrd, we are failing to load it on MT7621 boards, for example. Signed-off-by: Liviu Dudau Signed-off-by: Thomas Bogendoerfer Signed-off-by: Sasha Levin --- arch/mips/kernel/setup.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/arch/mips/kernel/setup.c b/arch/mips/kernel/setup.c index abd7ee9e90ab0..d205d3875e2c2 100644 --- a/arch/mips/kernel/setup.c +++ b/arch/mips/kernel/setup.c @@ -257,10 +257,6 @@ static unsigned long __init init_initrd(void) pr_err("initrd start must be page aligned\n"); goto disable; } - if (initrd_start < PAGE_OFFSET) { - pr_err("initrd start < PAGE_OFFSET\n"); - goto disable; - } /* * Sanitize initrd addresses. For example firmware @@ -273,6 +269,11 @@ static unsigned long __init init_initrd(void) initrd_end = (unsigned long)__va(end); initrd_start = (unsigned long)__va(__pa(initrd_start)); + if (initrd_start < PAGE_OFFSET) { + pr_err("initrd start < PAGE_OFFSET\n"); + goto disable; + } + ROOT_DEV = Root_RAM0; return PFN_UP(end); disable: -- 2.39.2