From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83732C77B7E for ; Thu, 1 Jun 2023 15:40:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234611AbjFAPk1 (ORCPT ); Thu, 1 Jun 2023 11:40:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44832 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233756AbjFAPk0 (ORCPT ); Thu, 1 Jun 2023 11:40:26 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C5948F2 for ; Thu, 1 Jun 2023 08:40:25 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q4kPH-0006TI-0k; Thu, 01 Jun 2023 17:40:07 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1q4kPD-004Nxp-Bi; Thu, 01 Jun 2023 17:40:03 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1q4kPC-00ACbI-LP; Thu, 01 Jun 2023 17:40:02 +0200 Date: Thu, 1 Jun 2023 17:40:02 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Liviu Dudau , Mihail Atanassov , Brian Starkey , David Airlie , Daniel Vetter , Russell King , Joel Stanley , Sam Ravnborg , Boris Brezillon , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Andrzej Hajda , Neil Armstrong , Robert Foss , Tomi Valkeinen , Rahul T R , Jayshri Pawar , Liu Ying , Shawn Guo , Sascha Hauer , Minghao Chi , Mark Brown , Kuninori Morimoto , Lucas Stach , Inki Dae , Seung-Woo Kim , Kyungmin Park , Krzysztof Kozlowski , Jingoo Han , Stefan Agner , Alison Wang , Xinliang Liu , Tian Tao , Ville =?utf-8?B?U3lyasOkbMOk?= , Jani Nikula , Thomas Zimmermann , Danilo Krummrich , Laurent Pinchart , Javier Martinez Canillas , Laurentiu Palcu , Philipp Zabel , Paul Cercueil , Anitha Chrisanthus , Qiang Yu , Paul Kocialkowski , Linus Walleij , Chun-Kuang Hu , Matthias Brugger , Kevin Hilman , Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Akhil P Oommen , Ricardo Ribalda , Konrad Dybcio , Johan Hovold , Stephen Boyd , Marijn Suijten , Liu Shixin , Douglas Anderson , Miaoqian Lin , Kuogee Hsieh , Bjorn Andersson , Marek Vasut , Ben Skeggs , Karol Herbst , Lyude Paul , Tomi Valkeinen , Guo Zhengkui , Yuan Can , Arnd Bergmann , Liang He , Thierry Reding , Rob Herring , Kieran Bingham , Sandy Huang , Heiko =?utf-8?Q?St=C3=BCbner?= , Orson Zhai , Baolin Wang , Chunyan Zhang , Deepak R Varma , Alex Deucher , Alain Volmat , Yannick Fertre , Raphael Gallais-Pou , Philippe Cornu , Maxime Coquelin , Alexandre Torgue , Maxime Ripard , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Jonathan Hunter , Maxime Ripard , =?utf-8?B?TWHDrXJh?= Canal , Noralf =?utf-8?Q?Tr=C3=B8nnes?= , Jyri Sarha , Alexey Brodkin , Emma Anholt , Melissa Wen , Hyun Kwon , Michal Simek Cc: linux-aspeed@lists.ozlabs.org, nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, John Stultz , Alim Akhtar , Fabio Estevam , Sumit Semwal , Jerome Brunet , linux-samsung-soc@vger.kernel.org, lima@lists.freedesktop.org, Steven Price , linux-rockchip@lists.infradead.org, Xinwei Kong , Mali DP Maintainers , NXP Linux Team , Russell King , linux-sunxi@lists.linux.dev, Jonas Karlman , Martin Blumenstingl , linux-arm-msm@vger.kernel.org, etnaviv@lists.freedesktop.org, Christian Gmeiner , linux-mediatek@lists.infradead.org, linux-tegra@vger.kernel.org, linux-amlogic@lists.infradead.org, Sean Paul , linux-arm-kernel@lists.infradead.org, AngeloGioacchino Del Regno , Andrew Jeffery , linux-stm32@st-md-mailman.stormreply.com, linux-mips@vger.kernel.org, linux-renesas-soc@vger.kernel.org, kernel@pengutronix.de, Yongqin Liu , freedreno@lists.freedesktop.org Subject: Re: [PATCH 00/53] drm: Convert to platform remove callback returning void Message-ID: <20230601154002.uv2wfatpb7b45duz@pengutronix.de> References: <20230507162616.1368908-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="p66bggbd6asm576v" Content-Disposition: inline In-Reply-To: <20230507162616.1368908-1-u.kleine-koenig@pengutronix.de> X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mips@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org --p66bggbd6asm576v Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello, On Sun, May 07, 2023 at 06:25:23PM +0200, Uwe Kleine-K=F6nig wrote: > this patch series adapts the platform drivers below drivers/gpu/drm > to use the .remove_new() callback. Compared to the traditional .remove() > callback .remove_new() returns no value. This is a good thing because > the driver core doesn't (and cannot) cope for errors during remove. The > only effect of a non-zero return value in .remove() is that the driver > core emits a warning. The device is removed anyhow and an early return > from .remove() usually yields a resource leak. >=20 > By changing the remove callback to return void driver authors cannot > reasonably (but wrongly) assume any more that there happens some kind of > cleanup later. I wonder if someone would volunteer to add the whole series to drm-misc-next?! Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | https://www.pengutronix.de/ | --p66bggbd6asm576v Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmR4u9EACgkQj4D7WH0S /k6pCgf/XXR0G22HLU/MVuNu1ZT+KFwZti46/pOMarp24StchWjJqsvsoo9mc1tI G4w/Z5yO5q4ZeCXX57bi5xuQfR0XZz96r6ZCHkxaaSJDydbm70lJyg88BUtqKsPC 1CEZ6UQdvjhM5hXaVZzFYYydmOKvgs68jMs4AUC5auawB2lP6A8U1z7g5AxYSM7E elXaqEEcvsm7xBm5H4hMroNG15Gw0awdAZ3nKJnwCK3jlrf7OMaJD/nA1QK+2lpp pv2eI9/NwJf31WmpHLOCj8NYuTN/A4haICwhScmweXtsdFk2TnPHthGEk1+hTlC8 Xyf99cj8btKIWF+ICt7lNc4eo0D7ZQ== =Nl7B -----END PGP SIGNATURE----- --p66bggbd6asm576v--