From: "Vishal Moola (Oracle)" <vishal.moola@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Matthew Wilcox <willy@infradead.org>
Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org,
linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev,
linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org,
linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org,
linux-sh@vger.kernel.org, sparclinux@vger.kernel.org,
linux-um@lists.infradead.org, xen-devel@lists.xenproject.org,
kvm@vger.kernel.org, Hugh Dickins <hughd@google.com>,
"Vishal Moola (Oracle)" <vishal.moola@gmail.com>,
Mike Rapoport <rppt@kernel.org>
Subject: [PATCH mm-unstable v9 02/31] pgtable: create struct ptdesc
Date: Mon, 7 Aug 2023 16:04:44 -0700 [thread overview]
Message-ID: <20230807230513.102486-3-vishal.moola@gmail.com> (raw)
In-Reply-To: <20230807230513.102486-1-vishal.moola@gmail.com>
Currently, page table information is stored within struct page. As part
of simplifying struct page, create struct ptdesc for page table
information.
Signed-off-by: Vishal Moola (Oracle) <vishal.moola@gmail.com>
Acked-by: Mike Rapoport (IBM) <rppt@kernel.org>
---
include/linux/mm_types.h | 70 ++++++++++++++++++++++++++++++++++++++++
1 file changed, 70 insertions(+)
diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h
index 18c8c3d793b0..cb47438ae17f 100644
--- a/include/linux/mm_types.h
+++ b/include/linux/mm_types.h
@@ -397,6 +397,76 @@ FOLIO_MATCH(flags, _flags_2);
FOLIO_MATCH(compound_head, _head_2);
#undef FOLIO_MATCH
+/**
+ * struct ptdesc - Memory descriptor for page tables.
+ * @__page_flags: Same as page flags. Unused for page tables.
+ * @pt_rcu_head: For freeing page table pages.
+ * @pt_list: List of used page tables. Used for s390 and x86.
+ * @_pt_pad_1: Padding that aliases with page's compound head.
+ * @pmd_huge_pte: Protected by ptdesc->ptl, used for THPs.
+ * @__page_mapping: Aliases with page->mapping. Unused for page tables.
+ * @pt_mm: Used for x86 pgds.
+ * @pt_frag_refcount: For fragmented page table tracking. Powerpc and s390 only.
+ * @_pt_pad_2: Padding to ensure proper alignment.
+ * @ptl: Lock for the page table.
+ * @__page_type: Same as page->page_type. Unused for page tables.
+ * @_refcount: Same as page refcount. Used for s390 page tables.
+ * @pt_memcg_data: Memcg data. Tracked for page tables here.
+ *
+ * This struct overlays struct page for now. Do not modify without a good
+ * understanding of the issues.
+ */
+struct ptdesc {
+ unsigned long __page_flags;
+
+ union {
+ struct rcu_head pt_rcu_head;
+ struct list_head pt_list;
+ struct {
+ unsigned long _pt_pad_1;
+ pgtable_t pmd_huge_pte;
+ };
+ };
+ unsigned long __page_mapping;
+
+ union {
+ struct mm_struct *pt_mm;
+ atomic_t pt_frag_refcount;
+ };
+
+ union {
+ unsigned long _pt_pad_2;
+#if ALLOC_SPLIT_PTLOCKS
+ spinlock_t *ptl;
+#else
+ spinlock_t ptl;
+#endif
+ };
+ unsigned int __page_type;
+ atomic_t _refcount;
+#ifdef CONFIG_MEMCG
+ unsigned long pt_memcg_data;
+#endif
+};
+
+#define TABLE_MATCH(pg, pt) \
+ static_assert(offsetof(struct page, pg) == offsetof(struct ptdesc, pt))
+TABLE_MATCH(flags, __page_flags);
+TABLE_MATCH(compound_head, pt_list);
+TABLE_MATCH(compound_head, _pt_pad_1);
+TABLE_MATCH(pmd_huge_pte, pmd_huge_pte);
+TABLE_MATCH(mapping, __page_mapping);
+TABLE_MATCH(pt_mm, pt_mm);
+TABLE_MATCH(ptl, ptl);
+TABLE_MATCH(rcu_head, pt_rcu_head);
+TABLE_MATCH(page_type, __page_type);
+TABLE_MATCH(_refcount, _refcount);
+#ifdef CONFIG_MEMCG
+TABLE_MATCH(memcg_data, pt_memcg_data);
+#endif
+#undef TABLE_MATCH
+static_assert(sizeof(struct ptdesc) <= sizeof(struct page));
+
/*
* Used for sizing the vmemmap region on some architectures
*/
--
2.40.1
next prev parent reply other threads:[~2023-08-07 23:06 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-07 23:04 [PATCH mm-unstable v9 00/31] Split ptdesc from struct page Vishal Moola (Oracle)
2023-08-07 23:04 ` [PATCH mm-unstable v9 01/31] mm: Add PAGE_TYPE_OP folio functions Vishal Moola (Oracle)
2023-08-07 23:04 ` Vishal Moola (Oracle) [this message]
2023-08-07 23:04 ` [PATCH mm-unstable v9 03/31] mm: add utility functions for ptdesc Vishal Moola (Oracle)
2023-08-07 23:04 ` [PATCH mm-unstable v9 04/31] mm: Convert pmd_pgtable_page() callers to use pmd_ptdesc() Vishal Moola (Oracle)
2023-08-07 23:04 ` [PATCH mm-unstable v9 05/31] mm: Convert ptlock_alloc() to use ptdescs Vishal Moola (Oracle)
2023-08-07 23:04 ` [PATCH mm-unstable v9 06/31] mm: Convert ptlock_ptr() " Vishal Moola (Oracle)
2023-08-07 23:04 ` [PATCH mm-unstable v9 07/31] mm: Convert pmd_ptlock_init() " Vishal Moola (Oracle)
2023-08-07 23:04 ` [PATCH mm-unstable v9 08/31] mm: Convert ptlock_init() " Vishal Moola (Oracle)
2023-08-07 23:04 ` [PATCH mm-unstable v9 09/31] mm: Convert pmd_ptlock_free() " Vishal Moola (Oracle)
2023-08-07 23:04 ` [PATCH mm-unstable v9 10/31] mm: Convert ptlock_free() " Vishal Moola (Oracle)
2023-08-07 23:04 ` [PATCH mm-unstable v9 11/31] mm: Create ptdesc equivalents for pgtable_{pte,pmd}_page_{ctor,dtor} Vishal Moola (Oracle)
2023-08-07 23:04 ` [PATCH mm-unstable v9 12/31] powerpc: Convert various functions to use ptdescs Vishal Moola (Oracle)
2023-08-07 23:04 ` [PATCH mm-unstable v9 13/31] x86: " Vishal Moola (Oracle)
2023-08-07 23:04 ` [PATCH mm-unstable v9 14/31] s390: Convert various pgalloc " Vishal Moola (Oracle)
2023-10-12 7:25 ` Heiko Carstens
2023-10-13 21:03 ` Vishal Moola
2023-08-07 23:04 ` [PATCH mm-unstable v9 15/31] mm: remove page table members from struct page Vishal Moola (Oracle)
2023-08-07 23:04 ` [PATCH mm-unstable v9 16/31] pgalloc: Convert various functions to use ptdescs Vishal Moola (Oracle)
2023-08-07 23:04 ` [PATCH mm-unstable v9 17/31] arm: " Vishal Moola (Oracle)
2023-08-07 23:05 ` [PATCH mm-unstable v9 18/31] arm64: " Vishal Moola (Oracle)
2023-08-07 23:05 ` [PATCH mm-unstable v9 19/31] csky: Convert __pte_free_tlb() " Vishal Moola (Oracle)
2023-08-07 23:05 ` [PATCH mm-unstable v9 20/31] hexagon: " Vishal Moola (Oracle)
2023-08-07 23:05 ` [PATCH mm-unstable v9 21/31] loongarch: Convert various functions " Vishal Moola (Oracle)
2023-08-07 23:05 ` [PATCH mm-unstable v9 22/31] m68k: " Vishal Moola (Oracle)
2023-08-07 23:05 ` [PATCH mm-unstable v9 23/31] mips: " Vishal Moola (Oracle)
2023-08-07 23:05 ` [PATCH mm-unstable v9 24/31] nios2: Convert __pte_free_tlb() " Vishal Moola (Oracle)
2023-08-07 23:05 ` [PATCH mm-unstable v9 25/31] openrisc: " Vishal Moola (Oracle)
2023-08-07 23:05 ` [PATCH mm-unstable v9 26/31] riscv: Convert alloc_{pmd, pte}_late() " Vishal Moola (Oracle)
2023-08-07 23:05 ` [PATCH mm-unstable v9 27/31] sh: Convert pte_free_tlb() " Vishal Moola (Oracle)
2023-08-07 23:05 ` [PATCH mm-unstable v9 28/31] sparc64: Convert various functions " Vishal Moola (Oracle)
2023-08-07 23:05 ` [PATCH mm-unstable v9 29/31] sparc: Convert pgtable_pte_page_{ctor, dtor}() to ptdesc equivalents Vishal Moola (Oracle)
2023-08-07 23:05 ` [PATCH mm-unstable v9 30/31] um: Convert {pmd, pte}_free_tlb() to use ptdescs Vishal Moola (Oracle)
2023-08-07 23:05 ` [PATCH mm-unstable v9 31/31] mm: Remove pgtable_{pmd, pte}_page_{ctor, dtor}() wrappers Vishal Moola (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230807230513.102486-3-vishal.moola@gmail.com \
--to=vishal.moola@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-csky@vger.kernel.org \
--cc=linux-hexagon@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-openrisc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=loongarch@lists.linux.dev \
--cc=rppt@kernel.org \
--cc=sparclinux@vger.kernel.org \
--cc=willy@infradead.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).