* Re: [PATCH 2/3] irqchip: mips-gic: mark gic_irq_domain_free() static
2023-08-10 12:33 ` [PATCH 2/3] irqchip: mips-gic: mark gic_irq_domain_free() static Arnd Bergmann
@ 2023-08-10 14:52 ` Philippe Mathieu-Daudé
2023-08-13 14:26 ` Serge Semin
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2023-08-10 14:52 UTC (permalink / raw)
To: Arnd Bergmann, Thomas Gleixner, Marc Zyngier
Cc: Arnd Bergmann, Thomas Bogendoerfer, Serge Semin, Jiaxun Yang,
wangjianli, linux-mips, linux-kernel
On 10/8/23 14:33, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> This function is only used locally and should be static to avoid a warning:
>
> drivers/irqchip/irq-mips-gic.c:560:6: error: no previous prototype for 'gic_irq_domain_free' [-Werror=missing-prototypes]
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/irqchip/irq-mips-gic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2/3] irqchip: mips-gic: mark gic_irq_domain_free() static
2023-08-10 12:33 ` [PATCH 2/3] irqchip: mips-gic: mark gic_irq_domain_free() static Arnd Bergmann
2023-08-10 14:52 ` Philippe Mathieu-Daudé
@ 2023-08-13 14:26 ` Serge Semin
1 sibling, 0 replies; 3+ messages in thread
From: Serge Semin @ 2023-08-13 14:26 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Thomas Gleixner, Marc Zyngier, Arnd Bergmann, Thomas Bogendoerfer,
Jiaxun Yang, Philippe Mathieu-Daudé, wangjianli, linux-mips,
linux-kernel
On Thu, Aug 10, 2023 at 02:33:55PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> This function is only used locally and should be static to avoid a warning:
>
> drivers/irqchip/irq-mips-gic.c:560:6: error: no previous prototype for 'gic_irq_domain_free' [-Werror=missing-prototypes]
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/irqchip/irq-mips-gic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/irqchip/irq-mips-gic.c b/drivers/irqchip/irq-mips-gic.c
> index 6d5ecc10a8703..76253e864f230 100644
> --- a/drivers/irqchip/irq-mips-gic.c
> +++ b/drivers/irqchip/irq-mips-gic.c
> @@ -557,7 +557,7 @@ static int gic_irq_domain_alloc(struct irq_domain *d, unsigned int virq,
> return gic_irq_domain_map(d, virq, hwirq);
> }
>
> -void gic_irq_domain_free(struct irq_domain *d, unsigned int virq,
> +static void gic_irq_domain_free(struct irq_domain *d, unsigned int virq,
> unsigned int nr_irqs)
Right. Thanks! Note the descendant line should be aligned to the
function open parenthesis to preserve the coding style well
utilized in the driver. With that fixed feel free to add:
Reviewed-by: Serge Semin <fancer.lancer@gmail.com>
-Serge(y)
> {
> }
> --
> 2.39.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread