* [PATCH] dt-bindings: mips: loongson: Add LS1B demo board
@ 2023-08-25 12:41 Keguang Zhang
2023-08-25 12:45 ` Krzysztof Kozlowski
0 siblings, 1 reply; 5+ messages in thread
From: Keguang Zhang @ 2023-08-25 12:41 UTC (permalink / raw)
To: linux-mips, devicetree, linux-kernel
Cc: Thomas Bogendoerfer, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Keguang Zhang
Add compatible for LS1B demo board.
Signed-off-by: Keguang Zhang <keguang.zhang@gmail.com>
---
Documentation/devicetree/bindings/mips/loongson/devices.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/mips/loongson/devices.yaml b/Documentation/devicetree/bindings/mips/loongson/devices.yaml
index 099e40e1482d..8736eb9fe224 100644
--- a/Documentation/devicetree/bindings/mips/loongson/devices.yaml
+++ b/Documentation/devicetree/bindings/mips/loongson/devices.yaml
@@ -40,6 +40,7 @@ properties:
- description: LS1B based boards
items:
- enum:
+ - loongson,ls1b-demo
- loongson,lsgz-1b-dev
- const: loongson,ls1b
base-commit: f11a9967413281b49690d864795e7c5f8f8e4fda
--
2.39.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] dt-bindings: mips: loongson: Add LS1B demo board
2023-08-25 12:41 [PATCH] dt-bindings: mips: loongson: Add LS1B demo board Keguang Zhang
@ 2023-08-25 12:45 ` Krzysztof Kozlowski
2023-08-25 14:39 ` Keguang Zhang
2023-08-28 15:09 ` Rob Herring
0 siblings, 2 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2023-08-25 12:45 UTC (permalink / raw)
To: Keguang Zhang, linux-mips, devicetree, linux-kernel
Cc: Thomas Bogendoerfer, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
On 25/08/2023 14:41, Keguang Zhang wrote:
> Add compatible for LS1B demo board.
Where is the user of this binding? We do not add bindings without users.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: mips: loongson: Add LS1B demo board
2023-08-25 12:45 ` Krzysztof Kozlowski
@ 2023-08-25 14:39 ` Keguang Zhang
2023-08-28 15:09 ` Rob Herring
1 sibling, 0 replies; 5+ messages in thread
From: Keguang Zhang @ 2023-08-25 14:39 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: linux-mips, devicetree, linux-kernel, Thomas Bogendoerfer,
Rob Herring, Krzysztof Kozlowski, Conor Dooley
On Fri, Aug 25, 2023 at 8:45 PM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 25/08/2023 14:41, Keguang Zhang wrote:
> > Add compatible for LS1B demo board.
>
> Where is the user of this binding? We do not add bindings without users.
>
OK. I'll put this patch and the DTS into one patch set later.
>
> Best regards,
> Krzysztof
>
--
Best regards,
Keguang Zhang
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: mips: loongson: Add LS1B demo board
2023-08-25 12:45 ` Krzysztof Kozlowski
2023-08-25 14:39 ` Keguang Zhang
@ 2023-08-28 15:09 ` Rob Herring
2023-08-28 17:01 ` Krzysztof Kozlowski
1 sibling, 1 reply; 5+ messages in thread
From: Rob Herring @ 2023-08-28 15:09 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Keguang Zhang, linux-mips, devicetree, linux-kernel,
Thomas Bogendoerfer, Krzysztof Kozlowski, Conor Dooley
On Fri, Aug 25, 2023 at 02:45:41PM +0200, Krzysztof Kozlowski wrote:
> On 25/08/2023 14:41, Keguang Zhang wrote:
> > Add compatible for LS1B demo board.
>
> Where is the user of this binding? We do not add bindings without users.
Maybe board compatibles should be an exception? They are rarely/never
used by the kernel so the only user will be a board dts. I'm not sure we
care about having every board upstream.
Rob
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: mips: loongson: Add LS1B demo board
2023-08-28 15:09 ` Rob Herring
@ 2023-08-28 17:01 ` Krzysztof Kozlowski
0 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2023-08-28 17:01 UTC (permalink / raw)
To: Rob Herring
Cc: Keguang Zhang, linux-mips, devicetree, linux-kernel,
Thomas Bogendoerfer, Krzysztof Kozlowski, Conor Dooley
On 28/08/2023 17:09, Rob Herring wrote:
> On Fri, Aug 25, 2023 at 02:45:41PM +0200, Krzysztof Kozlowski wrote:
>> On 25/08/2023 14:41, Keguang Zhang wrote:
>>> Add compatible for LS1B demo board.
>>
>> Where is the user of this binding? We do not add bindings without users.
>
> Maybe board compatibles should be an exception? They are rarely/never
> used by the kernel so the only user will be a board dts. I'm not sure we
> care about having every board upstream.
If someone keeps DTS out of the kernel, then they could keep the binding
patch there as well.
Boards upstream are the same useful as some drivers - allow others to
play with it and investigate.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-08-28 17:02 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-25 12:41 [PATCH] dt-bindings: mips: loongson: Add LS1B demo board Keguang Zhang
2023-08-25 12:45 ` Krzysztof Kozlowski
2023-08-25 14:39 ` Keguang Zhang
2023-08-28 15:09 ` Rob Herring
2023-08-28 17:01 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).