* [PATCH v2 05/17] pmdomain: bcm: Move Kconfig options to the pmdomain subsystem [not found] <20230915092003.658361-1-ulf.hansson@linaro.org> @ 2023-09-15 9:19 ` Ulf Hansson 2023-09-15 13:15 ` Philippe Mathieu-Daudé 2023-09-15 16:30 ` Florian Fainelli 0 siblings, 2 replies; 3+ messages in thread From: Ulf Hansson @ 2023-09-15 9:19 UTC (permalink / raw) To: Arnd Bergmann, Olof Johansson Cc: Ulf Hansson, linux-pm, linux-arm-kernel, linux-kernel, Florian Fainelli, Ray Jui, Scott Branden, linux-mips, linux-rpi-kernel The Kconfig options belongs closer to the corresponding implementations, hence let's move them from the soc subsystem to the pmdomain subsystem. Cc: Florian Fainelli <florian.fainelli@broadcom.com> Cc: Ray Jui <rjui@broadcom.com> Cc: Scott Branden <sbranden@broadcom.com> Cc: <linux-mips@vger.kernel.org> Cc: <linux-rpi-kernel@lists.infradead.org> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> --- drivers/pmdomain/Kconfig | 1 + drivers/pmdomain/bcm/Kconfig | 46 ++++++++++++++++++++++++++++++++++++ drivers/soc/bcm/Kconfig | 42 -------------------------------- 3 files changed, 47 insertions(+), 42 deletions(-) create mode 100644 drivers/pmdomain/bcm/Kconfig diff --git a/drivers/pmdomain/Kconfig b/drivers/pmdomain/Kconfig index 482d9e970e14..ddc05d6af100 100644 --- a/drivers/pmdomain/Kconfig +++ b/drivers/pmdomain/Kconfig @@ -4,5 +4,6 @@ menu "PM Domains" source "drivers/pmdomain/actions/Kconfig" source "drivers/pmdomain/amlogic/Kconfig" source "drivers/pmdomain/apple/Kconfig" +source "drivers/pmdomain/bcm/Kconfig" endmenu diff --git a/drivers/pmdomain/bcm/Kconfig b/drivers/pmdomain/bcm/Kconfig new file mode 100644 index 000000000000..9311e90b7707 --- /dev/null +++ b/drivers/pmdomain/bcm/Kconfig @@ -0,0 +1,46 @@ +# SPDX-License-Identifier: GPL-2.0-only +menu "Broadcom PM Domains" + +config BCM2835_POWER + bool "BCM2835 power domain driver" + depends on ARCH_BCM2835 || (COMPILE_TEST && OF) + default y if ARCH_BCM2835 + select PM_GENERIC_DOMAINS if PM + select RESET_CONTROLLER + help + This enables support for the BCM2835 power domains and reset + controller. Any usage of power domains by the Raspberry Pi + firmware means that Linux usage of the same power domain + must be accessed using the RASPBERRYPI_POWER driver + +config RASPBERRYPI_POWER + bool "Raspberry Pi power domain driver" + depends on ARCH_BCM2835 || (COMPILE_TEST && OF) + depends on RASPBERRYPI_FIRMWARE=y + select PM_GENERIC_DOMAINS if PM + help + This enables support for the RPi power domains which can be enabled + or disabled via the RPi firmware. + +config BCM_PMB + bool "Broadcom PMB (Power Management Bus) driver" + depends on ARCH_BCMBCA || (COMPILE_TEST && OF) + default ARCH_BCMBCA + select PM_GENERIC_DOMAINS if PM + help + This enables support for the Broadcom's PMB (Power Management Bus) that + is used for disabling and enabling SoC devices. + +if SOC_BCM63XX + +config BCM63XX_POWER + bool "BCM63xx power domain driver" + depends on BMIPS_GENERIC || (COMPILE_TEST && OF) + select PM_GENERIC_DOMAINS if PM + help + This enables support for the BCM63xx power domains controller on + BCM6318, BCM6328, BCM6362 and BCM63268 SoCs. + +endif # SOC_BCM63XX + +endmenu diff --git a/drivers/soc/bcm/Kconfig b/drivers/soc/bcm/Kconfig index f96906795fa6..406617aa3056 100644 --- a/drivers/soc/bcm/Kconfig +++ b/drivers/soc/bcm/Kconfig @@ -1,27 +1,6 @@ # SPDX-License-Identifier: GPL-2.0-only menu "Broadcom SoC drivers" -config BCM2835_POWER - bool "BCM2835 power domain driver" - depends on ARCH_BCM2835 || (COMPILE_TEST && OF) - default y if ARCH_BCM2835 - select PM_GENERIC_DOMAINS if PM - select RESET_CONTROLLER - help - This enables support for the BCM2835 power domains and reset - controller. Any usage of power domains by the Raspberry Pi - firmware means that Linux usage of the same power domain - must be accessed using the RASPBERRYPI_POWER driver - -config RASPBERRYPI_POWER - bool "Raspberry Pi power domain driver" - depends on ARCH_BCM2835 || (COMPILE_TEST && OF) - depends on RASPBERRYPI_FIRMWARE=y - select PM_GENERIC_DOMAINS if PM - help - This enables support for the RPi power domains which can be enabled - or disabled via the RPi firmware. - config SOC_BCM63XX bool "Broadcom 63xx SoC drivers" depends on BMIPS_GENERIC || COMPILE_TEST @@ -42,27 +21,6 @@ config SOC_BRCMSTB If unsure, say N. -config BCM_PMB - bool "Broadcom PMB (Power Management Bus) driver" - depends on ARCH_BCMBCA || (COMPILE_TEST && OF) - default ARCH_BCMBCA - select PM_GENERIC_DOMAINS if PM - help - This enables support for the Broadcom's PMB (Power Management Bus) that - is used for disabling and enabling SoC devices. - -if SOC_BCM63XX - -config BCM63XX_POWER - bool "BCM63xx power domain driver" - depends on BMIPS_GENERIC || (COMPILE_TEST && OF) - select PM_GENERIC_DOMAINS if PM - help - This enables support for the BCM63xx power domains controller on - BCM6318, BCM6328, BCM6362 and BCM63268 SoCs. - -endif # SOC_BCM63XX - source "drivers/soc/bcm/brcmstb/Kconfig" endmenu -- 2.34.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2 05/17] pmdomain: bcm: Move Kconfig options to the pmdomain subsystem 2023-09-15 9:19 ` [PATCH v2 05/17] pmdomain: bcm: Move Kconfig options to the pmdomain subsystem Ulf Hansson @ 2023-09-15 13:15 ` Philippe Mathieu-Daudé 2023-09-15 16:30 ` Florian Fainelli 1 sibling, 0 replies; 3+ messages in thread From: Philippe Mathieu-Daudé @ 2023-09-15 13:15 UTC (permalink / raw) To: Ulf Hansson, Arnd Bergmann, Olof Johansson Cc: linux-pm, linux-arm-kernel, linux-kernel, Florian Fainelli, Ray Jui, Scott Branden, linux-mips, linux-rpi-kernel On 15/9/23 11:19, Ulf Hansson wrote: > The Kconfig options belongs closer to the corresponding implementations, > hence let's move them from the soc subsystem to the pmdomain subsystem. > > Cc: Florian Fainelli <florian.fainelli@broadcom.com> > Cc: Ray Jui <rjui@broadcom.com> > Cc: Scott Branden <sbranden@broadcom.com> > Cc: <linux-mips@vger.kernel.org> > Cc: <linux-rpi-kernel@lists.infradead.org> > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> > --- > drivers/pmdomain/Kconfig | 1 + > drivers/pmdomain/bcm/Kconfig | 46 ++++++++++++++++++++++++++++++++++++ > drivers/soc/bcm/Kconfig | 42 -------------------------------- > 3 files changed, 47 insertions(+), 42 deletions(-) > create mode 100644 drivers/pmdomain/bcm/Kconfig Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2 05/17] pmdomain: bcm: Move Kconfig options to the pmdomain subsystem 2023-09-15 9:19 ` [PATCH v2 05/17] pmdomain: bcm: Move Kconfig options to the pmdomain subsystem Ulf Hansson 2023-09-15 13:15 ` Philippe Mathieu-Daudé @ 2023-09-15 16:30 ` Florian Fainelli 1 sibling, 0 replies; 3+ messages in thread From: Florian Fainelli @ 2023-09-15 16:30 UTC (permalink / raw) To: Ulf Hansson, Arnd Bergmann, Olof Johansson Cc: linux-pm, linux-arm-kernel, linux-kernel, Ray Jui, Scott Branden, linux-mips, linux-rpi-kernel [-- Attachment #1: Type: text/plain, Size: 3143 bytes --] On 9/15/23 02:19, Ulf Hansson wrote: > The Kconfig options belongs closer to the corresponding implementations, > hence let's move them from the soc subsystem to the pmdomain subsystem. > > Cc: Florian Fainelli <florian.fainelli@broadcom.com> > Cc: Ray Jui <rjui@broadcom.com> > Cc: Scott Branden <sbranden@broadcom.com> > Cc: <linux-mips@vger.kernel.org> > Cc: <linux-rpi-kernel@lists.infradead.org> > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> > --- > drivers/pmdomain/Kconfig | 1 + > drivers/pmdomain/bcm/Kconfig | 46 ++++++++++++++++++++++++++++++++++++ > drivers/soc/bcm/Kconfig | 42 -------------------------------- > 3 files changed, 47 insertions(+), 42 deletions(-) > create mode 100644 drivers/pmdomain/bcm/Kconfig > > diff --git a/drivers/pmdomain/Kconfig b/drivers/pmdomain/Kconfig > index 482d9e970e14..ddc05d6af100 100644 > --- a/drivers/pmdomain/Kconfig > +++ b/drivers/pmdomain/Kconfig > @@ -4,5 +4,6 @@ menu "PM Domains" > source "drivers/pmdomain/actions/Kconfig" > source "drivers/pmdomain/amlogic/Kconfig" > source "drivers/pmdomain/apple/Kconfig" > +source "drivers/pmdomain/bcm/Kconfig" > > endmenu > diff --git a/drivers/pmdomain/bcm/Kconfig b/drivers/pmdomain/bcm/Kconfig > new file mode 100644 > index 000000000000..9311e90b7707 > --- /dev/null > +++ b/drivers/pmdomain/bcm/Kconfig > @@ -0,0 +1,46 @@ > +# SPDX-License-Identifier: GPL-2.0-only > +menu "Broadcom PM Domains" > + > +config BCM2835_POWER > + bool "BCM2835 power domain driver" > + depends on ARCH_BCM2835 || (COMPILE_TEST && OF) > + default y if ARCH_BCM2835 > + select PM_GENERIC_DOMAINS if PM > + select RESET_CONTROLLER > + help > + This enables support for the BCM2835 power domains and reset > + controller. Any usage of power domains by the Raspberry Pi > + firmware means that Linux usage of the same power domain > + must be accessed using the RASPBERRYPI_POWER driver > + > +config RASPBERRYPI_POWER > + bool "Raspberry Pi power domain driver" > + depends on ARCH_BCM2835 || (COMPILE_TEST && OF) > + depends on RASPBERRYPI_FIRMWARE=y > + select PM_GENERIC_DOMAINS if PM > + help > + This enables support for the RPi power domains which can be enabled > + or disabled via the RPi firmware. > + > +config BCM_PMB > + bool "Broadcom PMB (Power Management Bus) driver" > + depends on ARCH_BCMBCA || (COMPILE_TEST && OF) > + default ARCH_BCMBCA > + select PM_GENERIC_DOMAINS if PM > + help > + This enables support for the Broadcom's PMB (Power Management Bus) that > + is used for disabling and enabling SoC devices. > + > +if SOC_BCM63XX > + > +config BCM63XX_POWER > + bool "BCM63xx power domain driver" > + depends on BMIPS_GENERIC || (COMPILE_TEST && OF) > + select PM_GENERIC_DOMAINS if PM > + help > + This enables support for the BCM63xx power domains controller on > + BCM6318, BCM6328, BCM6362 and BCM63268 SoCs. > + > +endif # SOC_BCM63XX That is confusing, SOC_BCM63XX remains defined in drivers/soc/bcm/Kconfig, but we now made BCM63XX_POWER's visibility conditional upon a Kconfig symbol defined elsewhere, I would just drop the "if" condition completely. -- Florian [-- Attachment #2: S/MIME Cryptographic Signature --] [-- Type: application/pkcs7-signature, Size: 4221 bytes --] ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-09-15 16:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20230915092003.658361-1-ulf.hansson@linaro.org>
2023-09-15 9:19 ` [PATCH v2 05/17] pmdomain: bcm: Move Kconfig options to the pmdomain subsystem Ulf Hansson
2023-09-15 13:15 ` Philippe Mathieu-Daudé
2023-09-15 16:30 ` Florian Fainelli
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).