From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Vinod Koul <vkoul@kernel.org>
Cc: "Olivier Dautricourt" <olivierdautricourt@gmail.com>,
"Stefan Roese" <sr@denx.de>,
dmaengine@vger.kernel.org, kernel@pengutronix.de,
"Hector Martin" <marcan@marcan.st>,
"Sven Peter" <sven@svenpeter.dev>,
"Alyssa Rosenzweig" <alyssa@rosenzweig.io>,
asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
"Ludovic Desroches" <ludovic.desroches@microchip.com>,
"Tudor Ambarus" <tudor.ambarus@linaro.org>,
"Florian Fainelli" <florian.fainelli@broadcom.com>,
"Broadcom internal kernel review list"
<bcm-kernel-feedback-list@broadcom.com>,
"Ray Jui" <rjui@broadcom.com>,
"Scott Branden" <sbranden@broadcom.com>,
linux-rpi-kernel@lists.infradead.org,
"Rob Herring" <robh@kernel.org>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Paul Cercueil" <paul@crapouillou.net>,
linux-mips@vger.kernel.org,
"Eugeniy Paltsev" <Eugeniy.Paltsev@synopsys.com>,
"Viresh Kumar" <vireshk@kernel.org>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Li Yang" <leoyang.li@nxp.com>, "Zhang Wei" <zw@zh-kernel.org>,
linuxppc-dev@lists.ozlabs.org, "Shawn Guo" <shawnguo@kernel.org>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Fabio Estevam" <festevam@gmail.com>,
"NXP Linux Team" <linux-imx@nxp.com>,
"Sean Wang" <sean.wang@mediatek.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
linux-mediatek@lists.infradead.org,
"Andreas Färber" <afaerber@suse.de>,
"Manivannan Sadhasivam" <mani@kernel.org>,
linux-actions@lists.infradead.org,
"ye xingchen" <ye.xingchen@zte.com.cn>,
"Daniel Mack" <daniel@zonque.org>,
"Haojian Zhuang" <haojian.zhuang@gmail.com>,
"Robert Jarzmik" <robert.jarzmik@free.fr>,
"Andy Gross" <agross@kernel.org>,
"Bjorn Andersson" <andersson@kernel.org>,
"Konrad Dybcio" <konrad.dybcio@linaro.org>,
linux-arm-msm@vger.kernel.org, "Sinan Kaya" <okaya@kernel.org>,
"Green Wan" <green.wan@sifive.com>,
"Kees Cook" <keescook@chromium.org>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
"Biju Das" <biju.das.jz@bp.renesas.com>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Lad Prabhakar" <prabhakar.mahadev-lad.rj@bp.renesas.com>,
"Pavel Machek" <pavel@denx.de>,
"Hien Huynh" <hien.huynh.px@renesas.com>,
"Yangtao Li" <frank.li@vivo.com>,
"Peter Ujfalusi" <peter.ujfalusi@gmail.com>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Orson Zhai" <orsonzhai@gmail.com>,
"Baolin Wang" <baolin.wang@linux.alibaba.com>,
"Chunyan Zhang" <zhang.lyra@gmail.com>,
"Patrice Chotard" <patrice.chotard@foss.st.com>,
"Chen-Yu Tsai" <wens@csie.org>,
"Samuel Holland" <samuel@sholland.org>,
linux-sunxi@lists.linux.dev,
"Laxman Dewangan" <ldewangan@nvidia.com>,
"Jon Hunter" <jonathanh@nvidia.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
linux-tegra@vger.kernel.org, "Lizhi Hou" <lizhi.hou@amd.com>,
"Brian Xu" <brian.xu@amd.com>,
"Raj Kumar Rampelli" <raj.kumar.rampelli@amd.com>,
"Michal Simek" <michal.simek@amd.com>,
"Radhey Shyam Pandey" <radhey.shyam.pandey@amd.com>,
"Peter Korsgaard" <peter@korsgaard.com>,
"Liu Shixin" <liushixin2@huawei.com>,
"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
"Harini Katakam" <harini.katakam@amd.com>,
"Swati Agarwal" <swati.agarwal@amd.com>
Subject: [PATCH 00/59] dma: Convert to platform remove callback returning void
Date: Tue, 19 Sep 2023 15:31:08 +0200 [thread overview]
Message-ID: <20230919133207.1400430-1-u.kleine-koenig@pengutronix.de> (raw)
Hello,
this series convert nearly all platform drivers below drivers/dma to use
.remove_new(). The motivation is to get rid of an integer return code
that is (mostly) ignored by the platform driver core and error prone on
the driver side.
See commit 5c5a7680e67b ("platform: Provide a remove callback that
returns no value") for an extended explanation and the eventual goal.
There are 4 drivers I didn't convert in this series:
drivers/dma/milbeaut-hdmac.c
drivers/dma/milbeaut-xdmac.c
drivers/dma/uniphier-mdmac.c
drivers/dma/uniphier-xdmac.c
These all might return early in .remove() if dmaengine_terminate_sync()
fails. I only looked deeper into the first one, and this shows exactly
the error that is easy to make with .remove() returning an int: When
returning early from .remove(), some cleanup (here:
dma_async_device_unregister()) is skipped. So the dma device stays
known, but the device is still unregistered and the devm allocated stuff
(here e.g. *mdev) is freed. So it can probably easily happen, that
something tries to use the dma device and this will likely result in an
oops.
I don't know enough about the dma framework to address this properly,
maybe someone else knows what to do?
There are no interdependencies between the patches. As there are still
quite a few drivers to convert, I'm happy about every patch that makes
it in. So even if there is a merge conflict with one patch until you
apply or I picked a wrong subject prefix, please apply the remainder of
this series anyhow.
Best regards
Uwe
Uwe Kleine-König (59):
dma: altera-msgdma: Convert to platform remove callback returning void
dma: apple-admac: Convert to platform remove callback returning void
dma: at_hdmac: Convert to platform remove callback returning void
dma: at_xdmac: Convert to platform remove callback returning void
dma: bcm-sba-raid: Convert to platform remove callback returning void
dma: bcm2835-dma: Convert to platform remove callback returning void
dma: bestcomm: bestcomm: Convert to platform remove callback returning
void
dma: dma-axi-dmac: Convert to platform remove callback returning void
dma: dma-jz4780: Convert to platform remove callback returning void
dma: dw-axi-dmac: dw-axi-dmac-platform: Convert to platform remove
callback returning void
dma: dw: platform: Convert to platform remove callback returning void
dma: fsl-edma-main: Convert to platform remove callback returning void
dma: fsl-qdma: Convert to platform remove callback returning void
dma: fsl_raid: Convert to platform remove callback returning void
dma: fsldma: Convert to platform remove callback returning void
dma: idma64: Convert to platform remove callback returning void
dma: img-mdc-dma: Convert to platform remove callback returning void
dma: imx-dma: Convert to platform remove callback returning void
dma: imx-sdma: Convert to platform remove callback returning void
dma: k3dma: Convert to platform remove callback returning void
dma: mcf-edma-main: Convert to platform remove callback returning void
dma: mediatek: mtk-cqdma: Convert to platform remove callback
returning void
dma: mediatek: mtk-hsdma: Convert to platform remove callback
returning void
dma: mediatek: mtk-uart-apdma: Convert to platform remove callback
returning void
dma: mmp_pdma: Convert to platform remove callback returning void
dma: mmp_tdma: Convert to platform remove callback returning void
dma: moxart-dma: Convert to platform remove callback returning void
dma: mpc512x_dma: Convert to platform remove callback returning void
dma: mv_xor_v2: Convert to platform remove callback returning void
dma: nbpfaxi: Convert to platform remove callback returning void
dma: owl-dma: Convert to platform remove callback returning void
dma: ppc4xx: adma: Convert to platform remove callback returning void
dma: pxa_dma: Convert to platform remove callback returning void
dma: qcom: bam_dma: Convert to platform remove callback returning void
dma: qcom: hidma: Convert to platform remove callback returning void
dma: qcom: qcom_adm: Convert to platform remove callback returning
void
dma: sa11x0-dma: Convert to platform remove callback returning void
dma: sf-pdma: sf-pdma: Convert to platform remove callback returning
void
dma: sh: rcar-dmac: Convert to platform remove callback returning void
dma: sh: rz-dmac: Convert to platform remove callback returning void
dma: sh: shdmac: Convert to platform remove callback returning void
dma: sh: usb-dmac: Convert to platform remove callback returning void
dma: sprd-dma: Convert to platform remove callback returning void
dma: st_fdma: Convert to platform remove callback returning void
dma: sun4i-dma: Convert to platform remove callback returning void
dma: sun6i-dma: Convert to platform remove callback returning void
dma: tegra186-gpc-dma: Convert to platform remove callback returning
void
dma: tegra20-apb-dma: Convert to platform remove callback returning
void
dma: tegra210-adma: Convert to platform remove callback returning void
dma: ti: cppi41: Convert to platform remove callback returning void
dma: ti: edma: Convert to platform remove callback returning void
dma: ti: omap-dma: Convert to platform remove callback returning void
dma: timb_dma: Convert to platform remove callback returning void
dma: txx9dmac: Convert to platform remove callback returning void
dma: xgene-dma: Convert to platform remove callback returning void
dma: xilinx: xdma: Convert to platform remove callback returning void
dma: xilinx: xilinx_dma: Convert to platform remove callback returning
void
dma: xilinx: xilinx_dpdma: Convert to platform remove callback
returning void
dma: xilinx: zynqmp_dma: Convert to platform remove callback returning
void
drivers/dma/altera-msgdma.c | 6 ++----
drivers/dma/apple-admac.c | 6 ++----
drivers/dma/at_hdmac.c | 6 ++----
drivers/dma/at_xdmac.c | 6 ++----
drivers/dma/bcm-sba-raid.c | 6 ++----
drivers/dma/bcm2835-dma.c | 6 ++----
drivers/dma/bestcomm/bestcomm.c | 6 ++----
drivers/dma/dma-axi-dmac.c | 6 ++----
drivers/dma/dma-jz4780.c | 6 ++----
drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c | 6 ++----
drivers/dma/dw/platform.c | 6 ++----
drivers/dma/fsl-edma-main.c | 6 ++----
drivers/dma/fsl-qdma.c | 5 ++---
drivers/dma/fsl_raid.c | 6 ++----
drivers/dma/fsldma.c | 6 ++----
drivers/dma/idma64.c | 6 ++----
drivers/dma/img-mdc-dma.c | 6 ++----
drivers/dma/imx-dma.c | 6 ++----
drivers/dma/imx-sdma.c | 5 ++---
drivers/dma/k3dma.c | 5 ++---
drivers/dma/mcf-edma-main.c | 6 ++----
drivers/dma/mediatek/mtk-cqdma.c | 6 ++----
drivers/dma/mediatek/mtk-hsdma.c | 6 ++----
drivers/dma/mediatek/mtk-uart-apdma.c | 6 ++----
drivers/dma/mmp_pdma.c | 5 ++---
drivers/dma/mmp_tdma.c | 6 ++----
drivers/dma/moxart-dma.c | 6 ++----
drivers/dma/mpc512x_dma.c | 6 ++----
drivers/dma/mv_xor_v2.c | 6 ++----
drivers/dma/nbpfaxi.c | 6 ++----
drivers/dma/owl-dma.c | 6 ++----
drivers/dma/ppc4xx/adma.c | 5 ++---
drivers/dma/pxa_dma.c | 5 ++---
drivers/dma/qcom/bam_dma.c | 6 ++----
drivers/dma/qcom/hidma.c | 6 ++----
drivers/dma/qcom/qcom_adm.c | 6 ++----
drivers/dma/sa11x0-dma.c | 6 ++----
drivers/dma/sf-pdma/sf-pdma.c | 6 ++----
drivers/dma/sh/rcar-dmac.c | 6 ++----
drivers/dma/sh/rz-dmac.c | 6 ++----
drivers/dma/sh/shdmac.c | 6 ++----
drivers/dma/sh/usb-dmac.c | 6 ++----
drivers/dma/sprd-dma.c | 5 ++---
drivers/dma/st_fdma.c | 6 ++----
drivers/dma/sun4i-dma.c | 6 ++----
drivers/dma/sun6i-dma.c | 6 ++----
drivers/dma/tegra186-gpc-dma.c | 6 ++----
drivers/dma/tegra20-apb-dma.c | 6 ++----
drivers/dma/tegra210-adma.c | 6 ++----
drivers/dma/ti/cppi41.c | 5 ++---
drivers/dma/ti/edma.c | 6 ++----
drivers/dma/ti/omap-dma.c | 6 ++----
drivers/dma/timb_dma.c | 5 ++---
drivers/dma/txx9dmac.c | 10 ++++------
drivers/dma/xgene-dma.c | 6 ++----
drivers/dma/xilinx/xdma.c | 6 ++----
drivers/dma/xilinx/xilinx_dma.c | 6 ++----
drivers/dma/xilinx/xilinx_dpdma.c | 6 ++----
drivers/dma/xilinx/zynqmp_dma.c | 6 ++----
59 files changed, 120 insertions(+), 229 deletions(-)
base-commit: 29e400e3ea486bf942b214769fc9778098114113
--
2.40.1
next reply other threads:[~2023-09-19 13:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-19 13:31 Uwe Kleine-König [this message]
2023-09-19 13:31 ` [PATCH 09/59] dma: dma-jz4780: Convert to platform remove callback returning void Uwe Kleine-König
2023-09-19 13:39 ` Paul Cercueil
2023-09-19 14:48 ` Uwe Kleine-König
2023-09-20 15:44 ` Philippe Mathieu-Daudé
2023-09-28 7:46 ` [PATCH 00/59] dma: " Vinod Koul
2023-09-28 7:49 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230919133207.1400430-1-u.kleine-koenig@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=Eugeniy.Paltsev@synopsys.com \
--cc=afaerber@suse.de \
--cc=agross@kernel.org \
--cc=alyssa@rosenzweig.io \
--cc=andersson@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=asahi@lists.linux.dev \
--cc=baolin.wang@linux.alibaba.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=brian.xu@amd.com \
--cc=daniel@zonque.org \
--cc=dmaengine@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=florian.fainelli@broadcom.com \
--cc=frank.li@vivo.com \
--cc=geert+renesas@glider.be \
--cc=green.wan@sifive.com \
--cc=gustavoars@kernel.org \
--cc=haojian.zhuang@gmail.com \
--cc=harini.katakam@amd.com \
--cc=hien.huynh.px@renesas.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=keescook@chromium.org \
--cc=kernel@pengutronix.de \
--cc=konrad.dybcio@linaro.org \
--cc=lars@metafoo.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=ldewangan@nvidia.com \
--cc=leoyang.li@nxp.com \
--cc=linux-actions@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=linux-tegra@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=liushixin2@huawei.com \
--cc=lizhi.hou@amd.com \
--cc=ludovic.desroches@microchip.com \
--cc=mani@kernel.org \
--cc=marcan@marcan.st \
--cc=matthias.bgg@gmail.com \
--cc=michal.simek@amd.com \
--cc=okaya@kernel.org \
--cc=olivierdautricourt@gmail.com \
--cc=orsonzhai@gmail.com \
--cc=patrice.chotard@foss.st.com \
--cc=paul@crapouillou.net \
--cc=pavel@denx.de \
--cc=peter.ujfalusi@gmail.com \
--cc=peter@korsgaard.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=radhey.shyam.pandey@amd.com \
--cc=raj.kumar.rampelli@amd.com \
--cc=rjui@broadcom.com \
--cc=robert.jarzmik@free.fr \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=samuel@sholland.org \
--cc=sbranden@broadcom.com \
--cc=sean.wang@mediatek.com \
--cc=shawnguo@kernel.org \
--cc=sr@denx.de \
--cc=sven@svenpeter.dev \
--cc=swati.agarwal@amd.com \
--cc=thierry.reding@gmail.com \
--cc=tudor.ambarus@linaro.org \
--cc=vireshk@kernel.org \
--cc=vkoul@kernel.org \
--cc=wens@csie.org \
--cc=ye.xingchen@zte.com.cn \
--cc=zhang.lyra@gmail.com \
--cc=zw@zh-kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).