* mips: question about switch_to()->__sanitize_fcr31()
@ 2023-11-21 13:52 Oleg Nesterov
2023-11-28 20:58 ` Oleg Nesterov
0 siblings, 1 reply; 2+ messages in thread
From: Oleg Nesterov @ 2023-11-21 13:52 UTC (permalink / raw)
To: Maciej W. Rozycki, Thomas Bogendoerfer; +Cc: linux-mips
Hello,
I know absolutely nothing about arch/mips, I can't even find the
definition of "current" or the caller of switch_to().
So, __sanitize_fcr31() is called by switch_to() and it does
force_fcr31_sig(fcr31, pc, next).
Was "current" already updated at this stage so that next == current?
Why I am asking. I want to add
// otherwise the usage of ->siglock is not safe
WARN_ON(!(t == current || task_is_traced(t)));
into force_sig_info_to_task() and simplify it a bit, but I don't
know if "t == current" is already true at the start of switch_to().
Thanks,
Oleg.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: mips: question about switch_to()->__sanitize_fcr31()
2023-11-21 13:52 mips: question about switch_to()->__sanitize_fcr31() Oleg Nesterov
@ 2023-11-28 20:58 ` Oleg Nesterov
0 siblings, 0 replies; 2+ messages in thread
From: Oleg Nesterov @ 2023-11-28 20:58 UTC (permalink / raw)
To: Maciej W. Rozycki, Thomas Bogendoerfer; +Cc: linux-mips
ping.
On 11/21, Oleg Nesterov wrote:
>
> Hello,
>
> I know absolutely nothing about arch/mips, I can't even find the
> definition of "current" or the caller of switch_to().
>
> So, __sanitize_fcr31() is called by switch_to() and it does
> force_fcr31_sig(fcr31, pc, next).
>
> Was "current" already updated at this stage so that next == current?
>
>
> Why I am asking. I want to add
>
> // otherwise the usage of ->siglock is not safe
> WARN_ON(!(t == current || task_is_traced(t)));
>
> into force_sig_info_to_task() and simplify it a bit, but I don't
> know if "t == current" is already true at the start of switch_to().
>
>
> Thanks,
>
> Oleg.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-11-28 21:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-21 13:52 mips: question about switch_to()->__sanitize_fcr31() Oleg Nesterov
2023-11-28 20:58 ` Oleg Nesterov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).