From: Lee Jones <lee@kernel.org>
To: Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Pavel Machek <pavel@ucw.cz>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Heiner Kallweit <hkallweit1@gmail.com>
Cc: linux-leds@vger.kernel.org, linux-sound@vger.kernel.org,
linux-mips@vger.kernel.org
Subject: Re: [PATCH v2 0/3] leds: trigger: Improve handling of led_trigger_event() and simplify mute audio trigger
Date: Tue, 5 Mar 2024 12:09:47 +0000 [thread overview]
Message-ID: <20240305120947.GD86322@google.com> (raw)
In-Reply-To: <170964052434.128456.128263499797916605.b4-ty@kernel.org>
On Tue, 05 Mar 2024, Lee Jones wrote:
> On Mon, 04 Mar 2024 21:56:29 +0100, Heiner Kallweit wrote:
> > If a simple trigger is assigned to a LED, then the LED may be off until
> > the next led_trigger_event() call. This may be an issue for simple
> > triggers with rare led_trigger_event() calls, e.g. power supply
> > charging indicators (drivers/power/supply/power_supply_leds.c).
> > Therefore persist the brightness value of the last led_trigger_event()
> > call and use this value if the trigger is assigned to a LED.
> > This change allows to use simple triggers in more cases.
> > As a first use case simplify handling of the mute audio trigger.
> >
> > [...]
>
> Applied, thanks!
>
> [1/3] leds: trigger: Store brightness set by led_trigger_event()
> commit: 575129855dee0e364af7df84a77ab5cca54b1442
> [2/3] ALSA: control-led: Integrate mute led trigger
> commit: ba8adb1646ee498029ac12b20e792d9d0dd17920
> [3/3] leds: trigger: audio: Remove this trigger
> commit: 2c61168294d0ea42a5542dbc864afb03a76bbc11
Submitted for build testing.
Once succeeded, a PR will follow for other maintainers to pull from.
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2024-03-05 12:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-04 20:56 [PATCH v2 0/3] leds: trigger: Improve handling of led_trigger_event() and simplify mute audio trigger Heiner Kallweit
2024-03-04 20:57 ` [PATCH v2 1/3] leds: trigger: Store brightness set by led_trigger_event() Heiner Kallweit
2024-03-04 20:58 ` [PATCH v2 2/3] ALSA: control-led: Integrate mute led trigger Heiner Kallweit
2024-03-04 20:59 ` [PATCH v2 3/3] leds: trigger: audio: Remove this trigger Heiner Kallweit
2024-03-05 9:08 ` [PATCH v2 0/3] leds: trigger: Improve handling of led_trigger_event() and simplify mute audio trigger Takashi Iwai
2024-03-05 12:08 ` Lee Jones
2024-03-05 12:09 ` Lee Jones [this message]
2024-03-05 14:54 ` Lee Jones
2024-03-05 15:56 ` Heiner Kallweit
2024-03-05 16:06 ` Lee Jones
2024-03-08 17:30 ` Heiner Kallweit
2024-03-27 12:08 ` Heiner Kallweit
2024-03-27 13:14 ` Lee Jones
2024-03-28 10:42 ` Lee Jones
2024-04-05 9:22 ` Heiner Kallweit
2024-04-11 9:22 ` Lee Jones
2024-04-11 15:44 ` [GIT PULL] Immutable branch between MFD, MIPS and Sound due for the v6.10 merge window Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240305120947.GD86322@google.com \
--to=lee@kernel.org \
--cc=hkallweit1@gmail.com \
--cc=linux-leds@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).