From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED6471B86D9; Fri, 19 Jul 2024 16:39:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.176.79.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721407146; cv=none; b=Pe4uyIG41c/rwlLU1mDfUhqu1vOMPfKJOyjxGQlnTqBQ6UvRS6VnT3EQS3aSawJQTm5YRXQdzzfBVLDUCG+ZFpSILYplZRxxERsAXpck3DWYcFfjyj7MC2aEBoWqf06cFsEqr7TXeMBC1Z05ykSMnraqlW3sgOwE8yfF6iihU4E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721407146; c=relaxed/simple; bh=VpRjTTVsoB19qADBnkSclAP5d15vCF4RdPq8cv7AYBc=; h=Date:From:To:CC:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=mPbU4g6DxsuKpkby0M7MZKlwnp8SiuksdSO/ed/x0Vn5uSYyNbM+sJr6W265JFuF8jBh82ilA3qvUCxobvv6QAv9B/AR5wBpxRldt0qPSn5xSEnYu70wFPGrpwl+pC3oYG0W6QMZ3k/9ceRHe46+EYVqjssIzgFx5cIUI/1TVV0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=Huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=185.176.79.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=Huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4WQb1q2xppz6JBgm; Sat, 20 Jul 2024 00:37:35 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id EE605140517; Sat, 20 Jul 2024 00:38:59 +0800 (CST) Received: from localhost (10.48.157.16) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 19 Jul 2024 17:38:58 +0100 Date: Fri, 19 Jul 2024 17:38:49 +0100 From: Jonathan Cameron To: Mike Rapoport CC: , Alexander Gordeev , Andreas Larsson , "Andrew Morton" , Arnd Bergmann , "Borislav Petkov" , Catalin Marinas , Christophe Leroy , Dan Williams , Dave Hansen , David Hildenbrand , "David S. Miller" , Greg Kroah-Hartman , Heiko Carstens , Huacai Chen , Ingo Molnar , Jiaxun Yang , "John Paul Adrian Glaubitz" , Michael Ellerman , Palmer Dabbelt , "Rafael J. Wysocki" , Rob Herring , "Thomas Bogendoerfer" , Thomas Gleixner , Vasily Gorbik , Will Deacon , , , , , , , , , , , , , , , Subject: Re: [PATCH 08/17] x86/numa_emu: simplify allocation of phys_dist Message-ID: <20240719173849.00007c51@Huawei.com> In-Reply-To: <20240716111346.3676969-9-rppt@kernel.org> References: <20240716111346.3676969-1-rppt@kernel.org> <20240716111346.3676969-9-rppt@kernel.org> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-mips@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: lhrpeml500006.china.huawei.com (7.191.161.198) To lhrpeml500005.china.huawei.com (7.191.163.240) On Tue, 16 Jul 2024 14:13:37 +0300 Mike Rapoport wrote: > From: "Mike Rapoport (Microsoft)" > > By the time numa_emulation() is called, all physical memory is already > mapped in the direct map and there is no need to define limits for > memblock allocation. > > Replace memblock_phys_alloc_range() with memblock_alloc(). > > Signed-off-by: Mike Rapoport (Microsoft) Indeed seems to be after mapping physical memory, so this looks fine. Reviewed-by: Jonathan Cameron