From: Jiaxun Yang <jiaxun.yang@flygoat.com>
To: Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Huacai Chen <chenhuacai@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Serge Semin <fancer.lancer@gmail.com>,
Paul Burton <paulburton@kernel.org>
Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
Jiaxun Yang <jiaxun.yang@flygoat.com>
Subject: [PATCH v5 05/10] MIPS: smp: Implement IPI stats
Date: Sun, 08 Sep 2024 11:20:16 +0100 [thread overview]
Message-ID: <20240908-b4-mips-ipi-improvements-v5-5-be8617dd2e53@flygoat.com> (raw)
In-Reply-To: <20240908-b4-mips-ipi-improvements-v5-0-be8617dd2e53@flygoat.com>
Show IPI statistics in arch_show_interrupts to help users
analysis IPI performance.
Tested-by: Serge Semin <fancer.lancer@gmail.com>
Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
---
arch/mips/include/asm/ipi.h | 9 +++++++++
arch/mips/kernel/irq.c | 4 ++++
arch/mips/kernel/smp.c | 13 +++++++++++++
3 files changed, 26 insertions(+)
diff --git a/arch/mips/include/asm/ipi.h b/arch/mips/include/asm/ipi.h
index 7cac0f4ccf37..7d310012962f 100644
--- a/arch/mips/include/asm/ipi.h
+++ b/arch/mips/include/asm/ipi.h
@@ -36,6 +36,7 @@ void mips_smp_ipi_disable(void);
extern bool mips_smp_ipi_have_virq_range(void);
void mips_smp_ipi_set_irqdomain(struct irq_domain *d);
extern void mips_smp_ipi_set_virq_range(int virq, int nr);
+extern void mips_smp_show_ipi_stats(struct seq_file *p, int prec);
#else
static inline void mips_smp_ipi_enable(void)
{
@@ -44,6 +45,10 @@ static inline void mips_smp_ipi_enable(void)
static inline void mips_smp_ipi_disable(void)
{
}
+
+static inline void mips_smp_show_ipi_stats(struct seq_file *p, int prec)
+{
+}
#endif /* CONFIG_GENERIC_IRQ_IPI */
#else
static inline void mips_smp_ipi_set_virq_range(int virq, int nr)
@@ -58,5 +63,9 @@ static inline bool mips_smp_ipi_have_virq_range(void)
{
return false;
}
+
+static inline void mips_smp_show_ipi_stats(struct seq_file *p, int prec)
+{
+}
#endif /* CONFIG_SMP */
#endif
diff --git a/arch/mips/kernel/irq.c b/arch/mips/kernel/irq.c
index 5e11582fe308..c3ea8d80e0cb 100644
--- a/arch/mips/kernel/irq.c
+++ b/arch/mips/kernel/irq.c
@@ -26,6 +26,8 @@
#include <linux/atomic.h>
#include <linux/uaccess.h>
+#include <asm/ipi.h>
+
void *irq_stack[NR_CPUS];
/*
@@ -42,6 +44,8 @@ atomic_t irq_err_count;
int arch_show_interrupts(struct seq_file *p, int prec)
{
seq_printf(p, "%*s: %10u\n", prec, "ERR", atomic_read(&irq_err_count));
+ mips_smp_show_ipi_stats(p, prec);
+
return 0;
}
diff --git a/arch/mips/kernel/smp.c b/arch/mips/kernel/smp.c
index 81ae65f21f73..aa02ca2e0fcf 100644
--- a/arch/mips/kernel/smp.c
+++ b/arch/mips/kernel/smp.c
@@ -243,6 +243,19 @@ void mips_smp_ipi_disable(void)
disable_percpu_irq(ipi_virqs[i]);
}
+void mips_smp_show_ipi_stats(struct seq_file *p, int prec)
+{
+ unsigned int cpu, i;
+
+ for (i = 0; i < IPI_MAX; i++) {
+ seq_printf(p, "%*s%u:%s", prec - 1, "IPI", i,
+ prec >= 4 ? " " : "");
+ for_each_online_cpu(cpu)
+ seq_printf(p, "%10u ", irq_desc_kstat_cpu(ipi_desc[i], cpu));
+ seq_printf(p, " %s\n", ipi_names[i]);
+ }
+}
+
static void smp_ipi_init_one(unsigned int virq, const char *name,
irq_handler_t handler)
{
--
2.46.0
next prev parent reply other threads:[~2024-09-08 10:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-08 10:20 [PATCH v5 00/10] MIPS: IPI Improvements Jiaxun Yang
2024-09-08 10:20 ` [PATCH v5 01/10] MIPS: smp: Make IPI interrupts scalable Jiaxun Yang
2024-09-12 3:47 ` Florian Fainelli
2024-09-08 10:20 ` [PATCH v5 02/10] MIPS: smp: Manage IPI interrupts as percpu_devid interrupts Jiaxun Yang
2024-09-08 10:20 ` [PATCH v5 03/10] MIPS: smp: Provide platform IPI virq & domain hooks Jiaxun Yang
2024-09-08 10:20 ` [PATCH v5 04/10] MIPS: Move mips_smp_ipi_init call after prepare_cpus Jiaxun Yang
2024-09-08 10:20 ` Jiaxun Yang [this message]
2024-09-08 10:20 ` [PATCH v5 06/10] irqchip/irq-mips-gic: Switch to ipi_mux Jiaxun Yang
2024-09-08 10:20 ` [PATCH v5 07/10] MIPS: Implement get_mips_sw_int hook Jiaxun Yang
2024-09-08 10:20 ` [PATCH v5 08/10] MIPS: GIC: Implement get_sw_int hook Jiaxun Yang
2024-09-08 10:20 ` [PATCH v5 09/10] irqchip/irq-mips-cpu: Rework software IRQ handling flow Jiaxun Yang
2024-09-08 10:20 ` [PATCH v5 10/10] MIPS: smp-mt: Rework IPI functions Jiaxun Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240908-b4-mips-ipi-improvements-v5-5-be8617dd2e53@flygoat.com \
--to=jiaxun.yang@flygoat.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=chenhuacai@kernel.org \
--cc=fancer.lancer@gmail.com \
--cc=florian.fainelli@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=paulburton@kernel.org \
--cc=tglx@linutronix.de \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).