Re: [PATCH net-next v25 06/13] memory-provider: dmabuf devmem memory provider

Jakub Kicinski
2024-09-10T01:56:19Z

On Mon, 9 Sep 2024 05:43:11 +0000 Mina Almasry wrote:
> diff --git a/include/net/netmem.h b/include/net/netmem.h
> index 5eccc40df92d..8a6e20be4b9d 100644
> --- a/include/net/netmem.h
> +++ b/include/net/netmem.h
> @@ -8,6 +8,7 @@
> #ifndef _NET_NETMEM_H
> #define _NET_NETMEM_H
>
> +#include <linux/mm.h>
> #include <net/net_debug.h>

This should be in the previous patch, I think. page_address() etc.

> diff --git a/net/core/page_pool.c b/net/core/page_pool.c
> index 52659db2d765..c737200f4fac 100644
> --- a/net/core/page_pool.c
> +++ b/net/core/page_pool.c
> @@ -11,6 +11,7 @@
> #include <linux/slab.h>
> #include <linux/device.h>
>
> +#include <net/netdev_rx_queue.h>
> #include <net/page_pool/helpers.h>
> #include <net/xdp.h>
>
> @@ -24,8 +25,10 @@
>
> #include <trace/events/page_pool.h>
>
> +#include "mp_dmabuf_devmem.h"
> #include "netmem_priv.h"
> #include "page_pool_priv.h"
> +#include "mp_dmabuf_devmem.h"

nit: duplicate include

With that:

Reviewed-by: Jakub Kicinski <kuba@kernel.org>
--
pw-bot: cr