From: Lee Jones <lee@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Chris Packham <chris.packham@alliedtelesis.co.nz>,
andi.shyti@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, sre@kernel.org, tsbogend@alpha.franken.de,
linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
linux-mips@vger.kernel.org
Subject: Re: [PATCH v5 3/6] dt-bindings: mfd: Add Realtek RTL9300 switch peripherals
Date: Thu, 26 Sep 2024 08:45:54 +0100 [thread overview]
Message-ID: <20240926074554.GH7545@google.com> (raw)
In-Reply-To: <4pxungrwkjusdalmjbwvqcpjwmbsb7hw4452zqlto6sq54vfa6@psz3gge4uwy7>
Intentional top-post.
These replies all came in without the original mail.
Does anyone have any idea why that would have been?
On Thu, 26 Sep 2024, Krzysztof Kozlowski wrote:
> On Thu, Sep 26, 2024 at 09:58:44AM +1200, Chris Packham wrote:
> > Add device tree schema for the Realtek RTL9300 switches. The RTL9300
> > family is made up of the RTL9301, RTL9302B, RTL9302C and RTL9303. These
> > have the same SoC differ in the Ethernet switch/SERDES arrangement.
> >
> > Currently the only supported features are the syscon-reboot and i2c
> > controllers. The syscon-reboot is needed to be able to reboot the board.
> > The I2C controllers are slightly unusual because they each own an SCL
> > pin (GPIO8 for the first controller, GPIO 17 for the second) but have 8
> > common SDA pins which can be assigned to either controller (but not
> > both).
> >
> > Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> > ---
> >
> > Notes:
> > Changes in v5:
> > I've combined the two series I had in flight so this is the
> > combination of adding the switch syscon, the reboot and i2c. It makes
> > the changelog a bit meaningless so I've dropped the earlier
> > commentary.
> >
> > As requested I've put a more complete example in the main
> > rtl9300-switch.yaml.
> >
> > I've kept rtl9300-i2c.yaml separate for now but link to it with a $ref
> > from rtl9300-switch.yaml to reduce clutter. The example in
> > rtl9300-i2c.yaml is technically duplicating part of the example from
> > rtl9300-switch.yaml but I feel it's nice to be able to see the example
> > next to where the properties are defined.
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> Best regards,
> Krzysztof
>
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2024-09-26 7:46 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-25 21:58 [PATCH v5 0/6] RTL9300 support for reboot and i2c Chris Packham
2024-09-25 21:58 ` [PATCH v5 1/6] dt-bindings: reset: syscon-reboot: Add reg property Chris Packham
2024-09-26 6:34 ` Krzysztof Kozlowski
2024-09-25 21:58 ` [PATCH v5 2/6] power: reset: syscon-reboot: Accept " Chris Packham
2024-09-26 6:35 ` Krzysztof Kozlowski
2024-09-25 21:58 ` [PATCH v5 3/6] dt-bindings: mfd: Add Realtek RTL9300 switch peripherals Chris Packham
2024-09-26 6:36 ` Krzysztof Kozlowski
2024-09-26 7:45 ` Lee Jones [this message]
2024-09-26 7:47 ` Krzysztof Kozlowski
2024-09-25 21:58 ` [PATCH v5 4/6] mips: dts: realtek: Add syscon-reboot node Chris Packham
2024-09-26 6:36 ` Krzysztof Kozlowski
2024-09-25 21:58 ` [PATCH v5 5/6] mips: dts: realtek: Add I2C controllers Chris Packham
2024-09-26 6:37 ` Krzysztof Kozlowski
2024-09-26 20:52 ` Chris Packham
2024-09-26 20:58 ` [PATCH v5] fixup! i2c: Add driver for the RTL9300 I2C controller Chris Packham
2024-09-25 21:58 ` [PATCH v5 6/6] " Chris Packham
2024-09-29 2:41 ` kernel test robot
2024-09-29 8:45 ` Markus Elfring
2024-09-29 20:17 ` Chris Packham
2024-09-30 7:55 ` Markus Elfring
2024-09-30 8:12 ` Javier Carrasco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240926074554.GH7545@google.com \
--to=lee@kernel.org \
--cc=andi.shyti@kernel.org \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sre@kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).