linux-mips.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sergey Matsievskiy <matsievskiysv@gmail.com>
To: linus.walleij@linaro.org
Cc: alexandre.belloni@bootlin.com, quentin.schulz@bootlin.com,
	lars.povlsen@microchip.com, horatiu.vultur@microchip.com,
	andriy.shevchenko@linux.intel.com, linux-gpio@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org,
	UNGLinuxDriver@microchip.com,
	Sergey Matsievskiy <matsievskiysv@gmail.com>
Subject: [PATCH 0/1] pinctrl: ocelot: fix system hang on level based interrupts
Date: Sun,  6 Oct 2024 21:13:09 +0300	[thread overview]
Message-ID: <20241006181310.181309-1-matsievskiysv@gmail.com> (raw)

I've encountered the interrupt handle loop when using Jaguar VSC7448
chip with MAX3421, configured in level interrupt mode (default mode for
MAX3421). Upon connecting thumb drive to MAX3421, the system would
hang. After some investigation, I've traced the problem to the GPIO
interrupt controller code: by the time ocelot_irq_handler() is executed,
MAX3421 would clear its interrupt, subsequently lowering bit in GPIO
controller interrupt identify register. Because of this,
chained_irq_enter() would never be executed, and the parent interrupt
would never be cleared, resulting in a continuous interrupt handling
loop.

This could be fixed by clearing parent interrupt unconditionally, even
when no bits are set in interrupt identify registers.

Sergey Matsievskiy (1):
  pinctrl: ocelot: fix system hang on level based interrupts

 drivers/pinctrl/pinctrl-ocelot.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

-- 
2.39.5


             reply	other threads:[~2024-10-06 18:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-06 18:13 Sergey Matsievskiy [this message]
2024-10-06 18:13 ` [PATCH 1/1] pinctrl: ocelot: fix system hang on level based interrupts Sergey Matsievskiy
2024-10-11  9:18   ` Linus Walleij
2024-10-11 15:40     ` Sergey Matsievskiy
2024-10-11 20:02       ` Linus Walleij
2024-10-11 20:54   ` Alexandre Belloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241006181310.181309-1-matsievskiysv@gmail.com \
    --to=matsievskiysv@gmail.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=horatiu.vultur@microchip.com \
    --cc=lars.povlsen@microchip.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=quentin.schulz@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).