From: Jonathan Cameron <jic23@kernel.org>
To: Matteo Martelli <matteomartelli3@gmail.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Alisa-Dariana Roman <alisa.roman@analog.com>,
Christian Eggers <ceggers@arri.de>, Peter Rosin <peda@axentia.se>,
Paul Cercueil <paul@crapouillou.net>,
Sebastian Reichel <sre@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mips@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH v4 0/5] iio: fix possible race condition during access of available info lists
Date: Sat, 19 Oct 2024 13:07:26 +0100 [thread overview]
Message-ID: <20241019130726.336a76d7@jic23-huawei> (raw)
In-Reply-To: <20241018-iio-read-avail-release-v4-0-53c8ac618585@gmail.com>
On Fri, 18 Oct 2024 12:16:39 +0200
Matteo Martelli <matteomartelli3@gmail.com> wrote:
> Some iio drivers currently share an available info list buffer that
> might be changed while iio core prints it to sysfs. This could cause the
> buffer shared with iio core to be corrupted. However, note that I was
> able to trigger the race condition only by adding a delay between each
> sysfs_emit_at calls in the iio_format_list() to force the concurrent
> access to the shared available list buffer.
Other than the 'rules' developing around cleanup.h usage, the series looks
good to me. Sadly that stuff is a can of worms for the unwary (and for
various reasons the usage doc got lost so the guidance is not quite in yet)!
Jonathan
prev parent reply other threads:[~2024-10-19 12:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-18 10:16 [PATCH v4 0/5] iio: fix possible race condition during access of available info lists Matteo Martelli
2024-10-18 10:16 ` [PATCH v4 1/5] iio: core: add read_avail_release_resource callback to fix race Matteo Martelli
2024-10-18 10:16 ` [PATCH v4 2/5] iio: consumers: copy/release available info from producer " Matteo Martelli
2024-10-19 12:04 ` Jonathan Cameron
2024-10-18 10:16 ` [PATCH v4 3/5] iio: pac1921: use read_avail+release APIs instead of custom ext_info Matteo Martelli
2024-10-18 10:16 ` [PATCH v4 4/5] iio: ad7192: copy/release available filter frequencies to fix race Matteo Martelli
2024-10-18 10:16 ` [PATCH v4 5/5] iio: as73211: copy/release available integration times " Matteo Martelli
2024-10-19 6:06 ` Christian Eggers
2024-10-19 12:07 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241019130726.336a76d7@jic23-huawei \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=alisa.roman@analog.com \
--cc=ceggers@arri.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=matteomartelli3@gmail.com \
--cc=paul@crapouillou.net \
--cc=peda@axentia.se \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox