From: Krzysztof Kozlowski <krzk@kernel.org>
To: Chris Packham <chris.packham@alliedtelesis.co.nz>
Cc: lee@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, andrew+netdev@lunn.ch, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
tsbogend@alpha.franken.de, hkallweit1@gmail.com,
linux@armlinux.org.uk, sander@svanheule.net,
markus.stockhausen@gmx.de, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-mips@vger.kernel.org
Subject: Re: [PATCH v5 2/4] dt-bindings: mfd: Add MDIO interface to rtl9301-switch
Date: Fri, 31 Jan 2025 08:33:27 +0100 [thread overview]
Message-ID: <20250131-kind-rapid-kagu-7fc4c5@krzk-bin> (raw)
In-Reply-To: <20250131010151.2527688-3-chris.packham@alliedtelesis.co.nz>
On Fri, Jan 31, 2025 at 02:01:49PM +1300, Chris Packham wrote:
> .../bindings/mfd/realtek,rtl9301-switch.yaml | 29 +++++++++++++++++++
> 1 file changed, 29 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mfd/realtek,rtl9301-switch.yaml b/Documentation/devicetree/bindings/mfd/realtek,rtl9301-switch.yaml
> index f053303ab1e6..89e10213a4ee 100644
> --- a/Documentation/devicetree/bindings/mfd/realtek,rtl9301-switch.yaml
> +++ b/Documentation/devicetree/bindings/mfd/realtek,rtl9301-switch.yaml
> @@ -28,6 +28,9 @@ properties:
> reg:
> maxItems: 1
>
> + mdio-controller:
> + $ref: /schemas/net/realtek,rtl9301-mdio.yaml#
> +
So this mdio-controller looks duplicated now. Why is it needed?
> '#address-cells':
> const: 1
>
> @@ -41,6 +44,10 @@ patternProperties:
> 'i2c@[0-9a-f]+$':
> $ref: /schemas/i2c/realtek,rtl9301-i2c.yaml#
>
> + 'mdio-controller@[0-9a-f]+$':
> + $ref: /schemas/net/realtek,rtl9301-mdio.yaml#
> +
> +
Just one blank line.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-01-31 7:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-31 1:01 [PATCH v5 0/4] RTL9300 MDIO driver Chris Packham
2025-01-31 1:01 ` [PATCH v5 1/4] dt-bindings: net: Add Realtek MDIO controller Chris Packham
2025-01-31 7:31 ` Krzysztof Kozlowski
2025-01-31 1:01 ` [PATCH v5 2/4] dt-bindings: mfd: Add MDIO interface to rtl9301-switch Chris Packham
2025-01-31 6:35 ` Daniel Golle
2025-02-02 20:14 ` Chris Packham
2025-01-31 7:33 ` Krzysztof Kozlowski [this message]
2025-01-31 1:01 ` [PATCH v5 3/4] mips: dts: realtek: Add MDIO controller Chris Packham
2025-01-31 1:01 ` [PATCH v5 4/4] net: mdio: Add RTL9300 MDIO driver Chris Packham
2025-01-31 1:16 ` Chris Packham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250131-kind-rapid-kagu-7fc4c5@krzk-bin \
--to=krzk@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=markus.stockhausen@gmx.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=sander@svanheule.net \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox