From: Bartosz Golaszewski <brgl@bgdev.pl>
To: "Basavaraj Natikar" <Basavaraj.Natikar@amd.com>,
"Shyam Sundar S K" <Shyam-sundar.S-k@amd.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
"Chen-Yu Tsai" <wens@csie.org>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
"Andreas Färber" <afaerber@suse.de>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Paul Cercueil" <paul@crapouillou.net>,
"Steen Hegelund" <Steen.Hegelund@microchip.com>,
"Daniel Machon" <daniel.machon@microchip.com>,
UNGLinuxDriver@microchip.com,
"Ludovic Desroches" <ludovic.desroches@microchip.com>,
"Nicolas Ferre" <nicolas.ferre@microchip.com>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Claudiu Beznea" <claudiu.beznea@tuxon.dev>,
"Andrew Lunn" <andrew@lunn.ch>,
"Gregory Clement" <gregory.clement@bootlin.com>,
"Sebastian Hesselbarth" <sebastian.hesselbarth@gmail.com>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"Sylwester Nawrocki" <s.nawrocki@samsung.com>,
"Alim Akhtar" <alim.akhtar@samsung.com>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-actions@lists.infradead.org, linux-mips@vger.kernel.org,
linux-samsung-soc@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: [PATCH 04/12] pinctrl: owl: use new GPIO line value setter callbacks
Date: Thu, 24 Apr 2025 10:35:27 +0200 [thread overview]
Message-ID: <20250424-gpiochip-set-rv-pinctrl-part2-v1-4-504f91120b99@linaro.org> (raw)
In-Reply-To: <20250424-gpiochip-set-rv-pinctrl-part2-v1-0-504f91120b99@linaro.org>
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
struct gpio_chip now has callbacks for setting line values that return
an integer, allowing to indicate failures. Convert the driver to using
them.
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
drivers/pinctrl/actions/pinctrl-owl.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/pinctrl/actions/pinctrl-owl.c b/drivers/pinctrl/actions/pinctrl-owl.c
index d49b77dcfcff..86f3d5c69e36 100644
--- a/drivers/pinctrl/actions/pinctrl-owl.c
+++ b/drivers/pinctrl/actions/pinctrl-owl.c
@@ -598,7 +598,7 @@ static int owl_gpio_get(struct gpio_chip *chip, unsigned int offset)
return !!(val & BIT(offset));
}
-static void owl_gpio_set(struct gpio_chip *chip, unsigned int offset, int value)
+static int owl_gpio_set(struct gpio_chip *chip, unsigned int offset, int value)
{
struct owl_pinctrl *pctrl = gpiochip_get_data(chip);
const struct owl_gpio_port *port;
@@ -607,13 +607,15 @@ static void owl_gpio_set(struct gpio_chip *chip, unsigned int offset, int value)
port = owl_gpio_get_port(pctrl, &offset);
if (WARN_ON(port == NULL))
- return;
+ return -ENODEV;
gpio_base = pctrl->base + port->offset;
raw_spin_lock_irqsave(&pctrl->lock, flags);
owl_gpio_update_reg(gpio_base + port->dat, offset, value);
raw_spin_unlock_irqrestore(&pctrl->lock, flags);
+
+ return 0;
}
static int owl_gpio_direction_input(struct gpio_chip *chip, unsigned int offset)
@@ -960,7 +962,7 @@ int owl_pinctrl_probe(struct platform_device *pdev,
pctrl->chip.direction_input = owl_gpio_direction_input;
pctrl->chip.direction_output = owl_gpio_direction_output;
pctrl->chip.get = owl_gpio_get;
- pctrl->chip.set = owl_gpio_set;
+ pctrl->chip.set_rv = owl_gpio_set;
pctrl->chip.request = owl_gpio_request;
pctrl->chip.free = owl_gpio_free;
--
2.45.2
next prev parent reply other threads:[~2025-04-24 8:35 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-24 8:35 [PATCH 00/12] pinctrl: convert GPIO chips to using new value setters - part 2 for v6.16 Bartosz Golaszewski
2025-04-24 8:35 ` [PATCH 01/12] pinctrl: amd: use new GPIO line value setter callbacks Bartosz Golaszewski
2025-04-24 8:35 ` [PATCH 02/12] pinctrl: axp209: " Bartosz Golaszewski
2025-04-24 17:43 ` Chen-Yu Tsai
2025-04-24 18:55 ` Bartosz Golaszewski
2025-04-29 8:35 ` Linus Walleij
2025-04-24 8:35 ` [PATCH 03/12] pinctrl: stmfx: " Bartosz Golaszewski
2025-04-24 14:59 ` [Linux-stm32] " Amelie Delaunay
2025-04-24 8:35 ` Bartosz Golaszewski [this message]
2025-04-28 16:07 ` [PATCH 04/12] pinctrl: owl: " Manivannan Sadhasivam
2025-04-24 8:35 ` [PATCH 05/12] pinctrl: stm32: " Bartosz Golaszewski
2025-04-24 16:04 ` [Linux-stm32] " Antonio Borneo
2025-04-24 8:35 ` [PATCH 06/12] pinctrl: ingenic: " Bartosz Golaszewski
2025-04-24 10:13 ` Paul Cercueil
2025-04-24 8:35 ` [PATCH 07/12] pinctrl: microchip-sgpio: " Bartosz Golaszewski
2025-04-24 8:35 ` [PATCH 08/12] pinctrl: at91: allow building the module with COMPILE_TEST=y Bartosz Golaszewski
2025-04-24 8:35 ` [PATCH 09/12] pinctrl: at91: use new GPIO line value setter callbacks Bartosz Golaszewski
2025-04-24 8:35 ` [PATCH 10/12] pinctrl: armada-37xx: " Bartosz Golaszewski
2025-04-24 8:35 ` [PATCH 11/12] pinctrl: pistachio: " Bartosz Golaszewski
2025-04-24 8:35 ` [PATCH 12/12] pinctrl: samsung: " Bartosz Golaszewski
2025-04-27 19:17 ` (subset) " Krzysztof Kozlowski
2025-04-29 8:31 ` [PATCH 00/12] pinctrl: convert GPIO chips to using new value setters - part 2 for v6.16 Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250424-gpiochip-set-rv-pinctrl-part2-v1-4-504f91120b99@linaro.org \
--to=brgl@bgdev.pl \
--cc=Basavaraj.Natikar@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=Steen.Hegelund@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=afaerber@suse.de \
--cc=alexandre.belloni@bootlin.com \
--cc=alexandre.torgue@foss.st.com \
--cc=alim.akhtar@samsung.com \
--cc=andrew@lunn.ch \
--cc=bartosz.golaszewski@linaro.org \
--cc=claudiu.beznea@tuxon.dev \
--cc=daniel.machon@microchip.com \
--cc=gregory.clement@bootlin.com \
--cc=krzk@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-actions@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=ludovic.desroches@microchip.com \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=nicolas.ferre@microchip.com \
--cc=paul@crapouillou.net \
--cc=s.nawrocki@samsung.com \
--cc=sebastian.hesselbarth@gmail.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).