From: Rosen Penev <rosenp@gmail.com>
To: linux-wireless@vger.kernel.org
Cc: Johannes Berg <johannes@sipsolutions.net>,
yangshiji66@qq.com, ansuelsmth@gmail.com,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Stanislaw Gruszka <stf_xl@wp.pl>,
devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND
FLATTENED DEVICE TREE BINDINGS),
linux-kernel@vger.kernel.org (open list),
linux-mips@vger.kernel.org (open list:MIPS),
linux-arm-kernel@lists.infradead.org (moderated
list:ARM/Mediatek SoC support),
linux-mediatek@lists.infradead.org (moderated list:ARM/Mediatek
SoC support)
Subject: [PATCH 1/6] wifi: rt2x00: fix compilation
Date: Sun, 6 Jul 2025 14:41:06 -0700 [thread overview]
Message-ID: <20250706214111.45687-2-rosenp@gmail.com> (raw)
In-Reply-To: <20250706214111.45687-1-rosenp@gmail.com>
The .remove prototype commits seem to have missed this driver. Probably
because COMPILE_TEST is missing.
This is a mess anyway. These non static functions will be moved to their
proper place.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
drivers/net/wireless/ralink/rt2x00/Kconfig | 2 +-
drivers/net/wireless/ralink/rt2x00/rt2x00soc.c | 4 +---
drivers/net/wireless/ralink/rt2x00/rt2x00soc.h | 2 +-
3 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/net/wireless/ralink/rt2x00/Kconfig b/drivers/net/wireless/ralink/rt2x00/Kconfig
index d1fd66d44a7e..3a32ceead54f 100644
--- a/drivers/net/wireless/ralink/rt2x00/Kconfig
+++ b/drivers/net/wireless/ralink/rt2x00/Kconfig
@@ -202,7 +202,7 @@ endif
config RT2800SOC
tristate "Ralink WiSoC support"
- depends on SOC_RT288X || SOC_RT305X || SOC_MT7620
+ depends on SOC_RT288X || SOC_RT305X || SOC_MT7620 || COMPILE_TEST
select RT2X00_LIB_SOC
select RT2X00_LIB_MMIO
select RT2X00_LIB_CRYPTO
diff --git a/drivers/net/wireless/ralink/rt2x00/rt2x00soc.c b/drivers/net/wireless/ralink/rt2x00/rt2x00soc.c
index eface610178d..f7f3a2340c39 100644
--- a/drivers/net/wireless/ralink/rt2x00/rt2x00soc.c
+++ b/drivers/net/wireless/ralink/rt2x00/rt2x00soc.c
@@ -108,7 +108,7 @@ int rt2x00soc_probe(struct platform_device *pdev, const struct rt2x00_ops *ops)
}
EXPORT_SYMBOL_GPL(rt2x00soc_probe);
-int rt2x00soc_remove(struct platform_device *pdev)
+void rt2x00soc_remove(struct platform_device *pdev)
{
struct ieee80211_hw *hw = platform_get_drvdata(pdev);
struct rt2x00_dev *rt2x00dev = hw->priv;
@@ -119,8 +119,6 @@ int rt2x00soc_remove(struct platform_device *pdev)
rt2x00lib_remove_dev(rt2x00dev);
rt2x00soc_free_reg(rt2x00dev);
ieee80211_free_hw(hw);
-
- return 0;
}
EXPORT_SYMBOL_GPL(rt2x00soc_remove);
diff --git a/drivers/net/wireless/ralink/rt2x00/rt2x00soc.h b/drivers/net/wireless/ralink/rt2x00/rt2x00soc.h
index 021fd06b3627..d6226b8a10e0 100644
--- a/drivers/net/wireless/ralink/rt2x00/rt2x00soc.h
+++ b/drivers/net/wireless/ralink/rt2x00/rt2x00soc.h
@@ -17,7 +17,7 @@
* SoC driver handlers.
*/
int rt2x00soc_probe(struct platform_device *pdev, const struct rt2x00_ops *ops);
-int rt2x00soc_remove(struct platform_device *pdev);
+void rt2x00soc_remove(struct platform_device *pdev);
#ifdef CONFIG_PM
int rt2x00soc_suspend(struct platform_device *pdev, pm_message_t state);
int rt2x00soc_resume(struct platform_device *pdev);
--
2.50.0
next prev parent reply other threads:[~2025-07-06 21:41 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-06 21:41 [PATCH 0/6] wifi: rt2x00: add OF bindings + cleanup Rosen Penev
2025-07-06 21:41 ` Rosen Penev [this message]
2025-07-08 10:00 ` [PATCH 1/6] wifi: rt2x00: fix compilation Sergio Paracuellos
2025-07-06 21:41 ` [PATCH 2/6] wifi: rt2x00: remove mod_name from platform_driver Rosen Penev
2025-07-08 10:01 ` Sergio Paracuellos
2025-07-06 21:41 ` [PATCH 3/6] wifi: rt2800soc: allow loading from OF Rosen Penev
2025-07-08 10:03 ` Sergio Paracuellos
2025-07-06 21:41 ` [PATCH 4/6] wifi: rt2x00: soc: move and modernize probe Rosen Penev
2025-07-08 10:07 ` Sergio Paracuellos
2025-07-06 21:41 ` [PATCH 5/6] dt-bindings: net: wireless: rt2800: add Rosen Penev
2025-07-06 22:29 ` Rob Herring (Arm)
2025-07-06 23:51 ` Rosen Penev
2025-07-06 21:41 ` [PATCH 6/6] MIPS: dts: ralink: mt7628a: add wifi binding Rosen Penev
2025-07-08 1:19 ` Daniel Golle
2025-07-08 1:36 ` Rosen Penev
2025-07-07 9:01 ` [PATCH 0/6] wifi: rt2x00: add OF bindings + cleanup Johannes Berg
2025-07-07 17:41 ` Rosen Penev
2025-07-07 18:36 ` Johannes Berg
2025-07-07 22:55 ` Rosen Penev
2025-07-08 6:51 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250706214111.45687-2-rosenp@gmail.com \
--to=rosenp@gmail.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=ansuelsmth@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=johannes@sipsolutions.net \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=robh@kernel.org \
--cc=stf_xl@wp.pl \
--cc=tsbogend@alpha.franken.de \
--cc=yangshiji66@qq.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).