Re: [PATCH 3/3] dt-bindings: mips: lantiq: Add Lantiq platform binding

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2538 bytes --]

On Wed, Aug 13, 2025 at 04:21:34PM +0200, Aleksander Jan Bajkowski wrote:
> Document the top-level device tree binding for Lantiq MIPS-based SoCs
> 
> Signed-off-by: Aleksander Jan Bajkowski <olek2@wp.pl>
> ---
>  .../devicetree/bindings/mips/lantiq/soc.yaml  | 60 +++++++++++++++++++
>  1 file changed, 60 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mips/lantiq/soc.yaml
> 
> diff --git a/Documentation/devicetree/bindings/mips/lantiq/soc.yaml b/Documentation/devicetree/bindings/mips/lantiq/soc.yaml
> new file mode 100644
> index 000000000000..e1708cd9b07e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mips/lantiq/soc.yaml
> @@ -0,0 +1,60 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mips/lantiq/soc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Lantiq SoC based Platform
> +
> +maintainers:
> +  - Aleksander Jan Bajkowski <olek2@wp.pl>
> +
> +description:
> +  Devices with a Lantiq CPU shall have the following properties.
> +
> +properties:
> +  $nodename:
> +    const: "/"
> +  compatible:
> +    oneOf:
> +      - description: Boards with Lantiq Amazon-SE SoC
> +        items:
> +          - const: lantiq,ase

Half these entries you have added say "boards" but there are no boards
in them at all. Where are the boards? Only the homehub entry appears to
be complete.


Cheers,
Conor.

> +
> +      - description: Boards with Lantiq Danube SoC
> +        items:
> +          - const: lantiq,danube
> +
> +      - description: Boards with Lantiq Falcon SoC
> +        items:
> +          - const: lantiq,falcon
> +
> +      - description: Boards with Lantiq Twinpass SoC
> +        items:
> +          - const: lantiq,twinpass
> +
> +      - description: Boards with Lantiq ARX100 SoC
> +        items:
> +          - const: lantiq,ar9
> +
> +      - description: Boards with Lantiq GRX100 SoC
> +        items:
> +          - const: lantiq,gr9
> +
> +      - description: Boards with Lantiq xRX200 SoC
> +        items:
> +          - enum:
> +              - bt,homehub-v5a
> +          - const: lantiq,vr9
> +
> +      - description: Boards with Lantiq xRX300 SoC
> +        items:
> +          - const: lantiq,ar10
> +
> +      - description: Boards with Lantiq xRX330 SoC
> +        items:
> +          - const: lantiq,grx390
> +
> +additionalProperties: true
> +
> +...
> -- 
> 2.47.2
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]