Re: [PATCH] dt-bindings: mips: lantiq: Document Lantiq Xway VMMC

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2562 bytes --]

On Thu, Aug 14, 2025 at 06:17:45PM +0200, Aleksander Jan Bajkowski wrote:
> The Lantiq SoCs have a 2nd mips core called "voice mips macro core (vmmc)"
> which is used to run the voice firmware.
> 
> Signed-off-by: Aleksander Jan Bajkowski <olek2@wp.pl>
> ---
>  .../mips/lantiq/lantiq,vmmc-xway.yaml         | 51 +++++++++++++++++++
>  1 file changed, 51 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mips/lantiq/lantiq,vmmc-xway.yaml
> 
> diff --git a/Documentation/devicetree/bindings/mips/lantiq/lantiq,vmmc-xway.yaml b/Documentation/devicetree/bindings/mips/lantiq/lantiq,vmmc-xway.yaml
> new file mode 100644
> index 000000000000..bee64f6d0e97
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mips/lantiq/lantiq,vmmc-xway.yaml
> @@ -0,0 +1,51 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mips/lantiq/lantiq,vmmc-xway.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Lantiq VMMC (Voice MIPS Macro Core)
> +
> +maintainers:
> +  - Aleksander Jan Bajkowski <olek2@wp.pl>
> +
> +description:
> +  The Lantiq SoCs have a 2nd mips core called "Voice MIPS Macro Core (VMMC)"
> +  which is used to run the voice firmware. The firmware handles analog
> +  telephone lines.
> +
> +properties:
> +  compatible:
> +    items:
> +      - enum:
> +          - lantiq,vmmc-xway

Same comment here as elsewhere, the commit message seems to suggest that
you're trying to use one compatible for multiple devices. Not using
soc-specific compatibles requires justification if that's what you're
doing as they are the norm.

> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    minItems: 6
> +    maxItems: 6

Same comment here as elsewhere re: items list explaining each item.

> +
> +  gpios: true

What are these gpios? You've got 3 below, what portion of those three
are required? How many mix/max?

> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +    vmmc@107000 {
> +        compatible = "lantiq,vmmc-xway";
> +        reg = <0x107000 0x300>;
> +        interrupt-parent = <&icu0>;
> +        interrupts = <150>, <151>, <152>, <153>, <154>, <155>;
> +        gpios = <&gpio 30 GPIO_ACTIVE_HIGH
> +                 &gpio 31 GPIO_ACTIVE_HIGH
> +                 &gpio 3  GPIO_ACTIVE_HIGH>;
> +
> +    };
> -- 
> 2.47.2
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]