From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8CE4E2ECD32; Mon, 25 Aug 2025 13:43:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756129429; cv=none; b=ukjZDMv0K62KgcJdGJNU+G1k6N5pCu432+AuVHEOWiGCC1XjLSWvmMxaNzFJ5eCp296q93tDuS3rurY5Qok475slEzgzuO8veCFzic52Y893ydUYcsQtfUt1+yxjGkSGsHCoEuGO6NjQDr4XSB8Hg8ykFZwNVMN7x/XKX+vX0jY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756129429; c=relaxed/simple; bh=wk0b8XpwPxcYQ3noQMP9GONlP4C4Be6y8QzZeFkyZik=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ZxZsK10xA9eIXqnaj6sStbzQgvrqVqjn6Lyvu3by+HK8IzG3CarH1yIPm00XcvnaYWYwIu2UGLGptAh9oH+Lh1TA8vYRXYnsAonUVIoticRlnmdzzYXkI5qxkI8qQEbjUrCiFS648ScGfHMBvpMnOGL9xun1SF6thbOq8tvf+ug= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=TNLr/eqZ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="TNLr/eqZ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E63F9C19421; Mon, 25 Aug 2025 13:43:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1756129429; bh=wk0b8XpwPxcYQ3noQMP9GONlP4C4Be6y8QzZeFkyZik=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=TNLr/eqZS5Z5YnxUeOhVHiHkvHvTkPfq6dRrv+J0eaL13OfGotbCDFdtrYU17Psj2 CGX+ig2ydR3YjaxgJD6RCVskBi/KqVQcJAfF85oMmqynJ2mAqd6k8MMJB4zAcmHlKx 0kPw3FGXEZvbQfDbSxGs/EeuNVEzesMvWw014OhX3oRFZ9V6teLe7xB73Rxl7eZZdP dZJK9hZmIWf935nEi7cvWg6+QflYB8Qcjn4JW4Jt6+vcQl9SHSCsh4BE/xRYw0iBYd 4wc3gBrx20XdyoTxrsvYCzob9TOo4bZvl/cWmWK/kycZ4M1boz9akiSv7VR6thFTt2 /lxt7tx/Lcvog== From: Maxime Ripard Date: Mon, 25 Aug 2025 15:43:10 +0200 Subject: [PATCH 05/39] drm/atomic: Document __drm_connectors_state state pointer Precedence: bulk X-Mailing-List: linux-mips@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250825-drm-no-more-existing-state-v1-5-f08ccd9f85c9@kernel.org> References: <20250825-drm-no-more-existing-state-v1-0-f08ccd9f85c9@kernel.org> In-Reply-To: <20250825-drm-no-more-existing-state-v1-0-f08ccd9f85c9@kernel.org> To: Maarten Lankhorst , Thomas Zimmermann , David Airlie , Simona Vetter , Louis Chauvet , Haneen Mohammed , Melissa Wen , Jyri Sarha , Tomi Valkeinen , Paul Cercueil , Liviu Dudau , Russell King , Manikandan Muralidharan , Dharma Balasubiramani , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Inki Dae , Seung-Woo Kim , Kyungmin Park , Krzysztof Kozlowski , Alim Akhtar , Liu Ying , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Laurentiu Palcu , Lucas Stach , Philipp Zabel , Anitha Chrisanthus , Edmund Dea , Paul Kocialkowski , Sui Jingfeng , Chun-Kuang Hu , Matthias Brugger , AngeloGioacchino Del Regno , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Sandy Huang , =?utf-8?q?Heiko_St=C3=BCbner?= , Andy Yan , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Thierry Reding , Mikko Perttunen , Jonathan Hunter , Hans de Goede , Dave Stevenson , =?utf-8?q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, imx@lists.linux.dev, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, Maxime Ripard X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1590; i=mripard@kernel.org; h=from:subject:message-id; bh=wk0b8XpwPxcYQ3noQMP9GONlP4C4Be6y8QzZeFkyZik=; b=owGbwMvMwCmsHn9OcpHtvjLG02pJDBlrMkpsFz4STLt/pPDOz5CsKmlWm7e+UmcNrFidjyrn6 mnPELrdMZWFQZiTQVZMkeWJTNjp5e2LqxzsV/6AmcPKBDKEgYtTACaiMImxYW3Gu1vP5V+wcj6q NGtUkPrZOeO+p2bbzcjqLm62d6/yJp3Z/nK7Ay/HxNch2SbWTbuWMTbMKnLYcC64JKft16ZaL+M tPFyTFi8qVgi/0G+3T9riBJf3p0PHVvotOjOHd7n8N656jTwA X-Developer-Key: i=mripard@kernel.org; a=openpgp; fpr=BE5675C37E818C8B5764241C254BCFC56BF6CE8D While the old and new state pointers are somewhat self-explanatory, the state pointer and its relation to the other two really isn't. Now that we've cleaned up everything and it isn't used in any modesetting path, we can document what it's still useful for: to free the right state when we free the global state. Signed-off-by: Maxime Ripard --- include/drm/drm_atomic.h | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/include/drm/drm_atomic.h b/include/drm/drm_atomic.h index 321c866d5b0a46df7a9adbbf5e4cabd1ff987aad..798d33b50ef7497ce938ce3dbabee32487dda2d6 100644 --- a/include/drm/drm_atomic.h +++ b/include/drm/drm_atomic.h @@ -180,11 +180,26 @@ struct __drm_crtcs_state { u64 last_vblank_count; }; struct __drm_connnectors_state { struct drm_connector *ptr; - struct drm_connector_state *state, *old_state, *new_state; + + /** + * @state: + * + * Used to track the @drm_connector_state we will need to free + * when tearing down the associated &drm_atomic_state. + * + * Before a commit, and the call to + * drm_atomic_helper_swap_state() in particular, it points to + * the same state than @new_state. After a commit, it points to + * the same state than @old_state. + */ + struct drm_connector_state *state; + + struct drm_connector_state *old_state, *new_state; + /** * @out_fence_ptr: * * User-provided pointer which the kernel uses to return a sync_file * file descriptor. Used by writeback connectors to signal completion of -- 2.50.1