From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Benoît Monin" <benoit.monin@bootlin.com>
Cc: "Vladimir Kondratiev" <vladimir.kondratiev@mobileye.com>,
"Gregory CLEMENT" <gregory.clement@bootlin.com>,
"Théo Lebrun" <theo.lebrun@bootlin.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
"Michael Turquette" <mturquette@baylibre.com>,
"Stephen Boyd" <sboyd@kernel.org>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
linux-mips@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
"Tawfik Bayouk" <tawfik.bayouk@mobileye.com>,
"Sari Khoury" <sari.khoury@mobileye.com>
Subject: Re: [PATCH 03/19] dt-bindings: soc: mobileye: add eyeQ7H compatibles
Date: Thu, 4 Sep 2025 11:22:16 +0200 [thread overview]
Message-ID: <20250904-pristine-unicorn-of-greatness-40eca6@kuoka> (raw)
In-Reply-To: <20250903-clk-eyeq7-v1-3-3f5024b5d6e2@bootlin.com>
On Wed, Sep 03, 2025 at 02:47:10PM +0200, Benoît Monin wrote:
> patternProperties:
> '-pins?$':
> @@ -265,6 +279,88 @@ required:
> additionalProperties: false
>
> allOf:
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - mobileye,eyeq5-olb
> + - mobileye,eyeq6l-olb
> + - mobileye,eyeq6h-acc-olb
> + - mobileye,eyeq6h-central-olb
> + - mobileye,eyeq6h-east-olb
> + - mobileye,eyeq6h-west-olb
> + - mobileye,eyeq6h-south-olb
> + - mobileye,eyeq6h-ddr0-olb
> + - mobileye,eyeq6h-ddr1-olb
> + - mobileye,eyeq7h-south-olb
> + - mobileye,eyeq7h-periph-east-olb
> + - mobileye,eyeq7h-ddr0-olb
> + - mobileye,eyeq7h-ddr1-olb
> + - mobileye,eyeq7h-mips0-olb
> + - mobileye,eyeq7h-mips1-olb
> + - mobileye,eyeq7h-mips2-olb
> + then:
> + properties:
> + clocks:
> + minItems: 1
Drop
> + maxItems: 1
> + clock-names:
> + items:
> + - const: ref
> +
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - mobileye,eyeq7h-east-olb
> + - mobileye,eyeq7h-west-olb
> + then:
> + properties:
> + clocks:
> + minItems: 2
> + maxItems: 2
> + clock-names:
> + items:
> + - const: ref
> + - const: ref_100p0
> +
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - mobileye,eyeq7h-periph-west-olb
> + then:
> + properties:
> + clocks:
> + minItems: 2
> + maxItems: 2
> + clock-names:
> + items:
> + - const: ref_100p0
> + - const: ref_106p6_w
> +
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - mobileye,eyeq7h-acc0-olb
> + - mobileye,eyeq7h-acc1-olb
> + - mobileye,eyeq7h-xnn0-olb
> + - mobileye,eyeq7h-xnn1-olb
> + then:
> + properties:
> + clocks:
> + minItems: 2
> + maxItems: 2
> + clock-names:
> + items:
> + - const: ref_100p0
> + - const: ref_106p6_e
That's the same as previous ref_106p6_w.
These are not names of clocks. These are names of inputs.
> +
> # Compatibles exposing a single reset domain.
> - if:
> properties:
> @@ -274,6 +370,12 @@ allOf:
> - mobileye,eyeq6h-acc-olb
> - mobileye,eyeq6h-east-olb
> - mobileye,eyeq6h-west-olb
> + - mobileye,eyeq7h-east-olb
> + - mobileye,eyeq7h-west-olb
> + - mobileye,eyeq7h-periph-east-olb
> + - mobileye,eyeq7h-periph-west-olb
> + - mobileye,eyeq7h-ddr0-olb
> + - mobileye,eyeq7h-ddr1-olb
> then:
> properties:
> '#reset-cells':
> @@ -289,6 +391,11 @@ allOf:
> enum:
> - mobileye,eyeq5-olb
> - mobileye,eyeq6l-olb
> + - mobileye,eyeq7h-south-olb
> + - mobileye,eyeq7h-acc0-olb
> + - mobileye,eyeq7h-acc1-olb
> + - mobileye,eyeq7h-xnn0-olb
> + - mobileye,eyeq7h-xnn1-olb
> then:
> properties:
> '#reset-cells':
> @@ -306,6 +413,9 @@ allOf:
> - mobileye,eyeq6h-south-olb
> - mobileye,eyeq6h-ddr0-olb
> - mobileye,eyeq6h-ddr1-olb
> + - mobileye,eyeq7h-mips0-olb
> + - mobileye,eyeq7h-mips1-olb
> + - mobileye,eyeq7h-mips2-olb
> then:
> properties:
> '#reset-cells': false
> @@ -350,3 +460,18 @@ examples:
> clock-names = "ref";
> };
> };
> + - |
> + soc {
> + #address-cells = <2>;
> + #size-cells = <2>;
> +
> + system-controller0@45000000 {
> + compatible = "mobileye,eyeq7h-acc0-olb", "syscon";
No need for new example for difference in one property.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-09-04 9:22 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-03 12:47 [PATCH 00/19] Add clock and reset support for Mobileye eyeQ7H Benoît Monin
2025-09-03 12:47 ` [PATCH 01/19] dt-bindings: soc: mobileye: rename to eyeq-olb.yaml Benoît Monin
2025-09-04 9:20 ` Krzysztof Kozlowski
2025-09-03 12:47 ` [PATCH 02/19] dt-bindings: clock: mobileye: rename to eyeq-clk.h Benoît Monin
2025-09-04 9:24 ` Krzysztof Kozlowski
2025-09-03 12:47 ` [PATCH 03/19] dt-bindings: soc: mobileye: add eyeQ7H compatibles Benoît Monin
2025-09-04 9:22 ` Krzysztof Kozlowski [this message]
2025-09-03 12:47 ` [PATCH 04/19] dt-bindings: clock: mobileye: add eyeQ7H clock indexes Benoît Monin
2025-09-04 9:23 ` Krzysztof Kozlowski
2025-09-03 12:47 ` [PATCH 05/19] dt-bindings: reset: add Mobileye eyeQ Benoît Monin
2025-09-04 9:25 ` Krzysztof Kozlowski
2025-09-03 12:47 ` [PATCH 06/19] reset: eyeq: add eyeQ7H compatibles Benoît Monin
2025-09-03 12:47 ` [PATCH 07/19] clk: fixed-factor: add clk_hw_register_fixed_factor_with_accuracy Benoît Monin
2025-09-20 5:14 ` Stephen Boyd
2025-09-25 11:47 ` Benoît Monin
2025-09-03 12:47 ` [PATCH 08/19] clk: divider: check divider validity for CLK_DIVIDER_EVEN_INTEGERS Benoît Monin
2025-09-20 5:15 ` Stephen Boyd
2025-09-25 11:51 ` Benoît Monin
2025-09-03 12:47 ` [PATCH 09/19] clk: divider: check validity of flags when a table is provided Benoît Monin
2025-09-20 5:24 ` Stephen Boyd
2025-09-25 11:55 ` Benoît Monin
2025-09-03 12:47 ` [PATCH 10/19] clk: eyeq: skip post-divisor when computing pll divisor Benoît Monin
2025-09-03 12:47 ` [PATCH 11/19] clk: eyeq: rename the parent field to parent_idx Benoît Monin
2025-09-03 12:47 ` [PATCH 12/19] clk: eyeq: lookup parent clock by name Benoît Monin
2025-09-03 12:47 ` [PATCH 13/19] clk: eyeq: prefix the PLL registers with the PLL type Benoît Monin
2025-09-03 12:47 ` [PATCH 14/19] clk: eyeq: rename the reg64 field of eqc_pll Benoît Monin
2025-09-03 12:47 ` [PATCH 15/19] clk: eyeq: add a type for the PLL Benoît Monin
2025-09-03 12:47 ` [PATCH 16/19] clk: eyeq: add two PLL types Benoît Monin
2025-09-03 12:47 ` [PATCH 17/19] clk: eyeq: add a parent field to the pll Benoît Monin
2025-09-03 12:47 ` [PATCH 18/19] clk: eyeq: add an optional clk_div_table to divider Benoît Monin
2025-09-03 12:47 ` [PATCH 19/19] clk: eyeq: add eyeQ7H compatibles Benoît Monin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250904-pristine-unicorn-of-greatness-40eca6@kuoka \
--to=krzk@kernel.org \
--cc=benoit.monin@bootlin.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=krzk+dt@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=sari.khoury@mobileye.com \
--cc=sboyd@kernel.org \
--cc=tawfik.bayouk@mobileye.com \
--cc=theo.lebrun@bootlin.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=tsbogend@alpha.franken.de \
--cc=vladimir.kondratiev@mobileye.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).