From: Bjorn Helgaas <helgaas@kernel.org>
To: "Maciej W. Rozycki" <macro@orcam.me.uk>
Cc: "Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org
Subject: Re: [PATCH 0/2] MIPS: Malta: Fix PCI southbridge legacy resource clashes
Date: Tue, 21 Oct 2025 15:59:12 -0500 [thread overview]
Message-ID: <20251021205912.GA1223028@bhelgaas> (raw)
In-Reply-To: <alpine.DEB.2.21.2510211901530.8377@angie.orcam.me.uk>
[+cc linux-pci]
On Tue, Oct 21, 2025 at 08:38:15PM +0100, Maciej W. Rozycki wrote:
> Hi,
>
> This mini patch series sorts out issues with southbridge legacy resource
> management on the MIPS Malta platform. Two changes turned out required,
> because merely removing the clash would regress the PS/2 interfaces, fixed
> by accident with the PCIBIOS_MIN_IO fix.
>
> This does prove nobody has used these interfaces since forever, or most
> likely since the move to the new serio driver. Things most likely worked
> fine with 2.4 and I still have such old Malta kernel builds lying around
> (though sadly no hardware to try with), although I do know I've never used
> the PS/2 stuff with this platform, e.g. quoting an arbitrarily picked
> 2.4.19-rc1 bootstrap log:
>
> CPU revision is: 00018101
> Primary instruction cache 16kb, linesize 32 bytes(4 ways)
> Primary data cache 16kb, linesize 32 bytes (4 ways)
> Linux version 2.4.19-rc1 (macro@macro.ds2.pg.gda.pl) (gcc version 2.95.4 20010319 (prerelease)) #1 Fri Aug 23 02:55:02 CEST 2002
> [...]
> parport0: PC-style at 0x378 [PCSPP,EPP]
> initialize_kbd: Keyboard reset failed, no ACK
> Detected PS/2 Mouse Port.
> pty: 256 Unix98 ptys configured
> keyboard: Timeout - AT keyboard not present?(ed)
> keyboard: Timeout - AT keyboard not present?(f4)
> Serial driver version 5.05c (2001-07-08) with MANY_PORTS SHARE_IRQ DETECT_IRQ SERIAL_PCI enabled
> [...]
>
> However to prevent the PS/2 interfaces from getting fixed and then broken
> again with backports in a random fashion I have marked both changes for
> backporting as appropriate.
>
> Bjorn, may I request that these changes be placed, with Thomas's ack of
> course (hopefully a formality), ahead of Ilpo's commit 16fbaba2b78f
> ("MIPS: Malta: Use pcibios_align_resource() to block io range") (or
> whatever the latest version is, as said commit seems to be missing tags
> updates you mentioned), and then merged via your tree? That will prevent
> things from breaking just to be fixed again shortly, and overall getting
> out of sync.
>
> See individual commit descriptions for details.
>
> Maciej
Applied with Thomas's acks to pci/for-linus for v6.18, thanks!
next prev parent reply other threads:[~2025-10-21 20:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-21 19:38 [PATCH 0/2] MIPS: Malta: Fix PCI southbridge legacy resource clashes Maciej W. Rozycki
2025-10-21 19:38 ` [PATCH 1/2] MIPS: Malta: Fix keyboard resource preventing i8042 driver from registering Maciej W. Rozycki
2025-10-21 19:45 ` Thomas Bogendoerfer
2025-10-21 19:38 ` [PATCH 2/2] MIPS: Malta: Fix PCI southbridge legacy resource reservations Maciej W. Rozycki
2025-10-21 19:45 ` Thomas Bogendoerfer
2025-10-22 11:42 ` Jonas Gorski
2025-10-22 12:48 ` Maciej W. Rozycki
2025-10-21 20:59 ` Bjorn Helgaas [this message]
2025-10-22 11:08 ` [PATCH 0/2] MIPS: Malta: Fix PCI southbridge legacy resource clashes Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251021205912.GA1223028@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=macro@orcam.me.uk \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).