From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B9DEB327C1B; Wed, 19 Nov 2025 15:51:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763567482; cv=none; b=M7DDVEhUHrqm3uS32t4UQ9gXdkD1D33ahG4OkOaNGJXnXdy7tnBWFwMREJIKKTtvZgQ/3V8hIu6yOVxgYainjGtYVygcMW3gprxNQJTWnw65rh92qZgTi9pIenihFH0Mo1or/ScybcAL7zqh04EItsXlyJrpzNdveqFOHMfZP4w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763567482; c=relaxed/simple; bh=GbMjQfXbVDBRYa99+t6zovRCd+kwGqxoJZCf8LF1Il0=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=dyI4KEGV7/LY/+SVXFi0mCSpuS3myAQa5MnxFjSxdWRG4MwVDDZShmXCcf/7wfClhmPipk6dwQzI77Ko10Le1cH9jA1vR7Sa8uWXwieRfB1T+jXeiGRJgeH2MqMGniZxjwl8mrNW8xkb0QdDV5w4H/BIpYQ36RT9OoxTEh92bns= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=fE6c+Dys; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="fE6c+Dys" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id B484D1A1BD0; Wed, 19 Nov 2025 15:51:17 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 869AA60699; Wed, 19 Nov 2025 15:51:17 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id C220C10371A8D; Wed, 19 Nov 2025 16:51:11 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1763567475; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding; bh=YgkbkBFr0ckOJQWKBFTLiaCszDsoKrpS3iQ1CceK2n8=; b=fE6c+DysR+/xMRp1rzBHfJ2srBe2rV3Jcto4oFkWjbu07IPjIN5QUSOZR8lfCVi0A0JNCO VXmku5imKGgGGvj+fbKllpMFLhk8J5n0hWSY/iUtB2Gm7Y4tAVLQZaN87zb8U9DWdCA5Cx X/OLLPG2KgEttcpweulIUmDpGoaZmHG/r6Wp4zLkwyhPGnr41HDcowOEb10f8LU6ZU2ssR U/CM4BLpwIDc1RDLag+2A+3poejHH+MSIRNtE1Yq6h9CdUR7+HtoeQYErzb45WmLU018Z4 iHE063QrDoBKSH595OTNEPxjSZxyPVRRs/WrixCQTlt8D4KFdy1ua/3TcFaEcQ== From: =?utf-8?q?Th=C3=A9o_Lebrun?= Subject: [PATCH v3 0/7] Add generic PHY driver used by MACB/GEM on EyeQ5 Date: Wed, 19 Nov 2025 16:51:08 +0100 Message-Id: <20251119-macb-phy-v3-0-e9a7be186a33@bootlin.com> Precedence: bulk X-Mailing-List: linux-mips@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-B4-Tracking: v=1; b=H4sIAGznHWkC/22MQQ6CMBBFr0JmbU1nEBFW3sO4oGUqTYSSljQSw t0tbNTE5fv57y0Q2FsOUGcLeI42WDckyA8Z6K4ZHixsmxhIUoGSSPSNVmLsZkGo9ImxNUqVkO6 jZ2Nfe+p2T9zZMDk/7+WI2/onElFIYagydDENl4RX5dz0tMNRux62TKSPihK/VEqqxgIrZoPnN v9V13V9A81gWH3dAAAA X-Change-ID: 20251022-macb-phy-21bc4e1dfbb7 To: Vladimir Kondratiev , =?utf-8?q?Gr=C3=A9gory_Clement?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vinod Koul , Kishon Vijay Abraham I , Michael Turquette , Stephen Boyd , Philipp Zabel , Thomas Bogendoerfer Cc: linux-mips@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-clk@vger.kernel.org, =?utf-8?q?Beno=C3=AEt_Monin?= , Maxime Chevallier , Tawfik Bayouk , Thomas Petazzoni , =?utf-8?q?Th=C3=A9o_Lebrun?= , Conor Dooley , Jerome Brunet , Andrew Lunn X-Mailer: b4 0.14.3 X-Last-TLS-Session-Version: TLSv1.3 EyeQ5 SoCs integrate two GEM instances. A system-controller register region named "OLB" has some control over the Ethernet PHY integration. Past iterations [0] touched those syscon registers directly from MACB. It was a bad idea. Extend the current OLB ecosystem with a new generic PHY driver. - OLB is carried by one main platform driver: clk-eyeq. - It instantiates auxiliary devices: reset-eyeq & pinctrl-eyeq5. - We add a new one: phy-eyeq5-eth. I always find devicetree the simplest way to understand device interactions, so here is a DT overview: olb: system-controller@e00000 { compatible = "mobileye,eyeq5-olb", "syscon"; reg = <0 0xe00000 0x0 0x400>; // ... #reset-cells = <2>; #clock-cells = <1>; #phy-cells = <1>; // <= this is new }; macb0: ethernet@2a00000 { compatible = "mobileye,eyeq5-gem"; phys = <&olb 0>; // <= GEM device consumes the PHY // ... }; macb1: ethernet@2b00000 { compatible = "mobileye,eyeq5-gem"; phys = <&olb 1>; // <= same thing for the second instance // ... }; The Linux MACB driver already consumes a generic PHY for some other compatibles, this is nothing new. The MACB series [1] has been merged into net-next/main. -- About merging, Philipp Zabel gave his ACK for [5/7] to go into linux-clk. The split becomes simpler: - [PATCH 1/7] dt-bindings: soc: mobileye: OLB is an Ethernet PHY provider on EyeQ5 [PATCH 6/7] MIPS: mobileye: eyeq5: add two Cadence GEM Ethernet controllers [PATCH 7/7] MIPS: mobileye: eyeq5-epm: add two Cadence GEM Ethernet PHYs => linux-mips - [PATCH 2/7] phy: Add driver for EyeQ5 Ethernet PHY wrapper => linux-phy - [PATCH 3/7] clk: eyeq: use the auxiliary device creation helper [PATCH 4/7] clk: eyeq: add EyeQ5 children auxiliary device for generic PHYs [PATCH 5/7] reset: eyeq: drop device_set_of_node_from_dev() done by parent => linux-clk MACB patches are in and V1 and V2 were super calm, can we sync to get this V3 in before the v6.19 merge window? Patches apply cleanly on the three linux-{clk,mips,phy} trees. Have a nice day, Thanks! Théo [0]: https://lore.kernel.org/lkml/20250627-macb-v2-15-ff8207d0bb77@bootlin.com/ [1]: https://lore.kernel.org/lkml/20251022-macb-eyeq5-v2-0-7c140abb0581@bootlin.com/ Signed-off-by: Théo Lebrun --- Changes in v3: - Take Philipp Zabel's Reviewed-by & Acked-by trailers on reset patch. - Take Thomas Bogendoerfer's two Acked-by trailers on DT patches. - Rebase on net-next & test on target. Nothing to report. - Link to v2: https://lore.kernel.org/r/20251101-macb-phy-v2-0-c1519eef16d3@bootlin.com Changes in v2: - Take Acked-by: Conor Dooley on dt-bindings-patch. - s/%ld/%tu/ for printing ptrdiff_t; warnings on 32-bit archs. Reported by NIPA's netdev/build_32bit test. https://patchwork.kernel.org/project/netdevbpf/patch/20251021-macb-eyeq5-v1-7-3b0b5a9d2f85@bootlin.com/ https://netdev.bots.linux.dev/static/nipa/1014126/14277857/build_32bit/stderr - Link to v1: https://lore.kernel.org/r/20251022-macb-phy-v1-0-f29f28fae721@bootlin.com Changes since MACB V1: - Drop the old "mobileye,olb" properties from DT patches; found while running dtbs_check and dt_binding_check. - Drop all patches targeting net-next. That is MACB dt-bindings patch and MACB driver code. See there here [1]. - Link to v1: https://lore.kernel.org/lkml/20251021-macb-eyeq5-v1-0-3b0b5a9d2f85@bootlin.com/ Past versions of MACB patches: - March 2025: [PATCH net-next 00/13] Support the Cadence MACB/GEM instances on Mobileye EyeQ5 SoCs https://lore.kernel.org/lkml/20250321-macb-v1-0-537b7e37971d@bootlin.com/ - June 2025: [PATCH net-next v2 00/18] Support the Cadence MACB/GEM instances on Mobileye EyeQ5 SoCs https://lore.kernel.org/lkml/20250627-macb-v2-0-ff8207d0bb77@bootlin.com/ - August 2025: [PATCH net v3 00/16] net: macb: various fixes & cleanup https://lore.kernel.org/lkml/20250808-macb-fixes-v3-0-08f1fcb5179f@bootlin.com/ --- Jerome Brunet (1): clk: eyeq: use the auxiliary device creation helper Théo Lebrun (6): dt-bindings: soc: mobileye: OLB is an Ethernet PHY provider on EyeQ5 phy: Add driver for EyeQ5 Ethernet PHY wrapper clk: eyeq: add EyeQ5 children auxiliary device for generic PHYs reset: eyeq: drop device_set_of_node_from_dev() done by parent MIPS: mobileye: eyeq5: add two Cadence GEM Ethernet controllers MIPS: mobileye: eyeq5-epm: add two Cadence GEM Ethernet PHYs .../bindings/soc/mobileye/mobileye,eyeq5-olb.yaml | 7 +- MAINTAINERS | 1 + arch/mips/boot/dts/mobileye/eyeq5-epm5.dts | 26 +++ arch/mips/boot/dts/mobileye/eyeq5.dtsi | 45 ++++ drivers/clk/clk-eyeq.c | 60 ++--- drivers/phy/Kconfig | 13 ++ drivers/phy/Makefile | 1 + drivers/phy/phy-eyeq5-eth.c | 254 +++++++++++++++++++++ drivers/reset/reset-eyeq.c | 24 +- 9 files changed, 363 insertions(+), 68 deletions(-) --- base-commit: 4bd327737e4e408bed2daa1a3fc2ce45afab1790 change-id: 20251022-macb-phy-21bc4e1dfbb7 Best regards, -- Théo Lebrun