From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 06DCA16132F; Sun, 7 Dec 2025 14:01:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765116074; cv=none; b=G1Q79u0ZNVqScYkzk7jDB/QTdoX8s2g0FbBfWbiTT/xsX4dNdYXgPBJBGUy9oychWtPifJ/6v10goNsgFzBAkNhFLPUlecFnWh3GIBfUiQLkW7PbweoKMvHa/FwAPVSAvfjHJF2T30OnQnz4lSgUw4UWrNBz/aWfqSA4rEwxTf0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765116074; c=relaxed/simple; bh=XIPzPHGdu9MVAiWYzmLVkJFzpk/+VDBaaF5v6Z7S21s=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Ce4FcUxQ1282a91kbMuMJ3xs1MO0Vu5NJ+DKabqD9sgv2tuywNwEutXWhartsJ5TTS8iCWsuYdMEaAyXLkNrftercW7VS9Ng70vfhrLlzE2WPBc87zESMPFC1msWa8D3c7VodcZSSEtsCPwAC/6GYbTm5OY9b+gIQCSPnCHoTG8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=EsCx8mM8; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="EsCx8mM8" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0AD22C4CEFB; Sun, 7 Dec 2025 14:00:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1765116073; bh=XIPzPHGdu9MVAiWYzmLVkJFzpk/+VDBaaF5v6Z7S21s=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=EsCx8mM87A8HyrcrJI3CQaCEoWdzjxwjyxeqqWomtZPKX5oKnNhnVYczlV7yr+api h1nrsAZDZtwq8anuESeyBIikhqAGux8Sco7E2Rn/vfqVt3PrLc2LEXvN4NSCJv8VNd QVVaCfRbNh41EPha2La8wU9XYpzaRw5oeg/WKfl2DGoA8/1tRRDfQAYNuQDEo9c9yk dqBAsLPZNDc43gMPXaP5nnzCsVtGWyKsl2w7so4uosQ6fq9FfMfKiMuPsd2YnYkyMA RKvB9A/O4JQAg0lFIEGn3i1jJw/CzAX645QjvGuZeOKfDEgbv9poaPspTv29soMaUq UJU9YlFfffWtg== Date: Sun, 7 Dec 2025 14:00:46 +0000 From: Jonathan Cameron To: Romain Gantois Cc: MyungJoo Ham , Chanwoo Choi , Guenter Roeck , Peter Rosin , Nuno =?UTF-8?B?U8Oh?= , Andy Shevchenko , Lars-Peter Clausen , Michael Hennerich , Mariel Tinaco , Kevin Tsai , Linus Walleij , Dmitry Torokhov , Eugen Hristev , Vinod Koul , Kishon Vijay Abraham I , Sebastian Reichel , Chen-Yu Tsai , Hans de Goede , Support Opensource , Paul Cercueil , Iskren Chernev , Krzysztof Kozlowski , Marek Szyprowski , Matheus Castello , Saravanan Sekar , Matthias Brugger , AngeloGioacchino Del Regno , Casey Connolly , Pali =?UTF-8?B?Um9ow6Fy?= , Orson Zhai , Baolin Wang , Chunyan Zhang , Amit Kucheria , Thara Gopinath , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Claudiu Beznea , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Sylwester Nawrocki , Olivier Moysan , Arnaud Pouliquen , Maxime Coquelin , Alexandre Torgue , David Lechner , Thomas Petazzoni , linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-iio@vger.kernel.org, linux-input@vger.kernel.org, linux-phy@lists.infradead.org, linux-pm@vger.kernel.org, linux-mips@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-sound@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com Subject: Re: [PATCH] iio: inkern: Use namespaced exports Message-ID: <20251207140046.56322d6f@jic23-huawei> In-Reply-To: <5948030.DvuYhMxLoT@fw-rgant> References: <20251201-iio-inkern-use-namespaced-exports-v1-1-da1935f70243@bootlin.com> <78240755-44dc-4835-aca5-99540cca0304@baylibre.com> <5948030.DvuYhMxLoT@fw-rgant> X-Mailer: Claws Mail 4.3.1 (GTK 3.24.51; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-mips@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 02 Dec 2025 08:30:58 +0100 Romain Gantois wrote: > On Monday, 1 December 2025 18:15:54 CET David Lechner wrote: > > On 12/1/25 4:59 AM, Romain Gantois wrote: > > > Use namespaced exports for IIO consumer API functions. > > > > > > Signed-off-by: Romain Gantois > > > --- > > > > ... > > > > > diff --git a/drivers/iio/dac/ds4424.c b/drivers/iio/dac/ds4424.c > > > index a8198ba4f98a..33d6692f46fe 100644 > > > --- a/drivers/iio/dac/ds4424.c > > > +++ b/drivers/iio/dac/ds4424.c > > > @@ -14,7 +14,6 @@ > > > > > > #include > > > #include > > > #include > > > > > > -#include > > > > Unrelated change? > > Indeed, I'll leave that out in v2. Please spin a precursor patch that makes that change. That way we can easily check all files either both include that header and have the namespace enabled, or neither. I might merge this is a slightly funny way that leave it initially not meeting that rule so that the precursor isn't in the immutable branch for other subsystems but lets keep it logical in the patch set! Jonathan > > > > #define DS4422_MAX_DAC_CHANNELS 2 > > > #define DS4424_MAX_DAC_CHANNELS 4 > > > > > > @@ -321,3 +320,4 @@ MODULE_AUTHOR("Ismail H. Kose > > > ");> > > > MODULE_AUTHOR("Vishal Sood "); > > > MODULE_AUTHOR("David Jung "); > > > MODULE_LICENSE("GPL v2"); > > > > > > +MODULE_IMPORT_NS("IIO_CONSUMER"); > > > > Is this actually needed if we don't use anything from consumer.h? > > No, it's not. > > Thanks, >