From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 98E5633D503; Tue, 20 Jan 2026 19:24:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768937055; cv=none; b=WN00EveBp2gfJyNElRFvZ1kOs5Ebk/QpUdqp1RKnhnlR/JOB/EX8ouITYu4Fqri9WweaWadz6TQVouHcs7Mr+RftFwKRmVaHTFZuPen4gEfoOmgGuBCIhVb4/7ZyZwTqzHA9qLHV6P5xn4PR+WdHf5YXVqunR7Mii/EQc9fGOfM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768937055; c=relaxed/simple; bh=LSPGDVxdxLZfskYwh4ntJXztlGxHOonJ/Pc/EAyXgrk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cZZCmqT5sqGn1r1g8CnJt10cjLUxP9vNw6H00UrE1aSv4BV20Y/B2qHJ6wZ64JvWgdJh22gKL4QfEnWj66GxHQmSSPBCFV9IT7SYLft3K8ygOIjWqgfeG93anp5mm7IKrMznMWAqWJKmkJRIbA5C8WJe/of2xVtyxIRDiKx+kAQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=FeCjTyYn; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FeCjTyYn" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3030BC16AAE; Tue, 20 Jan 2026 19:24:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1768937055; bh=LSPGDVxdxLZfskYwh4ntJXztlGxHOonJ/Pc/EAyXgrk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FeCjTyYnH6/h/8uF6l6ik0fo2x93XB0OqqG24S+3Ram+dhWrkIGplP+ddtkceb7Tl lUlb96gKz7eLqtRAUtD0tsAW0+Db0PfdUIRQCTDHqxVIXodkB7fPth/GLpcrMV5x0d EUtdREmOIDqTxbRQOqhLKZpAy5rXwXqpbfQ+j8mluc8JxCXZHfAear09HZJ3bbRYTJ ON/gS/gPgz44dufE6UuqY4wTIiDqbD3QvqZj+ISoXZw2/sCXPEcL8GSo0C351yjBx3 pxQaaabowXCH+6Dt4FVJXwu/yfyL/OTMKR6dDhSF/tluReZy/dZLKqRFqyK/7X3Ihp qaBbj/qZmUh6g== Date: Tue, 20 Jan 2026 19:24:09 +0000 From: Conor Dooley To: Alexandre Belloni Cc: Binbin Zhou , Binbin Zhou , Huacai Chen , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-rtc@vger.kernel.org, Xiaochuang Mao , Huacai Chen , Xuerui Wang , loongarch@lists.linux.dev, devicetree@vger.kernel.org, linux-mips@vger.kernel.org, Keguang Zhang Subject: Re: [PATCH v3 1/3] dt-bindings: rtc: loongson: Correct Loongson-1C interrupts property Message-ID: <20260120-cubical-harmonica-a7b7bbb26b08@spud> References: <20260119-tricking-premiere-ada70700f804@spud> <20260120075045e7e864ba@mail.local> Precedence: bulk X-Mailing-List: linux-mips@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="wAUtleroU8i/CJJy" Content-Disposition: inline In-Reply-To: <20260120075045e7e864ba@mail.local> --wAUtleroU8i/CJJy Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jan 20, 2026 at 08:50:45AM +0100, Alexandre Belloni wrote: > On 19/01/2026 18:24:36+0000, Conor Dooley wrote: > > On Sat, Jan 17, 2026 at 10:26:48AM +0800, Binbin Zhou wrote: > > > The `interrupts` property indicates an RTC alarm interrupt, which is > > > required for RTCs that support the alarm feature, which is not suppor= ted > > > by the Loongson-1C RTC. We exclude it for a more accurate description. > > >=20 > > > Changing the `allowed` property is ABI-breaking behavior, but > > > throughout the existing Loongson DTS{i}, the description of the RTC > > > nodes conforms to the modified bingding rules. > >=20 > > Right, changing properties is an ABI break, but when following the ABI > > would've produced something non-functional, breaking it is not really > > relevant. >=20 >=20 > But the HW has the interrupt, the fact that is not functional doesn't > mean it isn't there. I thought we should describe the hardware? Does the hardware have it? My interpretation of the commit message was that it didn't have the alarm feature and thus no interrupt? Unless the interrupt has some other purpose, in which case yeah we shouldn't accept this change and only the new device should permit there being no interrupt. >=20 > > Acked-by: Conor Dooley > > pw-bot: not-applicable > >=20 > > >=20 > > > Thus, the existing Loongson DTS{i} will not be affected. > > >=20 > > > Fixes: 487ef32caebe ("dt-bindings: rtc: Split loongson,ls2x-rtc into = SoC-based compatibles") > > > Reviewed-by: Huacai Chen > > > Signed-off-by: Binbin Zhou > > > --- > > > .../devicetree/bindings/rtc/loongson,rtc.yaml | 11 +++++++++= ++ > > > 1 file changed, 11 insertions(+) > > >=20 > > > diff --git a/Documentation/devicetree/bindings/rtc/loongson,rtc.yaml = b/Documentation/devicetree/bindings/rtc/loongson,rtc.yaml > > > index f89c1f660aee..fac90a18153e 100644 > > > --- a/Documentation/devicetree/bindings/rtc/loongson,rtc.yaml > > > +++ b/Documentation/devicetree/bindings/rtc/loongson,rtc.yaml > > > @@ -42,6 +42,17 @@ required: > > > =20 > > > unevaluatedProperties: false > > > =20 > > > +if: > > > + properties: > > > + compatible: > > > + contains: > > > + enum: > > > + - loongson,ls1c-rtc > > > + > > > +then: > > > + properties: > > > + interrupts: false > > > + > > > examples: > > > - | > > > #include > > > --=20 > > > 2.47.3 > > >=20 >=20 >=20 >=20 > --=20 > Alexandre Belloni, co-owner and COO, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com --wAUtleroU8i/CJJy Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCaW/WWQAKCRB4tDGHoIJi 0mn/AP43jnywh9Iriywei4qmEhxIxv4dAHCkLsmZAd9rkv4/IQD+JwBwbjIW1k5/ 8nNDMbQlTAQNEYfUnJQFA4IRoYdODAM= =Xl/3 -----END PGP SIGNATURE----- --wAUtleroU8i/CJJy--