From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF54A3E958F for ; Tue, 20 Jan 2026 22:49:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768949370; cv=none; b=QeGgMump4NQjwyFbPbP76DH9YuxuxwXdVL+CUtQb0z8CauisnLHospDm58RT5vjGVhVtWxXAVlpb6Dt6Xe6FbB4mfHBRZeSExmkTW3TJyINfeEOfQzMQ0gGXDA6NVRDKMqK8A7H145QIQO8I/JBq9L06ALGIaRbUE6DG6jy9sls= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768949370; c=relaxed/simple; bh=q2BBqQqtjFB8ySi+/D20hdD9Q7tjuVZO2BGEmvHHnRY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Bl9QvzkIQqUvGSMYAzuMoiNEjzpxG0Vnikaz5WfusQmGzySFSEAZ8Yg2d7IaQmfU7HORLDJMvfNrnNbU+IK0MPJVGBUHxR+RKgCvvWTWyBCm2Ug9OBJYf4zHo+8cAeohDli8i7E6LoJP+jX4CVaLL5z+R5yCvsf4QRC411JN8hs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=FVbssmC7; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="FVbssmC7" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id 748C54E421BA; Tue, 20 Jan 2026 22:49:26 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 47D8E606AB; Tue, 20 Jan 2026 22:49:26 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 03583119B01D6; Tue, 20 Jan 2026 23:49:20 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1768949365; h=from:subject:date:message-id:to:cc:mime-version:content-type: in-reply-to:references; bh=fugztaeaHNRM37Axp9dzYHeQYhLSc0vSFllOB04u4oQ=; b=FVbssmC7V7KjEftXArVr20pRSRzONvUahw0c/uJ9yIFlGaZmiYtUxGfBee25jY8gKO30Xd D+WL9xihZY5l7M+nXRjiEvyU5oId/pwZA9cbcN2b9cAaYJ3E8KZVfiZAn4BVV/Y1MO+yfV FviIYTMllbUerHXjqioQukTcvkH8CxECbjzxPbXrlUQOkJ3boj1X+Fot+uiMXPVlMzejPy K9Ca1t+D5obGrBqQNk2D8sOkIg6Z4vbGFRtQCSKs2SuHWMGy0GnAEogK6DKae9UFwplXx8 C8+H8R1NfB7MxVPqwlkYpNuoT57OyjRNZpnm1bcyN+tTAvkbzrqd7rrTu3FiNQ== Date: Tue, 20 Jan 2026 23:49:20 +0100 From: Alexandre Belloni To: Conor Dooley Cc: Binbin Zhou , Binbin Zhou , Huacai Chen , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-rtc@vger.kernel.org, Xiaochuang Mao , Huacai Chen , Xuerui Wang , loongarch@lists.linux.dev, devicetree@vger.kernel.org, linux-mips@vger.kernel.org, Keguang Zhang Subject: Re: [PATCH v3 1/3] dt-bindings: rtc: loongson: Correct Loongson-1C interrupts property Message-ID: <20260120224920df0cf2ac@mail.local> References: <20260119-tricking-premiere-ada70700f804@spud> <20260120075045e7e864ba@mail.local> <20260120-cubical-harmonica-a7b7bbb26b08@spud> Precedence: bulk X-Mailing-List: linux-mips@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260120-cubical-harmonica-a7b7bbb26b08@spud> X-Last-TLS-Session-Version: TLSv1.3 On 20/01/2026 19:24:09+0000, Conor Dooley wrote: > On Tue, Jan 20, 2026 at 08:50:45AM +0100, Alexandre Belloni wrote: > > On 19/01/2026 18:24:36+0000, Conor Dooley wrote: > > > On Sat, Jan 17, 2026 at 10:26:48AM +0800, Binbin Zhou wrote: > > > > The `interrupts` property indicates an RTC alarm interrupt, which is > > > > required for RTCs that support the alarm feature, which is not supported > > > > by the Loongson-1C RTC. We exclude it for a more accurate description. > > > > > > > > Changing the `allowed` property is ABI-breaking behavior, but > > > > throughout the existing Loongson DTS{i}, the description of the RTC > > > > nodes conforms to the modified bingding rules. > > > > > > Right, changing properties is an ABI break, but when following the ABI > > > would've produced something non-functional, breaking it is not really > > > relevant. > > > > > > But the HW has the interrupt, the fact that is not functional doesn't > > mean it isn't there. I thought we should describe the hardware? > > Does the hardware have it? My interpretation of the commit message was > that it didn't have the alarm feature and thus no interrupt? Unless the > interrupt has some other purpose, in which case yeah we shouldn't accept > this change and only the new device should permit there being no > interrupt. The datasheet shows the interrupt coming out of the RTC and it has the proper registers. Why it is not functional is not clear to me. -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com